February 2024 - Wine-gitlab

Re: [PATCH v3 0/5] MR5021: windows.security.authentication.onlineid: Implement IOnlineIdSystemAuthenticatorStatics::get_Default().
by Mohamad Al-Jaf (＠maljaf) 13 Feb '24

13 Feb '24

On Tue Feb 6 14:11:59 2024 +0000, Mohamad Al-Jaf wrote: > FWIW this class is required for a cloud feature > >With the System Ticket feature, an app can provide cloud services to a > user and store user info even if the user is not signed on with their > Microsoft account (MSA). The app can acquire information about the local > user account on a system, as well as information about the system itself, > in order to keep track of settings and data for this user. > https://learn.microsoft.com/en-us/uwp/api/windows.security.authentication.o… > Regarding office, it requires numerous workarounds so it's time consuming > to test. Adding this class for Minecraft Education Edition didn't break > anything. I think Affinity Photo may have used it as well and it too worked > without issue. I don't see how this is different from previous MRs that didn't help with any application, but were approved anyway like the windows.ui IUISettings and InputPane stub interfaces. At least in this case there's a possibility it would help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5021#note_60968

1 0

[PATCH v3 0/6] MR631: vkd3d: Implement UpdateTileMappings().
by Conor McCarthy (＠cmccarthy) 13 Feb '24

13 Feb '24

-- v3: vkd3d: Support aliased tile binding if available. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for textures. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for buffers. vkd3d: Pre-bind sparse texture mip tails. tests/d3d12: Add a test for freeing underlying memory of a reserved resource. tests/d3d12: Add tests for UpdateTileMappings(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/631

2 6

[PATCH v7 0/6] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) 13 Feb '24

13 Feb '24

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v7: vkd3d-shader/hlsl: Parse Buffer types. tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

3 9

[PATCH v5 0/2] MR5064: Handle DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 properly
by Fabian Maurer (＠DarkShadow44) 13 Feb '24

13 Feb '24

-- v5: user32/sysparams: Handle more contexts in GetAwarenessFromDpiAwarenessContext https://gitlab.winehq.org/wine/wine/-/merge_requests/5064

2 2

Re: [PATCH v4 0/2] MR5064: Handle DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 properly
by Fabian Maurer (＠DarkShadow44) 13 Feb '24

13 Feb '24

On Tue Feb 13 00:30:57 2024 +0000, Fabian Maurer wrote: > changed this line in [version 4 of the diff](/wine/wine/-/merge_requests/5064/diffs?diff_id=99247&start_sha=0189eb79f8110a1171a1974a651ca1ef0ae40afb#a3eabccd5496fd63ed6cbf28e676e5cb5c58689e_3981_4004) Sure, updated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5064#note_60959

1 0

[PATCH v5 0/10] MR4954: kernelbase: Reimplement UrlCanonicalize().
by Zebediah Figura (＠zfigura) 12 Feb '24

12 Feb '24

Normally I am a strong proponent of adjusting implementations one small step at a time, but this is a bit of an extreme case. The current state of UrlCanonicalize() is a prototypical example of "spaghetti code": the implementation has been repeatedly adjusted to fix a new discovered edge case, without properly testing the scope of the new logic, with the effect that the current logic is a scattered mess of conditions that interact in unpredictable ways. To be fair, the actual function is much more complicated than one would anticipate, and the number of new weird edge cases I found while trying to flesh out existing logic was rather exhausting. I initially tried to "fix" the existing implementation one step at a time. After racking up dozens of commits without an end in sight, though, and having to waste time carefully unravelling the broken code in the right order so as to avoid temporary failures, I decided instead to just fix everything at once, effectively rewriting the function from scratch, and this proved to be much more productive. Hopefully the huge swath of new tests is enough to prove that this new implementation really is correct, and has no more spaghetti than what Microsoft made necessary. -- v5: shlwapi/tests: Add many more tests for UrlCanonicalize(). kernelbase: Use scheme_is_opaque() in UrlIs(). kernelbase: Reimplement UrlCanonicalize(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4954

3 12

Re: [PATCH v2 0/1] MR5050: kernelbase: Copy the read-only attribute from the source. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5050

1 0

[PATCH v2 0/2] MR5069: Draft: wininet: Avoid crash in InternetCreateUrl with scheme unknown.
by Bernhard Übelacker 12 Feb '24

12 Feb '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33050 -- v2: wininet: Avoid crash in InternetCreateUrl with scheme unknown. wininet: Add missing assignment of return value. https://gitlab.winehq.org/wine/wine/-/merge_requests/5069

2 3

Re: [PATCH v14 0/7] MR4082: gdiplus: Implement font linking in GdipDrawString. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4082

1 0

Re: [PATCH v3 0/5] MR5048: jscript: ArrayBuffer and DataView implementations. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5048

1 0