February 2024 - Wine-gitlab

Re: [PATCH v3 0/5] MR5049: CreateProcess and erroneous std handles. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5049

1 0

Re: [PATCH v4 0/2] MR277: cmd: Handle lines with just spaces in bracket blocks. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/277

1 0

Re: [PATCH v2 0/8] MR5065: wininet: Improve proxy configuration reading and writing. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5065

1 0

Re: [PATCH v3 0/5] MR5067: winex11: Refactor XInput2 initialization and request version 2.2. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5067

1 0

Re: [PATCH v4 0/1] MR5040: dmband: Implement getting/setting GUID_BandParam on band tracks. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5040

1 0

[PATCH 0/6] MR5072: sapi: Implement some methods for ISpeechObjectToken(s).
by Shaun Ren (＠shaunren) 12 Feb '24

12 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5072

3 7

[PATCH v8 0/1] MR5020: kernelbase/file: implement CopyFile2
by Kartavya Vashishtha (＠kvashis) 12 Feb '24

12 Feb '24

copy implementation of CopyFileExW into CopyFile2, then implement CopyFileExW in terms of CopyFile2 should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2. I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended. I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up. -- v8: implement CopyFile2 https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

4 9

[PATCH v2 0/3] MR4987: ntdll: Support generic xstate (part 1).
by Paul Gofman (＠gofman) 12 Feb '24

12 Feb '24

This is a preparation for supporting more xstate features in the contexts. The remaining parts are: - support arbitrary xstate in usr1_handler(); - support arbitrary xstate in the server contexts (probably transferring only the present part); - support arbitrary xstate in context manipulation functions; - enabling more xstates in system.c and in user shared data. -- v2: ntdll: Don't hardcode xstate size in exception stack layout. ntdll: Don't hardcode xstate size in syscall frame. ntdll: Don't hardcode xstate feature mask. https://gitlab.winehq.org/wine/wine/-/merge_requests/4987

3 6

Re: [PATCH v7 0/1] MR3368: where: Implement search with default options.
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

Alexandre Julliard (@julliard) commented about programs/where/main.c: > + wcscpy(glob, search_path); > + wcscat(glob, L"\\"); > + wcscat(glob, pattern); > + wcscat(glob, extensions[i]); > + > + handle = FindFirstFileExW(glob, FindExInfoBasic, &match, 0, NULL, 0); > + more = (handle != INVALID_HANDLE_VALUE); > + > + while (more) > + { > + if (PathCombineW(match_path, search_path, match.cFileName)) > + { > + printf("%ls\n", match_path); > + found = TRUE; > + } > + more = FindNextFileW(handle, &match); This is not the correct pattern for FindFirstFile/FindNextFile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3368#note_60920

1 0

Re: [PATCH v7 0/1] MR3368: where: Implement search with default options.
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

Alexandre Julliard (@julliard) commented about programs/where/main.c: > + if (colon) > + { > + *colon = 0; > + search_paths = pattern; > + pattern = colon + 1; > + } > + else > + { > + DWORD len = GetEnvironmentVariableW(L"PATH", NULL, 0); > + search_paths = malloc(len * sizeof(WCHAR)); > + if (!search_paths) > + { > + ERR("Out of memory\n"); > + return 1; > + } > + GetEnvironmentVariableW(L"PATH", search_paths, len); You want wgetenv(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3368#note_60921

1 0