March 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/5] MR5306: win32u: Move D3DKMT vulkan implementation out of winex11.
by Rémi Bernon 25 Mar '24

25 Mar '24

With some intermediate refactoring to make the code simpler. I believe the failures that happened previously were coming from how NtGdiDdDDIOpenAdapterFromLuid initialized desc->hAdapter in win32u while winex11 was then relying on it. I missed this detail before and it should be working fine now that the vulkan path is only used to retrieve the physical device. -- v2: win32u: Move D3DKMT vulkan implementation out of winex11. winex11: Introduce a new find_adapter_from_handle helper. winex11: Introduce a new get_vulkan_physical_device helper. winex11: Initialize D3DKMT vulkan instance only once. win32u: Open adapters in NtGdiDdDDIEnumAdapters2 outside of the display devices lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/5306

3 10

Re: [PATCH v4 0/5] MR5365: win32u: Introduce a new common vulkan source.
by Brendan Shanks (＠bshanks) 25 Mar '24

25 Mar '24

Brendan Shanks (@bshanks) commented about configure.ac: > WINE_CHECK_SONAME(vulkan, vkGetInstanceProcAddr) > if test "x$ac_cv_lib_soname_vulkan" = "x" > then > - WINE_CHECK_SONAME(MoltenVK, vkGetInstanceProcAddr) > + WINE_CHECK_SONAME(MoltenVK, vkGetInstanceProcAddr, [AC_DEFINE_UNQUOTED(SONAME_LIBVULKAN,[$ac_cv_lib_soname_MoltenVK])]) This is causing build errors for me: ``` ../dlls/win32u/vulkan.c:91:35: error: use of undeclared identifier 'libMoltenVK' if (!(vulkan_handle = dlopen( SONAME_LIBVULKAN, RTLD_NOW ))) ^ include/config.h:773:26: note: expanded from macro 'SONAME_LIBVULKAN' #define SONAME_LIBVULKAN libMoltenVK.dylib ^ ../dlls/win32u/vulkan.c:93:37: error: use of undeclared identifier 'libMoltenVK' ERR( "Failed to load %s\n", SONAME_LIBVULKAN ); ^ include/config.h:773:26: note: expanded from macro 'SONAME_LIBVULKAN' #define SONAME_LIBVULKAN libMoltenVK.dylib ^ 2 errors generated. make[1]: *** [dlls/win32u/vulkan.o] Error 1 ``` I think quotes are needed around `$ac_cv_lib_soname_MoltenVK`, that results in `SONAME_LIBVULKAN` being correctly quoted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5365#note_65955

1 0

[PATCH 0/1] MR5395: dwrite/shape: Fully initialize shaping context when getting glyph positions (Valgrind).
by Nikolay Sivov (＠nsivov) 24 Mar '24

24 Mar '24

Actual issue is uninitialized has_gpos_attachment flag, it might be harmless in practice but it's better to avoid. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5395

2 1

[PATCH v2 0/1] MR5394: d3dcompiler: Add D3DDecompressShaders stub.
by Vijay Kiran Kamuju (＠infyquest) 24 Mar '24

24 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46010 -- v2: d3dcompiler: Add D3DDecompressShaders stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/5394

3 4

[PATCH 0/1] MR5394: d3dcompiler: Add D3DDecompressShaders stub.
by Vijay Kiran Kamuju (＠infyquest) 24 Mar '24

24 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46010 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5394

2 1

[PATCH 0/1] MR5393: d2d1: Fix a double free on error path (Valgrind).
by Nikolay Sivov (＠nsivov) 24 Mar '24

24 Mar '24

This fixes test crashes for me that are relatively easy to reproduce. With the fix I had 100 successful runs. Thanks to @rbernon for the help with valgrind setup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5393

2 1

[PATCH 0/1] MR5360: gdiplus: Check for empty height in bonding box calculation
by James McDonnell (＠ElementalWarrior) 23 Mar '24

23 Mar '24

This resolves the issue in StudioTax where the bounding box dimensions is reported as 0. Because the height is less than 0, the check for height in GdipAddPathRectangle fails, and the X and Y coordinates of the points is never set. I am fairly ignorant of this code, this seems like a good approach, however I am happy for guidance from others more familiar in how gdiplus works. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5360

4 5

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Rémi Bernon 23 Mar '24

23 Mar '24

On Sat Mar 23 07:46:33 2024 +0000, eszlari wrote: > I guess @julliard is waiting for a review by @rbernon. It's perhaps instead that approval only show up if the person is assigned as a reviewer, or that it was overlooked. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_65890

1 0

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by eszlari (＠eszlari) 23 Mar '24

23 Mar '24

On Sat Mar 23 07:46:33 2024 +0000, llyyr wrote: > Any update on this? Would be nice to have it merged before the next > tagged release I guess @julliard is waiting for a review by @rbernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_65888

1 0

[PATCH v2 0/2] MR5392: win32u: Avoid writing past allocated memory in peek_message().
by Paul Gofman (＠gofman) 23 Mar '24

23 Mar '24

-- v2: win32u: Avoid leaking previous buffer in get_buffer_space(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5392

2 2