March 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + *RtlSubAuthoritySid(sidwin7, 1) = DOMAIN_ALIAS_RID_ADMINS; > + > + sid2 = ExAllocatePool(NonPagedPool, RtlLengthRequiredSid(1)); > + RtlInitializeSid(sid2, &auth, 1); > + *RtlSubAuthoritySid(sid2, 0) = SECURITY_LOCAL_SYSTEM_RID; > + > + /* SECURITY_BUILTIN_DOMAIN_RID */ > + status = RtlGetAce(acl, 0, (void**)&ace); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + > + ok(ace->Header.AceType == ACCESS_ALLOWED_ACE_TYPE, "got %#x\n", ace->Header.AceType); > + ok(ace->Header.AceFlags == 0, "got %#x\n", ace->Header.AceFlags); > + ok(ace->Mask == STANDARD_RIGHTS_ALL, "got %#lx\n", ace->Mask); > + > + ret = RtlEqualSid(sid1, (PSID)&ace->SidStart) || RtlEqualSid(sidwin7, (PSID)&ace->SidStart); > + ok(ret, "SID not equal\n"); Maybe it'd be a bit simpler to test the SID elements individually rather than constructing a SID and using RtlEqualSid()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65055

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/fltmgr.sys/main.c: > + goto done; > + RtlInitializeSid(sid, &auth, 2); > + sid->SubAuthority[1] = DOMAIN_GROUP_RID_ADMINS; > + sid->SubAuthority[0] = SECURITY_BUILTIN_DOMAIN_RID; > + > + sid_len = RtlLengthRequiredSid(1); > + sid_system = ExAllocatePool(PagedPool, sid_len); > + if (!sid_system) > + goto done; > + RtlInitializeSid(sid_system, &auth, 1); > + sid_system->SubAuthority[0] = SECURITY_LOCAL_SYSTEM_RID; > + > + sid_len = SECURITY_DESCRIPTOR_MIN_LENGTH + sizeof(ACL) + > + sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid) + > + sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid_system); > + Maybe rename "sid_len" to "len" if you're going to use it for other things? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65052

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/fltmgr.sys/main.c: > > return func; > } > + > +NTSTATUS WINAPI FltBuildDefaultSecurityDescriptor(PSECURITY_DESCRIPTOR *descriptor, ACCESS_MASK access) > +{ > + PACL dacl; > + NTSTATUS ret = STATUS_INSUFFICIENT_RESOURCES; This initialization isn't doing anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65051

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Nikolay Sivov (＠nsivov) 16 Mar '24

16 Mar '24

@alesliehughes could you remind me what this was going to fix? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65050

1 0

[PATCH 0/1] MR1228: wined3d: support direct3d shader model 1,2,3
by Fan WenJie (＠fanwenjie) 16 Mar '24

16 Mar '24

vkd3d_shader_compile_info::source_type can not hard write to VKD3D_SHADER_SOURCE_DXBC_TPF, it is decided by magic number of shader source. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1228

4 5

[PATCH 0/1] MR5332: user32/tests: Accept WM_ACTIVATE in TrackPopupMenu.
by Esme Povirk (＠madewokherd) 16 Mar '24

16 Mar '24

https://test.winehq.org/data/552cc456d1889ab3ee0dd5ead6c7520c34d030c0/w1121… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5332

2 1

[PATCH v3 0/2] MR5247: user32/msgbox: Support WM_COPY Message
by Alistair Leslie-Hughes (＠alesliehughes) 16 Mar '24

16 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=17205 -- v3: user32/msgbox: Use a windows hook to trap Ctrl+C user32/msgbox: Support WM_COPY Message https://gitlab.winehq.org/wine/wine/-/merge_requests/5247

4 9

[PATCH v24 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon 16 Mar '24

16 Mar '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v24: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

2 29

[PATCH v2 0/8] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) 16 Mar '24

16 Mar '24

This is a series of commits tackling dead key state handling and scan code to vkey mapping improvements (especially for French and German keyboards). * https://gitlab.winehq.org/mzent/wine/-/commit/6c5c90b746cc341049eec216e3bb9…: Simplifies the logic a bit there and also correctly null-terminates dead keys in ToUnicodeEx * https://gitlab.winehq.org/mzent/wine/-/commit/a05e2fc5068a22cae94bc800b4972…: Windows does not do it and some applications misbehave with this, fully fixed later in https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c… * https://gitlab.winehq.org/mzent/wine/-/commit/4bd96932139a22f2c3b1311e44c43…: MSDN states single keys are always uppercased there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac8e97d7e6a7494672d76f5fc586…: There is a bug in `CFStringCompare` with the flags used there currently, resulting in the comparison of the identical buffers "ß" and "ß" to be false. In any case `UCCompareText` behaves correctly and is much faster there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac5f485a09fbddd39efb8f2c0d87…: I think this was an accidental mistake there, going through all modifiers first per symbol almost always results in the wrong match being made. The logic is adjusted there now to be similar to the other iterations involving `char_matches_string`. * https://gitlab.winehq.org/mzent/wine/-/commit/ffde55df4ae3f6d53198839c58356… https://gitlab.winehq.org/mzent/wine/-/commit/a453d0d4c89c59c3e1ba6c24d2d0f…: Adds additional symbol vkey mappings (now completely maps a German Macintosh and PC keyboard correctly). There are still some minor defects with the French layout (around the ú region), however changing the symbol mapping there will cause issues with other layouts I think, since the wrong match happens very early there in the priority in these cases. With this change at least the number row is now behaving correctly. Additionally the French Macintosh keyboard layout is further complicated by the "=" key being next to right shift, which is in conflict with pretty much any other keyboard layout. To fix this properly would require a partial rewrite of the heuristic being used or a new approach, but most likely more of a long term project. * https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c…: Gives dead keys friendly names in `GetKeyNameFriendlyText`, just like Windows does. I tried to be as exhaustive as possible, but if there are any missing the mapping can be easily extended. All in all the incorrect scan code to vkey mapping is usually not that tragic, since an application would need to be aware of the layout and have its own mapping of scan codes of each (FFXIV does this though). The French layout corrections are now "good enough" to behave correctly for all the hotbar slots being assigned there with these changes now though. -- v2: winemac.drv: Give dead keys a friendly name in GetKeyNameText. winemac.drv: Add additional French symbol vkeys. winemac.drv: Add additional German symbol vkeys. winemac.drv: Resolve symbol vkeys first without modifiers. winemac.drv: Use UCCompareText in char_matches_string. winemac.drv: Uppercase single keys in GetKeyNameText. winemac.drv: Do not append " dead" to dead keycodes in GetKeyNameText. winemac.drv: Handle length of dead keycodes in ToUnicodeEx correctly. https://gitlab.winehq.org/wine/wine/-/merge_requests/5319

3 12

[PATCH 0/1] MR5330: server: Check for DELETE access in NtMakeTemporaryObject().
by Jinoh Kang (＠iamahuman) 16 Mar '24

16 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5330

3 2