March 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/2] MR5335: shell32: Create nonexistent destination directories in FO_MOVE. - approved
by Zebediah Figura (＠zfigura) 17 Mar '24

17 Mar '24

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5335

1 0

[PATCH 0/1] MR5336: d3dcompiler_47: Stub D3DCreateLinker.
by Vijay Kiran Kamuju (＠infyquest) 17 Mar '24

17 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52622 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5336

2 1

[PATCH 0/2] MR5335: shell32: Create nonexistent destination directories in FO_MOVE.
by Zebediah Figura (＠zfigura) 17 Mar '24

17 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5335

3 2

[PATCH 0/1] MR1269: wined3d: Disable CSMT when running on a single core.
by Anton Baskanov (＠baskanov) 17 Mar '24

17 Mar '24

- Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45893 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47767 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44546 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1269

6 11

[PATCH 0/1] MR5334: msxml6/tests: Add some tests for MXWriter60.
by Nikolay Sivov (＠nsivov) 16 Mar '24

16 Mar '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5334

3 2

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Alistair Leslie-Hughes (＠alesliehughes) 16 Mar '24

16 Mar '24

On Sat Mar 16 23:31:12 2024 +0000, Nikolay Sivov wrote: > So, no bigger plan other than fixing up idls basically? I currently don't have one. Through wine-staging patches for FreeThreadedXMLHTTP60 interface rely on this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65058

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Nikolay Sivov (＠nsivov) 16 Mar '24

16 Mar '24

On Sat Mar 16 23:31:12 2024 +0000, Alistair Leslie-Hughes wrote: > First brings the headers inline with the SDK. > Second allows you to build against the wine headers without getting a > link time GUID duplicates. So, no bigger plan other than fixing up idls basically? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65057

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Alistair Leslie-Hughes (＠alesliehughes) 16 Mar '24

16 Mar '24

First brings the headers inline with the SDK. Second allows you to build against the wine headers without getting a link time GUID duplicates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65056

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + PSID group = NULL, owner = NULL; > + BOOLEAN isdefault, present; > + PACL acl = NULL; > + PACCESS_ALLOWED_ACE ace; > + SID_IDENTIFIER_AUTHORITY auth = { SECURITY_NULL_SID_AUTHORITY }; > + SID_IDENTIFIER_AUTHORITY authwine7 = { SECURITY_NT_AUTHORITY }; > + PSID sid1, sid2, sidwin7; > + BOOL ret; > + > + status = FltBuildDefaultSecurityDescriptor(&sd, STANDARD_RIGHTS_ALL); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + if (status != STATUS_SUCCESS) > + { > + win_skip("Skipping FltBuildDefaultSecurityDescriptor tests\n"); > + return; > + } Do we need this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65053

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + } > + ok(sd != NULL, "Failed to return descriptor\n"); > + > + status = RtlGetGroupSecurityDescriptor(sd, &group, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(group == NULL, "group isn't NULL\n"); > + > + status = RtlGetOwnerSecurityDescriptor(sd, &owner, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(owner == NULL, "owner isn't NULL\n"); > + > + status = RtlGetDaclSecurityDescriptor(sd, &present, &acl, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(acl != NULL, "acl is NULL\n"); > + ok(acl->AceCount == 2, "got %d\n", acl->AceCount); > + Should we test "isdefault" here as well? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65054

1 0