May 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

Alexandre Julliard (@julliard) commented about dlls/win32u/sysparams.c: > > /* FIXME: what do the DpiScalingVer flags mean? */ > get_dword_entry( (union sysparam_all_entry *)&entry_DPISCALINGVER, 0, &dpi_scaling, 0 ); > - if (!dpi_scaling) NtUserSetProcessDpiAwarenessContext( NTUSER_DPI_PER_MONITOR_AWARE, 0 ); I don't think we can do that until the drivers support window scaling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71546

1 0

Re: [PATCH v2 0/4] MR5667: winegstreamer: Use GstCaps for wg_parser internal formats.
by Rémi Bernon 28 May '24

28 May '24

> If you wish to have me removed as maintainer of winegstreamer, please propose that directly, rather than abusing GitLab to get your patches committed. This is not an automated process and I don't think I'm abusing any mechanism here. > I'm sorry for not reviewing I find it very difficult to want to review promptly when my review is invariably met with argument, insistence that there is only one correct way to do things, and inability or unwillingness to view things from my perspective. Despite this, I am sorry, and I will try to renew my efforts to review better. I could say the very same thing the other way, I don't see how that would help us though. I've been working on this for almost two years straight now, and yet, I still have to nag people to get ~5 patches reviewed in a week and still have to argue almost every time that my approach is as good as another. So yes, the more I'm doing it, the less I'm interested in rewriting things over. Note that this has now also been tested in length, and every large change requested is also waste of all the time that's been spend there too. Yes, of course, incorrectness needs to be addressed, but internal implementation details shouldn't matter as much as external behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5667#note_71545

1 0

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon 28 May '24

28 May '24

v2: Fix some wineandroid build failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71544

1 0

[PATCH 0/2] MR5737: Draft: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

When `FindFirstFileA` is called with `<path>/<file>/*` (where file is expected to be a directory), Windows uses the `ERROR_DIRECTORY` error. This patch changes Wine's implementation to match Windows. This fixes a crash in Unity of Command II. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

3 4

Re: [PATCH v4 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Huw Davies (＠huw) 28 May '24

28 May '24

Huw Davies (@huw) commented about dlls/riched20/para.c: > COPY_FIELD(PFM_ALIGNMENT, wAlignment); > if (dwMask & PFM_TABSTOPS) > { > - para->fmt.cTabCount = pFmt->cTabCount; > - memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, pFmt->cTabCount*sizeof(LONG)); > + para->fmt.cTabCount = max(0, min(pFmt->cTabCount, MAX_TAB_STOPS)); /* Clamp between 0 and MAX_TAB_STOPS */ > + memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, para->fmt.cTabCount*sizeof(LONG)); ```suggestion:-1+0 /* Clamp between 0 and MAX_TAB_STOPS */ para->fmt.cTabCount = max(0, min(pFmt->cTabCount, MAX_TAB_STOPS)); memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, para->fmt.cTabCount * sizeof(LONG)); ``` Otherwise, looks fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71529

1 0

[PATCH 0/2] MR5740: Inlcude updates
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

Two patches to add two new interfaces and one to fix an existing one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5740

2 2

[PATCH 0/4] MR5735: win32u: Some fixes for Vulkan GPUs.
by Krzysztof Bogacki (＠Saancreed) 28 May '24

28 May '24

A bunch of fixes and improvements related to Vulkan GPUs in win32u. The first commit fixes a bug with enumeration of multiple GPUs, the next two are supposed to improve logging, the last one gets rid of unused variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5735

3 5

Re: [PATCH 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones.
by Rémi Bernon 28 May '24

28 May '24

```suggestion:-0+0 if (vulkan_uuid && !IsEqualGUID( vulkan_uuid, &empty_uuid )) ctx->gpu.vulkan_uuid = *vulkan_uuid; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5736#note_71523

1 0

Re: [PATCH 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones.
by Rémi Bernon 28 May '24

28 May '24

```suggestion:-0+0 static const GUID empty_uuid; ``` As it's static. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5736#note_71522

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon 28 May '24

28 May '24

On Mon May 27 20:37:43 2024 +0000, Elizabeth Figura wrote: > I'm not sure I see how? If a type is just declared in an import, and > defined in the main IDL, then we still want to define it. I don't see > how to distinguish those two cases. Can this really happen? If that's the case then sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71521

1 0