May 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

4 5

[PATCH v3 0/1] MR5231: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list.
by Aida Jonikienė 28 May '24

28 May '24

Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example) on the Linux side can lead to some games under Wine failing to load (so treat that variable as special). -- v3: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5231

1 2

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

On Thu Apr 18 23:08:03 2024 +0000, Aida Jonikienė wrote: > Has the memory leak been fixed? 🫗️ Patch 4/5 handles it, yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_68162

1 0

Re: [PATCH v2 0/2] MR5514: kernel32/tests: fixes for export forwarder test - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5514

1 0

Re: [PATCH v9 0/1] MR5188: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

1 0

Re: [PATCH v2 0/1] MR5513: ntdll: Use mangled function names in ARM64EC assembly. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5513

1 0

Re: [PATCH v4 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

Re: [PATCH v2 0/2] MR5510: light.msstyles: Use #fefefe instead of #ffffff for scrollbar parts. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5510

1 0

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Stefan Dösinger 28 May '24

28 May '24

> At the same time, I haven't seen any evidence that a modern GPU will ever perform better with a vertex buffer not in sysmem unless it's using the streaming pattern I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. Can you check D3DDEVICEDESC.dwMaxVertexCount on these cards? Regardless of what we do with these two patches I think we should reduce it to whatever Windows reports. (1024 in my case on Windows 11) Conceptually the two patches have my blessing though, regardless of specifics of what PoP3D is doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68141

1 0

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Aida Jonikienė 28 May '24

28 May '24

On Thu Apr 18 23:08:03 2024 +0000, Jinoh Kang wrote: > @rbernon Thanks for your review! Right now I'm tentatively putting this > MR on hold until I find a solution for a memory leak: a new (redundant) > dependency edge is added every time the application calls > `GetProcAddress()` on a forwarded ref. Has the memory leak been fixed? 🫗️ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_68140

1 0