June 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/4] MR5933: opengl32: Add default implementation for wglChoosePixelFormatARB.
by Alexandros Frantzis (＠afrantzis) 02 Jul '24

02 Jul '24

This MR adds a default implementation for `wglChoosePixelFormatARB` (in opengl32.dll) which will be used automatically if the driver populates the wgl_pixel_format ARB fields. Thus winex11 automatically uses this, and this MR removes the driver internal implementation. The second part of this MR adds `WGL_ARB_pixel_format` support for winewayland (we can move this to a separate MR, but I wanted to have another implementation to better assess the behavior). The `wglChoosePixelFormatARB` behavior is loosely modeled after the the AMD driver as discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5388. I tried to keep things simple to begin with, and the results I am getting in various apps/games are sensible, but please try this out so we can refine further. -- v2: winewayland: Support WGL_ARB_pixel_format_float. winewayland: Support WGL_ARB_pixel_format. winex11: Remove driver wglChoosePixelFormatARB implementation. opengl32: Add default implementation for wglChoosePixelFormatARB. https://gitlab.winehq.org/wine/wine/-/merge_requests/5933

4 11

[PATCH 0/2] MR4601: winegstreamer: Order output pins based on MPEG system header.
by Anton Baskanov (＠baskanov) 02 Jul '24

02 Jul '24

Fixes in-game video playback in Earth 2150. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4601

5 10

[PATCH 0/3] MR5955: winegstreamer/video_encoder: Implement input type functions.
by Ziqing Hui (＠zhui) 01 Jul '24

01 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5955

4 5

[PATCH 0/6] MR5940: server, win32u: Use the message queue shared memory to read the queue status.
by Rémi Bernon 01 Jul '24

01 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5940

2 9

[PATCH 0/3] MR5952: Draft: tools: Some GitLab CI changes.
by Aida Jonikienė 01 Jul '24

01 Jul '24

I have a question for Julliard before doing additional work: 1. Why do only MR test jobs have the extra-quiet winetest option enabled? I think it exposes test flakiness (which could be insightful in normal Wine jobs too) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5952

2 5

[PATCH 0/39] MR5615: Draft: winegstreamer: Convert media type to GstCaps directly instead of through an internal representation.
by Rémi Bernon 01 Jul '24

01 Jul '24

This saves ~1500 LoC, and at the same time allows mapping arbitrary long codec data back and forth GstCaps, which will be required to support arbitrary compressed formats. We can then for instance expose unknown codecs as Wine-specific subtypes, expose generic decoders and pass the backend GstCaps serialized in the codec data. It makes the code simpler by unifying all frontend mappings and only requiring mapping between GstCaps and a unified set of formats. Mapping between IMFMediaType and the AM_MEDIA_TYPE formats is done using the standard MF functions and are tested and validated in mfplat tests. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5615

3 7

[PATCH v2 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- v2: msi: Properly select first feature https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

3 4

[PATCH v4 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v4: user32: Send parent BN_CLICKED notification when a radio button get focused comctl32: Send parent BN_CLICKED notification when a radio button get focused user32/tests: Add tests for radio button WM_SETFOCUS comctl32/tests: Add tests for radio button WM_SETFOCUS https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

3 6

[PATCH 0/1] MR5961: cmd: Close file opened with popen with correct function (coverity)
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

Not 100% sure about this, maybe there is a reason it's done like that, but it looks like an oversight. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5961

2 1

[PATCH v34 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 30 Jun '24

30 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v34: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9