June 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Vijay Kiran Kamuju (＠infyquest) 29 Jun '24

29 Jun '24

Please upload the code to the bug and test it. This was an attempt to fix the bug based on observations. There can be issues, with the code. I dont need you to teach me code, Please don't make it personal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74751

1 0

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Loïc Rebmeister 29 Jun '24

29 Jun '24

Your pull request effectively make the code worse, as `{ L"Windows.Foundation.UniversalApiContract", 10, },` means `10` or lower. So `{ L"Windows.Foundation.UniversalApiContract", 7, },` was already included by `{ L"Windows.Foundation.UniversalApiContract", 10, },` But due to how `is_api_contract_present` work, it only take the first element with a name into consideration. This is a simplified pseudo code with comments of `is_api_contract_present` to show the loop stop at first name match: ```java boolean is_api_contract_present(String name,int version) { for (present_contract : present_contracts) // List though all entries if (present_contract.name == name)) // Check is name is equal return version <= present_contract.max_major; // Check if version is lower than max_major, and return return false; // No match found, return that we didn't found anything } ``` Note: the `return` keyword stop code execution, and return the value. (I'm assuming you didn't understood the code you sent there, as I'm pretty sure if you understood that code before sending it you wouldn't have opened this MR) Further more, `Windows.Foundation.UniversalApiContract` is a dotnet 5 feature. (Source: https://github.com/madewokherd/wine-mono/issues/151#issuecomment-1232824011) Wine (and Wine-mono) currently only support up to dotnet 4 on a clean install. If you want I can teach you code for free so you can actually read and understand the code before you are sending it to wine upstream. In the meantime I'll see what I can do to try to get the issue fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74750

1 0

[PATCH 0/3] MR5953: include: Add symbols for DirectXShaderCompiler project
by Biswapriyo Nath (＠Biswa96) 29 Jun '24

29 Jun '24

Required for https://github.com/microsoft/DirectXShaderCompiler.git -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5953

3 5

[PATCH v9 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 29 Jun '24

29 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v9: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

4 11

[PATCH 0/4] MR5908: misc: Use the correct interface for some COM calls.
by Elizabeth Figura (＠zfigura) 29 Jun '24

29 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5908

5 9

Re: [PATCH v2 0/3] MR5950: msado15 command properties implementation. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5950

1 0

Re: [PATCH v3 0/9] MR5947: win32u: Factor layered surface attributes out of the drivers. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5947

1 0

Re: [PATCH v2 0/5] MR5949: Cmd engine rewrite (part XII) - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5949

1 0

Re: [PATCH v2 0/6] MR5948: jscript: Always free jsdisp_t in jsdisp_free. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5948

1 0

Re: [PATCH v3 0/6] MR5931: winegstreamer: Implement output type functions. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5931

1 0