June 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by Piotr Caban (＠piotr) 05 Jun '24

05 Jun '24

On Wed Jun 5 13:11:29 2024 +0000, cqwrteur wrote: > Of course, there is. The problem is that ucrt can be statically linked > from Microsoft UCRT static ucrt can be put back to FILE* in dynamic > linking. And fast_io library is using that. gitlab is not showing the context very well. I was asking about `stdout == stdin+1` test. Does the library depend on that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72456

1 0

[PATCH v2 0/1] MR5786: gdi32: Use an internal NtUser call for D3DKMTOpenAdapterFromGdiDisplayName.
by Rémi Bernon 05 Jun '24

05 Jun '24

Fixes a deadlock with display_device_init mutex and display_lock when trying to open the D3DKMT adapter while holding the mutex in the caller. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56764 -- v2: gdi32: Use an internal NtUser call for D3DKMTOpenAdapterFromGdiDisplayName. https://gitlab.winehq.org/wine/wine/-/merge_requests/5786

2 3

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by Piotr Caban (＠piotr) 05 Jun '24

05 Jun '24

On Wed Jun 5 13:02:30 2024 +0000, cqwrteur wrote: > It is not. The problem is that ucrt can be statically linked from > Microsoft UCRT static ucrt can be put back to FILE* in dynamic linking. > And fast_io library is exploiting that to gain huge performance. The `ok(ptrold + cntold == file->_ptr + file->_cnt, ...);` test is redundant. You're testing `ptrold` and `cntold` values in earlier tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72454

1 0

[PATCH v2 0/5] MR5741: Draft: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) 05 Jun '24

05 Jun '24

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am thinking that for more straightforward integration with the keyboard repeat SPI parameters, the request should only support the `enable` flag and the server should query the SPI registry values to get `delay` and `period` when needed. I am wondering if there any caveats here since I don't see other code in the server querying registry values (well, except to implement the registry requests themselves). Also, I would hope that opening and caching the `HKCU\Control Panel\Keyboard` hkey would remove most of the cost of performing this operation (if that's even a concern at all). -- v2: win32u: Remove auto-repeat functionality. server: Implement key auto-repeat. server: Check message target process for raw keyboard device flags. user32: Add tests for cross-process raw keyboard events. server: Pass desktop to get_first_global_hook. https://gitlab.winehq.org/wine/wine/-/merge_requests/5741

3 17

[PATCH 0/1] MR5795: scrrun/dictionary: Implement putref_Item() method.
by Nikolay Sivov (＠nsivov) 05 Jun '24

05 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56781 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5795

3 2

[PATCH v3 0/6] MR5773: mmdevapi: Fake success in a few IAudioSessionControl2 methods
by Fabian Maurer (＠DarkShadow44) 05 Jun '24

05 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763 -- v3: mmdevapi: Implement IAudioSessionControl2 GetGroupingParam SetGroupingParam mmdevapi: Implement IAudioSessionControl2 GetIconPath / SetIconPath mmdevapi: Implement IAudioSessionControl2 GetDisplayName / SetDisplayName https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

5 11

[PATCH v3 0/1] MR5788: d3d11/tests: Add a test for NV12 textures.
by Giovanni Mascellani (＠giomasce) 05 Jun '24

05 Jun '24

-- v3: d3d11/tests: Add a test for NV12 textures. https://gitlab.winehq.org/wine/wine/-/merge_requests/5788

3 3

[PATCH 0/6] MR5763: wined3d: Fix some corner cases in the FFP pipelines related to unbound streams.
by Elizabeth Figura (＠zfigura) 05 Jun '24

05 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5763

4 10

[PATCH v2 0/5] MR5791: wineps.drv: Page size and orientation fixes
by Piotr Caban (＠piotr) 05 Jun '24

05 Jun '24

-- v2: wineps.drv: Add partial support for changing page size. wineps.drv: Write PageBoundingBox for every page. wineps.drv: Take all pages into account when computing bounding box. wineps.drv: Write page orientation hint for every page. https://gitlab.winehq.org/wine/wine/-/merge_requests/5791

3 7

[PATCH 0/1] MR5789: server: Remove limitation for waiting on idle_event of the current process.
by Dmitry Timoshkov (＠dmitry) 05 Jun '24

05 Jun '24

[test_WaitForInputIdle.tar.bz2](/uploads/a20c5b119741cd7b0b4813488854a992/test_WaitForInputIdle.tar.bz2) Attached test replicates the problem. Basically the application does process = OpenProcess(SYNCHRONIZE | PROCESS_QUERY_INFORMATION, FALSE, GetCurrentProcessId()); ret = WaitForInputIdle(process, 0x7fffffff); assert(ret == 0); With current wine.git WaitForInputIdle() returns WAIT_FAILED because the server call get_process_idle_event() refuses to return idle_event for the current process. If that limitation is removed then wineserver crashes, and other parts of the patch fix the crash. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5789

3 8