June 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/6] MR5717: Improve dmo_wrapper_sink_Receive.
by Ziqing Hui (＠zhui) 05 Jun '24

05 Jun '24

This reduce the chance of buffer allocating issue for Kirikiri2 games(eg. Super Naughty Maid) when the game is trying to play videos. -- v2: qasf/dmowrapper: Sync Stop() and Receive() for dmo wrapper filter. qasf/dmowrapper: Return VFW_E_WRONG_STATE in dmo_wrapper_sink_Receive. qasf/dmowrapper: Return failure in dmo_wrapper_sink_Receive if samples allocating fails. qasf/dmowrapper: Introduce release_output_samples. qasf/dmowrapper: Introduce get_output_samples. qasf/tests: Add more tests for dmo_wrapper_sink_Receive. https://gitlab.winehq.org/wine/wine/-/merge_requests/5717

4 9

[PATCH v2 0/7] MR5732: winegstreamer: Get rid of the wg_transform internal output_format.
by Rémi Bernon 05 Jun '24

05 Jun '24

-- v2: winegstreamer: Request the new transform output format explicitly. winegstreamer: Get rid of the wg_transform internal output_format. winegstreamer: Only report format changes when frontend supports it. winegstreamer: Rename allow_size_change to allow_format_change. winegstreamer: Enforce default stride presence in the video processor. winegstreamer: Enforce default stride value in the video decoder. winegstreamer: Allow to clear video decoder input/output types. https://gitlab.winehq.org/wine/wine/-/merge_requests/5732

3 9

[PATCH 0/3] MR5793: server: Inherit the source token's label in token_duplicate().
by Elizabeth Figura (＠zfigura) 05 Jun '24

05 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5793

2 3

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

I just showed an example of how this code will fail in the issue without any hacking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72404

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Tue Jun 4 22:57:24 2024 +0000, cqwrteur wrote: > It was always different in layout. This is a bug for years. UCRT does > not have the same layout of FILE compared to msvcrt. However wine just > assumes they are the same, which is wrong. MSVC allows you to pass FILE* > from a statically linked ucrt to a dynamic linked ucrt provided by the > operating system and that is of course causing abi break. https://github.com/cppfastio/fast_io/blob/next/include/fast_io_legacy_impl/… I have changed my code to make it clearer. msvcrt and ucrt always use different layouts. This should be clearer for you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72402

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Fri May 31 21:05:42 2024 +0000, cqwrteur wrote: > Done :) hi. Can you merge the code? @alexhenrie I desperately need this. Please do not break my library. Thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72401

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

@piotr Any more issues? If no, then merge it ty. I desperately need this working -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72399

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

@piotr @alexhenrie, it is time to merge the code. Ty. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72400

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Sun Jun 2 22:51:59 2024 +0000, cqwrteur wrote: > changed this line in [version 21 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116242&start_sha=0ed3968e5c80f1068a89193deb4b3309a69d8e27#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3171_3164) It is not. The problem is that ucrt can be statically linked from Microsoft UCRT static ucrt can be put back to FILE* in dynamic linking. And fast_io library is exploiting that to gain huge performance. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72395

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Sun Jun 2 22:59:20 2024 +0000, cqwrteur wrote: > changed this line in [version 22 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116244&start_sha=f9ce09a15be1de01f4b8f3f2c25cf9c722a4b2d8#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3144_3149) It was always different in layout. This is a bug for years. UCRT does not have the same layout of FILE compared to msvcrt. However wine just assumes they are the same, which is wrong. MSVC allows you to pass FILE* from a statically linked ucrt to a dynamic linked ucrt provided by the operating system and that is of course causing abi break. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72396

1 0