July 2024 - Wine-gitlab - list.winehq.org

[PATCH v3 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v3: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 5

[PATCH 0/1] MR6168: gdiplus: fixed second order adding offset and result ternary operator
by Herman Semenov (＠GermanAizek) 29 Jul '24

29 Jul '24

I'm sorry that I didn't notice this problem earlier and didn't squash commits. I found exactly same misprint in same file as in this PR: https://gitlab.winehq.org/wine/wine/-/merge_requests/6161 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6168

4 3

[PATCH v2 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v2: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

3 3

[PATCH v2 0/1] MR6146: comctl32: Create all prop sheet pages on initialization.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

Fixes bug 54861. The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. -- v2: comctl32: Create all prop sheet pages on initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

2 2

[PATCH v5 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) 29 Jul '24

29 Jul '24

-- v5: shell32: Fix FO_MOVE when destination has conflicting directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

2 2

[PATCH 0/1] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

The listview wine bug 56140 is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 4

[PATCH 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by eric pouech (＠epo) 29 Jul '24

29 Jul '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170

2 1

[PATCH v9 0/3] MR5104: include: Add missing Task Scheduler Trigger definitions
by Vijay Kiran Kamuju (＠infyquest) 29 Jul '24

29 Jul '24

This is a prerequisite for stub implementation of ILogonTrigger interface, which is needed for https://bugs.winehq.org/show_bug.cgi?id=47152 -- v9: include: Added IEventTrigger declaration. include: Add ISessionStateChangeTrigger declaration. include: Add more Task Scheduler Trigger interface definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/5104

3 4

[PATCH 0/1] MR6169: comctl32: fixed first we check index then array access by index is safe
by Herman Semenov (＠GermanAizek) 29 Jul '24

29 Jul '24

I think this PR changes will protect against situation if out-of-bounds access array. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6169

3 2

[PATCH v5 0/2] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) 29 Jul '24

29 Jul '24

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v5: shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

5 20