July 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/4] MR6166: Draft: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 28 Jul '24

28 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v2: remove unused vars https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

4 5

[PATCH v6 0/1] MR5957: win32u: fix random crash without libfreetype
by Fan WenJie (＠fanwenjie) 28 Jul '24

28 Jul '24

without freetype, some calling return failed, so some value may not be initialized (it initialize by some failed calling and pass argument by point of it), it would cause random crash! Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v6: win32u: fix random crash without libfreetype https://gitlab.winehq.org/wine/wine/-/merge_requests/5957

2 2

[PATCH v9 0/9] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v9: userenv: Fix GetProfilesDirectoryA return value kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. kernel32: Rework ExpandEnvironmentStringsW error handling. ntdll: Rework RtlExpandEnvironmentStrings/_U to account for corner cases. kernel32: Add ExpandEnvironmentStringsA tests for japanese. kernel32: Add more tests for ExpandEnvironmentStringsA. kernel32: Add tests for ExpandEnvironmentStringsW. ntdll: Add more tests for RtlExpandEnvironmentStrings/_U. userenv: Add another test for GetProfilesDirectoryA https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

2 9

[PATCH 0/3] MR6166: Draft: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 27 Jul '24

27 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

4 4

[PATCH 0/3] MR6165: widl: Propagate attrs to inner pointer types.
by Elizabeth Figura (＠zfigura) 27 Jul '24

27 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6165

3 4

[PATCH v7 0/7] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v7: kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. kernel32: Rework ExpandEnvironmentStringsW error handling. ntdll: Rework RtlExpandEnvironmentStrings/_U to account for corner cases. kernel32: Add ExpandEnvironmentStringsA tests for japanese. kernel32: Add more tests for ExpandEnvironmentStringsA. kernel32: Add tests for ExpandEnvironmentStringsW. ntdll: Add more tests for RtlExpandEnvironmentStrings/_U. https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 8

[PATCH v6 0/7] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v6: kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 9

Re: [PATCH v3 0/1] MR5957: win32u: fix random crash without libfreetype
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

Fabian Maurer (@DarkShadow44) commented about dlls/win32u/sysparams.c: > 'r','s','t','u','v','w','x','y','z','A','B','C','D','E','F','G','H', > 'I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'}; > > - if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) return 0; > + if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) goto fail; > > if (!NtGdiGetTextExtentExW( hdc, abcdW, ARRAYSIZE(abcdW), 0, NULL, NULL, &sz, 0 )) > - return 0; > + goto fail; > > if (height) *height = sz.cy; > return (sz.cx / 26 + 1) / 2; > +fail: > + if (height) *height = 1; > + return 0; Just curious, but why `1`? Also, wouldn't it be easier to have `if (height) *height = 1;` at the beginning of the function? Then you could keep the rest the same. And maybe that function could zero the `metrics` as well? Not sure where it would be required, I find a setup without freetype strange to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5957#note_77190

1 0

[PATCH v3 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) 27 Jul '24

27 Jul '24

-- v3: shell32: Fix FO_MOVE when destination has conflicting directory. shell32/tests: Add tests for moving dir(s) to destination(s) with conflicting dir. https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

3 3

[PATCH v4 0/1] MR5586: configure: Test PE compilers after setting their target argument.
by Billy Laws (＠bylaws) 27 Jul '24

27 Jul '24

clang will default to the host if no target is specified, which causes compile test failures if arch-specific CFLAGS are used for a non-host arch. -- v4: configure: Test PE compilers after setting their target argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/5586

3 4