July 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

On Fri Jul 26 10:09:51 2024 +0000, Rémi Bernon wrote: > Fwiw, on Windows, all desktops are of the same size, which only depends > on the set of monitors which are plugged in. > IMO we should implement support for multiple virtual monitors, rather > than going back to the old virtual desktop logic. desktop is not equals to monitor, currently wine supports multiply desktops (mutiply host window) on a virtual monitor. only need one virtual monitor because it is only a virtual device. In virtual desktop mode desktop = host platform window virtual monitor=dummy host monitor device -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77129

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Rémi Bernon 26 Jul '24

26 Jul '24

Fwiw, on Windows, all desktops are of the same size, which only depends on the set of monitors which are plugged in. IMO we should implement support for multiple virtual monitors, rather than going back to the old virtual desktop logic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77123

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) 26 Jul '24

26 Jul '24

You can add Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56993 at the end of your commit message body. Also, the wrong commit is b86cc9e6, not fecfb442 ``` (b86cc9e6589...)|BISECTING:wine/win32-build$ git bisect bad b86cc9e658959cee47e6e587fec4f7c26350ed76 is the first bad commit commit b86cc9e658959cee47e6e587fec4f7c26350ed76 Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Feb 13 15:05:37 2024 +0100 winex11: Let win32u decide when to force update the display cache. dlls/winex11.drv/window.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77120

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) 26 Jul '24

26 Jul '24

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > struct monitor *monitor; You can add Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56993 at the end of your commit message body. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77118

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) 26 Jul '24

26 Jul '24

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > struct monitor *monitor; > struct gpu *gpu; > > - if (list_head( &monitors ) == &virtual_monitor.entry) Please don't add irrelevant changes in the same commit. If you want to fix explorer.exe not starting up with a user-specified resolution, focus on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77119

1 0

[PATCH v4 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 26 Jul '24

26 Jul '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. -- v4: comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 14

[PATCH 0/1] MR6162: ddraw: SecureZeroMemory did not reset to zero entire size obj, only size ptr
by Herman Semenov (＠GermanAizek) 26 Jul '24

26 Jul '24

Maybe it's just typo who added this function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6162

4 6

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 25 Jul '24

25 Jul '24

On Thu Jul 25 23:39:50 2024 +0000, Fabian Maurer wrote: > Why do you remove all that virtual source logic? I mean, I'm not an > export, but it looks off. virtual_source should remove，2 reason in function is_monitor_active ` static BOOL is_monitor_active( struct monitor *monitor ) { struct source *source; /* services do not have any adapters, only a virtual monitor */ if (!(source = monitor->source)) return TRUE; if (!(source->state_flags & DISPLAY_DEVICE_ATTACHED_TO_DESKTOP)) return FALSE; return !IsRectEmpty( &monitor->rc_monitor ); } ` virual_monitor do not need source. virtual monitor is a temporary setting，should not write registry， It is a feature only for wine, so have no effect for global setting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77094

1 0

[PATCH 0/3] MR6159: Taking strlen outside loop if possible
by Herman Semenov (＠GermanAizek) 25 Jul '24

25 Jul '24

Example with gcc and -O3 maximum optimization flag. Before: ![screen_before](/uploads/d02727ad61da60e320d25e86bd0457ff/screen_before.jpg) After: ![screen_after](/uploads/bae74909dd904232b2dc8cced7028036/screen_after.jpg) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6159

4 7

Re: [PATCH v15 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command. - approved
by Alexandre Julliard (＠julliard) 25 Jul '24

25 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

1 0