July 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/1] MR6102: odbc32: Handle NULL attribute in SQLColAttributeW. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6102

1 0

Re: [PATCH v2 0/1] MR6055: ddraw/tests: Make sure the window is restored after some minimize tests. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6055

1 0

Re: [PATCH v2 0/2] MR6098: odbc32 fixes transact - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6098

1 0

Re: [PATCH v2 0/1] MR6104: light.msstyles: Use slightly darker color for GrayText to make text more readable. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6104

1 0

[PATCH 0/1] MR6109: win32u: Implement EVENT_OBJECT_STATECHANGE for WS_DISABLED.
by Esme Povirk (＠madewokherd) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6109

3 2

[PATCH v3 0/4] MR6089: setupapi: Fixes for get_source_info().
by Elizabeth Figura (＠zfigura) 17 Jul '24

17 Jul '24

-- v3: setupapi: Fix testing for a non-empty string in get_source_info(). setupapi/tests: Test installing an INF file with architecture-specific SourceDisks* sections. setupapi: Use SetupGetSourceInfo() in get_source_info(). setupapi: Use SetupGetSourceFileLocation() in get_source_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6089

2 4

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by theofficialgman (＠theofficialgman) 17 Jul '24

17 Jul '24

On Wed Jul 17 17:12:01 2024 +0000, Tim Clem wrote: > Filing a bug is probably the right thing to do. I don't know offhand who > would know best - I'm not very familiar with that area myself. In > ntdll/unix/virtual.c, the address space limit is hardcoded to > 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it > (see `get_host_addr_space_limit`). For the bug, it would be interesting > to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned. The issue I am having is when fully emulating x86_64 wine on arm64 using the likes of box64/fex/qemu. So the hardcode makes sense why the problem is happening. Thanks for the info, I'll look into using `get_host_addr_space_limit` for all architectures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76437

1 0

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by Tim Clem (＠tclem) 17 Jul '24

17 Jul '24

On Wed Jul 17 17:12:01 2024 +0000, theofficialgman wrote: > Thanks Tim. Should I file a bug for this then or are you aware of who > might be more knowledgeable about the allocation system and why its > attempting to allocate memory outside of address limit? Filing a bug is probably the right thing to do. I don't know offhand who would know best - I'm not very familiar with that area myself. In ntdll/unix/virtual.c, the address space limit is hardcoded to 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it (see `get_host_addr_space_limit`). For the bug, it would be interesting to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76436

1 0

[PATCH v2 0/1] MR6097: dxdiagn: Fill szHardwareId for sound render devices.
by Paul Gofman (＠gofman) 17 Jul '24

17 Jul '24

Somehow the field is not present for sound capture devices, at least on my Win11. Fixes Tom Clancy's Splinter Cell: Conviction not finding any sound devices and refusing to start. -- v2: dxdiagn: Fill szHardwareId for sound render devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/6097

2 2

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by theofficialgman (＠theofficialgman) 17 Jul '24

17 Jul '24

Thanks Tim. Should I file a bug for this then or are you aware of who might be more knowledgeable about the allocation system and why its attempting to allocate memory outside of address limit? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76427

1 0