July 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Hans Leidekker (＠hans) 09 Jul '24

09 Jul '24

Can you add a test case for this in dlls/secur32/tests/secur32.c? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75555

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 09 Jul '24

09 Jul '24

> It seems that the Windows machine needs to be joined to a Windows domain for this call to return something sensible. That's... weird, because it doesn't seem to be the case with my Windows installations, nor do Microsoft's docs specify this. (See [https://learn.microsoft.com/en-us/windows/win32/api/secext/nf-secext-getuse…) > Do you have an application that depends [on] this? Yes, I do. It's a game modification called "[OneShot: Fading Memory](https://store.steampowered.com/app/1569440/OneShot_Fading_Memory/)", which I am one of the developers of. It has been released two years ago and has always relied on the GetUserNameEx method. We've received no bug reports related to the game querying the player's name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75551

1 0

[PATCH 0/8] MR6028: Cmd engine rewrite (part XVIII)
by eric pouech (＠epo) 09 Jul '24

09 Jul '24

This is part XVIII of cmd engine rewrite. It mainly focuses on setting the expected return code for some builtin functions. Includes also a fix for pipe inside a redirection (spotted by the added tests). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6028

2 8

[PATCH v2 0/2] MR6014: winhttp/tests: Add some tests for querying string options with NULL buffer.
by Nikolay Sivov (＠nsivov) 09 Jul '24

09 Jul '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: winhttp: Fix error handling when returning string options. winhttp/tests: Add some tests for querying string options with NULL buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/6014

4 4

[PATCH v35 0/9] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 09 Jul '24

09 Jul '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v35: advapi32: Fake the SeLockMemoryPrivilege right in LsaEnumerateAccountRights. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 10

[PATCH 0/2] MR5987: ddraw/tests: Workaround some X11 ConfigureNotify event race condition.
by Rémi Bernon 09 Jul '24

09 Jul '24

Somehow more likely to be triggered with https://gitlab.winehq.org/wine/wine/-/merge_requests/5970. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5987

3 4

[PATCH 0/2] MR6026: winemac: Use the new surface shape helper to update window shape.
by Rémi Bernon 09 Jul '24

09 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6026

1 2

[PATCH v9 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v9: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

[PATCH v8 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v8: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Hans Leidekker (＠hans) 09 Jul '24

09 Jul '24

In my tests GetUserNameEx(NameDisplay) returns ERROR_NONE_MAPPED on Windows. It seems that the Windows machine needs to be joined to a Windows domain for this call to return something sensible. Do you have an application that depends this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75538

1 0