July 2024 - Wine-gitlab - list.winehq.org

[PATCH v9 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v9: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

[PATCH v8 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v8: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Hans Leidekker (＠hans) 09 Jul '24

09 Jul '24

In my tests GetUserNameEx(NameDisplay) returns ERROR_NONE_MAPPED on Windows. It seems that the Windows machine needs to be joined to a Windows domain for this call to return something sensible. Do you have an application that depends this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75538

1 0

[PATCH 0/1] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) 09 Jul '24

09 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

4 4

[PATCH v10 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v10: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

2 2

[PATCH 0/1] MR6024: ntoskrnl.exe: add a stub for KeQueryGroupAffinity
by Austin English (＠austin987) 09 Jul '24

09 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56948 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6024

2 1

[PATCH v7 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v7: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

[PATCH v6 0/2] MR5969: Draft: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v6: kernelbase: Ensure null termination in RegGetValue[AW]. windowscodecs: Use RegQueryValueExW in ComponentInfo_GetStringValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

2 2

[PATCH 0/6] MR5999: d3dx9: Miscellaneous fixes.
by Connor McAdams (＠cmcadams) 09 Jul '24

09 Jul '24

This MR contains patches with a few small fixes for things that have been found while working on the usual shared code patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5999

3 11

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Jul '24

08 Jul '24

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/mmdevapi/tests/render.c: > + NULL, (void**)&ac); > + ok(hr == S_OK, "Activation failed with %08lx\n", hr); > + if(hr != S_OK) > + return; > + > + hr = IAudioClient_GetMixFormat(ac, &pwfx); > + ok(hr == S_OK, "GetMixFormat failed: %08lx\n", hr); > + > + hr = IAudioClient_Initialize(ac, AUDCLNT_SHAREMODE_SHARED, 0, 5000000, > + 0, pwfx, NULL); > + ok(hr == S_OK, "Initialize failed: %08lx\n", hr); > + > + CoTaskMemFree(pwfx); > + > + /* contrary to what MSDN says this interface should be obtained via QueryInterface() */ > + hr = IAudioClient_GetService(ac, &IID_IAudioClockAdjustment, (void**)&aca); cracked the mystery, im pretty sure AUDCLNT_STREAMFLAGS_RATEADJUST is needed for GetService to work :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75515

1 0