August 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/1] MR6198: gdi32: Bounds check EMF handle tables. - approved
by Alexandre Julliard (＠julliard) 10 Aug '24

10 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6198

1 0

[PATCH v2 0/1] MR6119: printdlg: Allow button id psh1 for "Properties" button.
by Fabian Maurer (＠DarkShadow44) 10 Aug '24

10 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55841 -- v2: printdlg: Allow button id psh1 for "Properties" button. https://gitlab.winehq.org/wine/wine/-/merge_requests/6119

3 3

[PATCH 0/3] MR6046: More Robust Child Font List Creation
by Danyil Blyschak (＠blyss) 10 Aug '24

10 Aug '24

In win32u/font.c's `create_child_font_list` function: - We remove the `ansi_cp` `MaximumCharacterSize` check since this is the current locale's codepage, not the font's codepage. This was preventing certain child fonts from being loaded when they should have been. - We include Microsoft Sans Serif as a child font, whereas previously we were only including its linked fonts as child font. - As a backup, we also add Tahoma (which should ship with Wine) and its linked fonts as child fonts in case Microsoft Sans Serif is not available. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6046

4 5

[PATCH v2 0/1] MR6198: gdi32: Bounds check EMF handle tables.
by Esme Povirk (＠madewokherd) 10 Aug '24

10 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45106 -- v2: gdi32: Bounds check EMF handle tables. https://gitlab.winehq.org/wine/wine/-/merge_requests/6198

4 4

Re: [PATCH v12 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Zhiyi Zhang (＠zhiyi) 10 Aug '24

10 Aug '24

On Fri Aug 9 21:57:26 2024 +0000, Ilia Docin wrote: > Sorry for the late response. But how does it pass without fix if the > feature branch has that fix and the pipeline runs on the feature branch? > Besides, I checked locally that without fix the test failed with: > listview.c:7262: Test failed: Expected -1, got 3 You should add the tests and mark the tests that are failing on wine with todo_wine. Then in the next patch that fixes the bug, remove those todo_wines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78275

1 0

[PATCH v4 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Tom Helander (＠thelande) 10 Aug '24

10 Aug '24

This merge request implements the `httpapi.dll` `HttpResponseSendEntityBody` function and associated tests. API documentation was written by me by paraphrasing/re-writing what I had read for the function from the MSDN documentation. I am adding this function to enable the remote API component of the Space Engineers Dedicated Server. Implementation notes: - I mainly copied the relevant portion of `HttpSendHttpResponse` for `HttpResponseSendEntityBody`. - I updated the `http_response` struct to add a field `response_flags` - This field tracks the flags passed in to `HttpSendHttpResponse` and `HttpResponseSendEntityBody`. - This was needed because the clean-up steps in `http.sys` need to be skipped when `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` is set. - I updated `HttpSendHttpResponse` to handle the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag by omitting the `Content-Length` header and setting the `response_flags` field in the `response` object passed to `http.sys`. - The `Content-Length` header is omitted by the Windows implementation and thus I omitted it here for conformance purposes. - I updated `http_send_response` in `http.sys` to skip the connection clean up steps if the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag was set. This works for both `HttpSendHttpResponse` and `HttpResponseSendEntityBody` as either could set the flag to continue to send more data. - It is not 100% clear to me what the cleanup steps are doing. In particular, I am uncertain what lines 1011-1016 and 1023-1027 are doing, but based on context it seemed appropriate to keep them with the other connection cleanup steps. For testing, I duplicated the existing `HttpSendHttpResponse` test but modified it to set the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag and then followed up with a call to `HttpResponseSendEntityBody` with new data. The validation ensures that data from both the initial response and follow up response are contained in the final response obtained via `recv()`. On Windows 11 this happens immediately without any delay, but in Wine I had to add a `Sleep(100)` to give enough time for the follow up response to be received in the socket buffer by the time the `recv()` call was made in the test. I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). -- v4: httpapi: Implement HttpSendResponseEntityBody httpapi: Handle HTTP_SEND_RESPONSE_FLAG_MORE_DATA flag http.sys: Skip clean up if HTTP_SEND_RESPONSE_FLAG_MORE_DATA is set httpapi: Add tests for HttpResponseSendEntityBody https://gitlab.winehq.org/wine/wine/-/merge_requests/6216

3 8

Re: [PATCH v2 0/1] MR6245: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETCHECK. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6245

1 0

Re: [PATCH v2 0/1] MR6229: winegstreamer/quartz_parser: Handle 0 size in read_thread. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6229

1 0

Re: [PATCH v15 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

1 0

Re: [PATCH v2 0/2] MR6240: dinput: Implement DIPROP_SCANCODE. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6240

1 0