August 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR6245: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETCHECK.
by Esme Povirk (＠madewokherd) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6245

2 1

[PATCH 0/1] MR6229: winegstreamer/quartz_parser: Handle 0 size in read_thread.
by Ziqing Hui (＠zhui) 09 Aug '24

09 Aug '24

Calling IAsyncReader_SyncRead() with 0 size may fails, but we should not return error with 0 size, so we handle it earlier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6229

3 2

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Thanks for the patch! Other than a couple of style nitpicks it looks good. > I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). I think it'd still be preferable, though. 100 ms isn't a lot, but those kinds of sleeps can build up, and we do want our tests to be as quick as possible. Perhaps more concerningly, if the timing is particularly bad, and 100 ms isn't enough, we'll get intermittent failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78212

1 0

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Elizabeth Figura (@zfigura) commented about dlls/http.sys/http.c: > { > if (send(conn->socket, response->buffer, response->len, 0) >= 0) > { > - if (conn->content_len) > - { > - /* Discard whatever entity body is left. */ > - memmove(conn->buffer, conn->buffer + conn->content_len, conn->len - conn->content_len); > - conn->len -= conn->content_len; > + /* Clean up the connection if we are not sending more response data. */ > + if (response->response_flags != HTTP_SEND_RESPONSE_FLAG_MORE_DATA) { Brace on a new line, please, to match the existing style. There's another instance in 4/4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78211

1 0

[PATCH v5 0/1] MR6191: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux
by Haoran Wang (＠Low-power) 09 Aug '24

09 Aug '24

Tested using C&C Red Alert 2; selection of interface and network communication worked as expected. IPX traffic correctly sent to the selected interface only, as confirmed by **tcpdump(8)**. ![ra2-on-linux-with-multiple-ipx-interfaces](/uploads/7755db6a7b82a21050623d3ccd9ec37e/ra2-on-linux-with-multiple-ipx-interfaces.png) -- v5: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/6191

3 4

[PATCH 0/1] MR6242: include: Move arm64ec_shared_info to winternl and point to it in the PEB.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

>From phnt headers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6242

3 2

[PATCH 0/1] MR6241: ntdll: Initialize dll search paths before WOW64 init.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

GetModuleHandle succeeds when called from WOW64 module callbacks on Windows but without this it would crash on wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6241

2 1

[PATCH v14 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v14: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 4

[PATCH 0/2] MR6240: dinput: Implement DIPROP_SCANCODE.
by Rémi Bernon 09 Aug '24

09 Aug '24

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6223. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6240

3 4

[PATCH v13 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v13: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

3 3