September 2024 - Wine-gitlab

[PATCH v3 0/13] MR6207: include: Introduce new COM implementation helper macros.
by Rémi Bernon 18 Nov '24

18 Nov '24

I think it would be very nice to have something like that to reduce the burden of implementing COM interfaces. This shows for instance on the windows.gaming.input module a 30% LoC reduction (from ~6800 to ~4700), even though the module already had a boilerplate helper macros already. The MR introduces macros to automatically implement each IUnknown method, as well as all of them at once. It also includes a helper to implement IInspectable methods at once, as well as macros to forward both interface methods to a base interface or an outer object. Last, it provides higher-level macros to implement a main interface and any number of sub interfaces and generate IUnknown, forwarding and vtables for all of them at once, with IInspectable support when needed. It uses widl to generate additional per-interface macros, for things like inheritance and vtable generation. The rest of the macros are otherwise shared in a Wine-specific header. The implementation is split to show individual macro being used, although they are later replaced by higher-level macros. The individual helpers are still useful in some corner cases where specific behavior needs to be implemented, or for aggregating classes. -- v3: include: Add a parameter to COM helper END to control QI traces. windows.gaming.input: Use the new COM macros everywhere possible. include: Introduce new macros for COM heritage implementation. widl: Generate some INTERFACE_IMPL/FWD helper macros. include: Introduce new macros for IInspectable WinRT implementation. include: Introduce new macros for COM IUnknown implementation. include: Introduce new macros for COM QueryInterface implementation. widl: Generate some QUERY_INTERFACE helper macros. include: Introduce new macros for COM AddRef/Release implementation. include: Introduce new helper macros for COM implementation. windows.gaming.input: Use the new INTERFACE_VTBL macros. widl: Generate some INTERFACE_VTBL helper macros. windows.gaming.input: Use a separate interface for IAgileObject. https://gitlab.winehq.org/wine/wine/-/merge_requests/6207

4 22

[PATCH v12 0/1] MR1989: wininet: Allow UTC as a timezone.
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Nov '24

17 Nov '24

this should fix ubisoft connect outputting unknown timezone UTC in logs -- v12: wininet: Allow UTC as a timezone. https://gitlab.winehq.org/wine/wine/-/merge_requests/1989

2 2

[PATCH 0/5] MR6200: org.freedesktop.Notifications implementation for balloons
by Cherser-s (＠Cherser-s) 16 Nov '24

16 Nov '24

Adds the notification balloons implementation based on org.freedesktop.Notifications interface usage, if it's available. This is a split version of https://gitlab.winehq.org/wine/wine/-/merge_requests/2808 , because currently there is no documented way to maintain a single connection for a whole system tray with multiple StatusNotifierItems. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6200

4 7

[PATCH 0/4] MR6289: dsound: Reject NaN values in some functions.
by Aida Jonikienė 16 Nov '24

16 Nov '24

The tests aren't really tested though (they partially require interactive mode and they caused lag issues on one person's machine). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6289

2 7

[PATCH v2 0/2] MR4794: comctl32/combo: Add tests for keypresses showing search functionality
by Fabian Maurer (＠DarkShadow44) 16 Nov '24

16 Nov '24

In preparation to fix https://bugs.winehq.org/show_bug.cgi?id=56104 and https://bugs.winehq.org/show_bug.cgi?id=42898 -- v2: comctl32/listbox: Add tests for keypresses showing search functionality comctl32/combo: Add tests for keypresses showing search functionality https://gitlab.winehq.org/wine/wine/-/merge_requests/4794

3 11

[PATCH 0/1] MR5232: rundll32: Allow DLL name and entrypoint to be separated by any combination of spaces/commas.
by Aida Jonikienė 15 Nov '24

15 Nov '24

This is one of the two rundll32 changes required for GeForce NOW installer to work (the other one is too hacky to upstream without major changes) This commit was originally found on https://github.com/aabgrall/wine-base-geforcenow (but the author never bothered to send it to the ML/GitLab) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5232

3 4

[PATCH v2 0/2] MR6301: Introduce a new WINE_VIDEO_DRIVER variable.
by Aida Jonikienė 13 Nov '24

13 Nov '24

This variable is the Wine's equivalent of the SDL_VIDEODRIVER/ SDL_VIDEO_DRIVER variable in SDL 2 and 3 (it explicitly selects a list of graphics/video drivers to be used). -- v2: man: Add documentation for the WINE_VIDEO_DRIVER variable. explorer: Introduce a new WINE_VIDEO_DRIVER variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/6301

4 12

[PATCH v2 0/1] MR5582: explorer: Finish wide-string literal migration.
by Aida Jonikienė 13 Nov '24

13 Nov '24

-- v2: explorer: Finish wide-string literal migration. https://gitlab.winehq.org/wine/wine/-/merge_requests/5582

3 4

[PATCH v4 0/1] MR5236: ntdll: Implement NtdllDefWindowProc_A().
by Aida Jonikienė 13 Nov '24

13 Nov '24

I've tried implementing this before but importing user32 from ntdll isn't a reliable thing (so I recently rewrote it using the ntdll equivalents of LoadLibrary() and GetProcAddress()) Note: This is a weird way to implement this function (Windows implements this in ntdll instead) but that would probably require a user32/ntdll rewrite (so this is the next best tning to get the application working) -- v4: ntdll: Implement NtdllDefWindowProc_A(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5236

5 11

[PATCH v2 0/1] MR5449: Draft: regsvr32: Implement EXE registration.
by Aida Jonikienė 13 Nov '24

13 Nov '24

The Sims 2 installer calls regsvr32 with the /regserver flag (which isn't implemented on Wine) so that command fails. -- v2: regsvr32: Implement EXE registration. https://gitlab.winehq.org/wine/wine/-/merge_requests/5449

2 4