September 2024 - Wine-gitlab

[PATCH v10 0/9] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 29 Oct '24

29 Oct '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v10: userenv: Fix GetProfilesDirectoryA return value kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. kernel32: Rework ExpandEnvironmentStringsW error handling. ntdll: Rework RtlExpandEnvironmentStrings/_U to account for corner cases. kernel32: Add ExpandEnvironmentStringsA tests for japanese. kernel32: Add more tests for ExpandEnvironmentStringsA. kernel32: Add tests for ExpandEnvironmentStringsW. ntdll: Add more tests for RtlExpandEnvironmentStrings/_U. userenv: Add another test for GetProfilesDirectoryA https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 12

[PATCH 0/5] MR4614: msvcm80: Add missing function implementations
by Vijay Kiran Kamuju (＠infyquest) 26 Oct '24

26 Oct '24

This series adds _Cin, _Cout, _Cerr, _Clog, _Wcin, _Wcout, _Wcerr, _Wclog functions. Rest of the functions will be added later. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47304 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=32091 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4614

4 10

[PATCH v4 0/2] MR6158: Replaced on simpler functions with char, wchar_t parameter if possible
by Herman Semenov (＠GermanAizek) 21 Oct '24

21 Oct '24

Example my assembly with gcc -02 flag Before: ![screen_before](/uploads/f2bf5f4c793c159c31ac42b635c46d5a/screen_before.jpg) After: ![screen_after](/uploads/051315ad1e3c064046446782d36e1a29/screen_after.jpg) -- v4: d3dcompiler: replaced to char, wchar_t parameter if possible wcmdmain: replaced to char, wchar_t parameter if possible https://gitlab.winehq.org/wine/wine/-/merge_requests/6158

4 10

[PATCH v2 0/1] MR6169: comctl32: fixed first we check index then array access by index is safe
by Herman Semenov (＠GermanAizek) 21 Oct '24

21 Oct '24

I think this PR changes will protect against situation if out-of-bounds access array. -- v2: comctl32: fixed first we check index then array access by index is safe https://gitlab.winehq.org/wine/wine/-/merge_requests/6169

6 8

[PATCH 0/1] MR6513: opengl32: Add WGL_DOUBLE_BUFFER_ARB to the explicit sort list.
by Aida Jonikienė 17 Oct '24

17 Oct '24

The Legend of Pirates Online expects the formats without WGL_DOUBLE_BUFFER_ARB to be listed first in wglChoosePixelFormatARB() (otherwise it goes into a special wglBindTexImageARB() path which causes blank rendering on both winex11 and winewayland) which was the old winex11 behavior that this change now matches. Fixes: 272c55ac257 ("opengl32: Add default implementation for wglChoosePixelFormatARB.") -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6513

2 4

[PATCH 0/1] MR6238: comdlg32: Add `const' qualifier
by Ruslan Garipov (＠ruslangaripov) 16 Oct '24

16 Oct '24

No functional changes intended. Please, review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6238

4 5

[PATCH 0/1] MR5276: musl: Fix limiting the float precision in intermediates.
by Martin Storsjö 15 Oct '24

15 Oct '24

musl itself expects to be configured to compile with either -ffloat-store or -fexcess-precision=standard - but when imported into Wine, those flags aren't used. This seems to be essential for getting reasonable precision from some math functions such as exp2() - without the expected precision truncation, the output value of exp2() can be off by as much as 0.2% in some cases. As Wine doesn't build the musl sources with those flags, use volatile to force storing/reloading floats in order to limit their intermediate precision, as musl expects. Only do this on i386 where this is known be required. This fixes https://bugs.winehq.org/show_bug.cgi?id=56372. Apparently this issue only appears when compiled with GCC; with Clang, this already works as expected. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5276

3 6

[PATCH v4 0/4] MR6526: propsys: Initially implement PropVariantToVariant.
by Ziqing Hui (＠zhui) 09 Oct '24

09 Oct '24

-- v4: propsys: Initially implement PropVariantToVariant. propsys: Support converting clsid to string for PropVariant. propsys/tests: Test converting clsid to string. propsys/tests: Add tests for PropVariantToVariant. https://gitlab.winehq.org/wine/wine/-/merge_requests/6526

4 8

[PATCH v2 0/4] MR6564: d3d: Do not apply the stateblock when clearing.
by Elizabeth Figura (＠zfigura) 08 Oct '24

08 Oct '24

-- v2: d3d9: Do not apply the stateblock when clearing. d3d8: Do not apply the stateblock when clearing. ddraw: Do not apply the entire stateblock when clearing. wined3d: Move rasterizer state invalidation to wined3d_stateblock_set_render_state(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6564

4 6

[PATCH 0/8] MR6568: d3dx9: Pixel format handling changes, part 2.
by Connor McAdams (＠cmcadams) 07 Oct '24

07 Oct '24

These patches are the last big changes to the pixel_format_desc structure. Patch 2 of this feels like it might be a bit big, but I couldn't really come up with a clean way to split it. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6568

4 17