September 2024 - Wine-gitlab

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Nikolay Sivov (＠nsivov) 28 Sep '24

28 Sep '24

On Sat Sep 21 20:51:46 2024 +0000, Philipp Knechtges wrote: > TBH, I do not really know what to make of this assessment. Looking at > the d2d1 tests it feels like, correctness is at best achieved > approximately, and then the question arises what is the metric in which > "correctness" is assessed? Unarguably, the tests as a metric are a > moving target, depending on when which tests are added, thus making it a > subjective choice at times. > In my book, the patch at hand makes the rendering more correct in many > cases. To be precise in all cases in which the individual geometries in > the geometry group do not intersect, and thus the fill mode does not > matter. Would you consider the patch sufficient, if it would > (approximately) check for intersections and only copy if there are none, > and falling back to old behavior (rendering just nothing) in case there > are any (potentially false-positive) intersections? It wouldn't consider it sufficient, it's clear that there is more to it than copying data from individual geometries. So the question is the same - what needs to be done to make it work properly, once it's understood, we could implement it partially if it's too hard to do properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_83622

1 0

[PATCH v3 0/4] MR6526: propsys: Initially implement PropVariantToVariant.
by Ziqing Hui (＠zhui) 28 Sep '24

28 Sep '24

-- v3: propsys: Initially implement PropVariantToVariant. propsys: Support converting clsid to string for PropVariant. propsys/tests: Test converting clsid to string. propsys/tests: Add tests for PropVariantToVariant. https://gitlab.winehq.org/wine/wine/-/merge_requests/6526

3 6

[PATCH v4 0/1] MR6572: mscoree: Register mono log handler callback.
by Bernhard Kölbl 28 Sep '24

28 Sep '24

This makes Wine output Mono logging messages like `MONO_GC_DEBUG=log-finalizers` etc. -- v4: mscoree: Register mono log handler callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/6572

2 2

[PATCH v11 0/12] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 28 Sep '24

28 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v11: wlanapi: Add NetworkManager backed implementation for WlanGetProfileList. wlanapi/tests: Add unit tests for WlanGetProfileList. wlanapi: Add stub for WlanGetProfileList. wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. wlanapi: Add stub for WlanGetNetworkBssList. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

4 16

[PATCH v4 0/12] MR6369: Draft: Refactor the async state flags
by Jinoh Kang (＠iamahuman) 28 Sep '24

28 Sep '24

-- v4: server: Eliminate async_alerted() helper function. server: Eliminate async_unknown_status() helper function. server: Remove "unknown_status" field from struct async. server: Remove "alerted" field from struct async. server: Remove "terminated" field from struct async. server: Remove "signaled" field from struct async. server: Remove "direct_result" field from struct async. server: Signal async unconditionally in async_set_result(). server: Introduce a new async state enum. server: Introduce async_unknown_status() helper to compute the 'unknown_status' flag. server: Introduce async_alerted() helper to compute the 'alerted' flag. server: Introduce async_terminated() helper to compute the 'terminated' flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/6369

3 13

Re: [PATCH v4 0/2] MR6443: comdlg32: allow entering a filter in the itemdlg file name field
by Fabian Maurer (＠DarkShadow44) 28 Sep '24

28 Sep '24

This introduced a regression: https://bugs.winehq.org/show_bug.cgi?id=57240 Would you mind taking a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6443#note_83607

1 0

[PATCH v7 0/5] MR6437: ntoskrnl: Implement IoReportTargetDeviceChange
by Vibhav Pant (＠vibhavp) 27 Sep '24

27 Sep '24

-- v7: ntoskrnl: Implement IoReportTargetDeviceChange. plugplay: Add support for DBT_DEVTYP_HANDLE notifications. https://gitlab.winehq.org/wine/wine/-/merge_requests/6437

3 6

[PATCH v6 0/5] MR6437: ntoskrnl: Implement IoReportTargetDeviceChange
by Vibhav Pant (＠vibhavp) 27 Sep '24

27 Sep '24

-- v6: ntoskrnl: Implement IoReportTargetDeviceChange. plugplay: Add support for DBT_DEVTYP_HANDLE notifications. https://gitlab.winehq.org/wine/wine/-/merge_requests/6437

3 6

[PATCH v5 0/5] MR6437: ntoskrnl: Implement IoReportTargetDeviceChange
by Vibhav Pant (＠vibhavp) 27 Sep '24

27 Sep '24

-- v5: ntoskrnl: Implement IoReportTargetDeviceChange. plugplay: Add support for DBT_DEVTYP_HANDLE notifications. sechost: Simplify device notification registration. ntoskrnl/tests: Add tests for IoReportTargetDeviceChange. ntoskrnl: Add stub for IoReportTargetDeviceChange. https://gitlab.winehq.org/wine/wine/-/merge_requests/6437

3 9

[PATCH v3 0/5] MR6437: ntoskrnl: Implement IoReportTargetDeviceChange
by Vibhav Pant (＠vibhavp) 27 Sep '24

27 Sep '24

-- v3: ntoskrnl: Implement IoReportTargetDeviceChange. plugplay: Add support for DBT_DEVTYP_HANDLE notifications. sechost: Simplify device notification registration. ntoskrnl/tests: Add tests for IoReportTargetDeviceChange. ntoskrnl: Add stub for IoReportTargetDeviceChange. https://gitlab.winehq.org/wine/wine/-/merge_requests/6437

3 6