September 2024 - Wine-gitlab

Re: [PATCH v4 0/2] MR6443: comdlg32: allow entering a filter in the itemdlg file name field
by Charlotte Pabst (＠CharlottePabst) 30 Sep '24

30 Sep '24

On Mon Sep 30 17:50:43 2024 +0000, Fabian Maurer wrote: > This introduced a regression: https://bugs.winehq.org/show_bug.cgi?id=57240 > Would you mind taking a look? I submitted a fix as !6589 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6443#note_83681

1 0

[PATCH v2 0/2] MR6584: wintab32: Improve wow64 support
by John Chadwick (＠jchw) 30 Sep '24

30 Sep '24

wintab32 is currently broken in the new wow64 mode because the `tablet_get_packet` thunk in winex11.drv is not implemented. Since the structure it is copying is entirely internal to Wine, and the HCTX handle value is not actually read or written by the driver side, I found that simply padding the structure to keep the rest of it aligned was enough to make wow64 happy and allow wintab32 to function. This is somewhat a stopgap. What would be much better is to refactor the wintab code such that more of the logic is in the wintab32 implementation and not the driver. My goal is to accomplish this as part of trying to get my winewayland graphics tablet patch into an acceptable state for upstreaming. However, I think this is still a worthwhile improvement to have in the interim, if it is acceptable. -- v2: winex11: Remove stub tablet_get_packet wow64 thunk wintab32: Pad WTPACKET to align 32/64-bit archs https://gitlab.winehq.org/wine/wine/-/merge_requests/6584

3 7

[PATCH v2 0/2] MR6580: win32u: Correctly fill new foreground window TID in WM_ACTIVATEAPP.
by Paul Gofman (＠gofman) 30 Sep '24

30 Sep '24

-- v2: win32u: Correctly fill new foreground window TID in WM_ACTIVATEAPP. win32u: Call set_active_window() helper directly from handle_internal_message(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6580

3 4

[PATCH 0/1] MR6580: win32u: Correctly fill new foreground window TID in WM_ACTIVATEAPP.
by Paul Gofman (＠gofman) 30 Sep '24

30 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6580

5 10

[PATCH 0/1] MR6588: findstr: Preserve line endings.
by Hans Leidekker (＠hans) 30 Sep '24

30 Sep '24

To preserve line endings we need to switch to binary mode which means we no longer get Unicode input. This is not a problem because native doesn't support it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6588

2 1

[PATCH 0/1] MR6587: ntdll: Return success for NtSetInformationProcess(ProcessPowerThrottlingState).
by Hans Leidekker (＠hans) 30 Sep '24

30 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6587

2 1

[PATCH 0/1] MR6586: user32/tests: Test that DragDetect() uses client coordinates instead of screen coordinates.
by Zhiyi Zhang (＠zhiyi) 30 Sep '24

30 Sep '24

Test that DragDetect() uses client coordinates instead of screen coordinates even though MSDN says that DragDetect() should use screen coordinates. This also means that Wine's current implementation is correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6586

3 2

[PATCH 0/2] MR6584: wintab32: Improve wow64 support
by John Chadwick (＠jchw) 30 Sep '24

30 Sep '24

wintab32 is currently broken in the new wow64 mode because the `tablet_get_packet` thunk in winex11.drv is not implemented. Since the structure it is copying is entirely internal to Wine, and the HCTX handle value is not actually read or written by the driver side, I found that simply padding the structure to keep the rest of it aligned was enough to make wow64 happy and allow wintab32 to function. This is somewhat a stopgap. What would be much better is to refactor the wintab code such that more of the logic is in the wintab32 implementation and not the driver. My goal is to accomplish this as part of trying to get my winewayland graphics tablet patch into an acceptable state for upstreaming. However, I think this is still a worthwhile improvement to have in the interim, if it is acceptable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6584

3 3

[PATCH v3 0/3] MR6199: Draft: winewayland.drv: Fix keyboard focused out behavior
by YuriK7 (＠riyu12383) 29 Sep '24

29 Sep '24

Fix the wayland side of https://bugs.winehq.org/show_bug.cgi?id=55336 ### Exit menu key by default: That's the actual behavior, any non-special key will exit the menu key, and be sent to the client. I was also wondering if we should add `menu_sys_key = f10_key = 0;` when receiving a `WM_ACTIVATE` in `win32u/defwnd.c`'s `default_window_proc` but I guess not ? ### Fix repeated key for no reason: For some reason when ALT is pressed, it is spammed and thus spams SYS_COMMAND. This fix that, but I don't know what I am doing here. I don't see any repeating key spamming with winex11 but I could be wrong. However alt/SYS_COMMAND should not be repeated. That wasn't happening with winex11.drv. ### Fix release_all_keys modifier filtering: That was the main reason why alt-tab leads to the menu key, NtUserGetAsyncKeyboardState also uses left and right system keys. ### Fix release_all_keys scan value: This one is wrong, a failed attempt. The actual problem is that NtUserGetAsyncKeyboardState limits itself to 256 virtual keys, discarding the extended scan code info. So it results on my down arrow being kept repeated while being focused out, and when focused in, pressing the arrow again is needed to stop the repeat. Also using the KEYEVENTF_SCANCODE flag results in win32u/message.c's send_hardware_message calling NtUserGetKeyboardLayout which get a incorect hkl value but it doesn't seems to have an impact. -- v3: winewayland.drv: Fix release_all_keys modifier filtering server: Fix repeated key for no reason win32u: Exit menu key by default https://gitlab.winehq.org/wine/wine/-/merge_requests/6199

3 5

[PATCH v2 0/6] MR6575: dplayx: Open() part 4.
by Anton Baskanov (＠baskanov) 29 Sep '24

29 Sep '24

-- v2: dplayx: Set player data in DP_CreatePlayer(). dplayx: Add player to the system group in DP_CreatePlayer(). dplayx: Don't enumerate system players. dplayx/tests: Test that players from SUPERENUMPLAYERSREPLY are added to the session. https://gitlab.winehq.org/wine/wine/-/merge_requests/6575

4 9