September 2024 - Wine-gitlab

Re: [PATCH v13 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
by AlexeyLushnikov (＠AlexeyLushnikov) 12 Sep '24

12 Sep '24

On Wed Sep 11 16:44:51 2024 +0000, Jacek Caban wrote: > You could just return 0 here, which would allow you to simplify the code > some more. Then you don't need the assignment above. And without that > assignment, we could remove `blit_dc != *hdc` check from error handling path. I think we could remove `blit_bitmap != *bitmap` from error handle too. We don't assign `*bitmap` to `blit_bitmap` before the last `goto err`. And we could remove `if(blit_dc)` check too. We return FALSE if `NtGdiCreateCompatibleDC` fails and `blit_dc` doesn't change before the last `goto err`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81990

1 0

[PATCH 0/1] MR6479: winemac: Marshal user-mode callback pointers in macdrv_init wow64 thunk.
by Brendan Shanks (＠bshanks) 11 Sep '24

11 Sep '24

Fixes regression from 138d1991253eed9784d8a65f3b407c81981ec191. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6479

2 1

Re: [PATCH v2 0/1] MR6477: user32: Implement listbox MSAA events on click. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6477

1 0

Re: [PATCH v2 0/1] MR6476: sc: Return error value rather than 1 on failure. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6476

1 0

Re: [PATCH v2 0/8] MR6475: Cmd engine rewrite (part XXIV) - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6475

1 0

Re: [PATCH v2 0/3] MR6474: dplayx: Merge DPLobby interfaces togther - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6474

1 0

Re: [PATCH v4 0/5] MR6468: dplayx, dpwsockx: EnumSessions() part 1 - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6468

1 0

Re: [PATCH v2 0/1] MR6470: ntdll: Do not call LDR notifications during process shutdown. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6470

1 0

Re: [PATCH v2 0/7] MR6472: mfsrcsnk: Stub more of the media source methods. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6472

1 0

Re: [PATCH v4 0/3] MR6379: wined3d: Fixes for Vulkan device extensions. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6379

1 0