September 2024 - Wine-gitlab

Re: [PATCH v3 0/4] MR6378: wined3d: Move FFP shader invalidation to wined3d_device_apply_stateblock(), part 2. - approved
by Alexandre Julliard (＠julliard) 10 Sep '24

10 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6378

1 0

Re: [PATCH v5 0/4] MR6442: winedmo: Introduce a new DLL as a MF FFmpeg backend. - approved
by Alexandre Julliard (＠julliard) 10 Sep '24

10 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6442

1 0

Re: [PATCH v2 0/1] MR6457: user32: Add CreateSyntheticPointerDevice stub. - approved
by Alexandre Julliard (＠julliard) 10 Sep '24

10 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6457

1 0

Re: [PATCH v2 0/1] MR6465: msiexec: Avoid crash if PackageName is NULL. - approved
by Alexandre Julliard (＠julliard) 10 Sep '24

10 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6465

1 0

[PATCH v2 0/5] MR6446: ntdll: Support process instrumentation callback.
by Paul Gofman (＠gofman) 10 Sep '24

10 Sep '24

-- v2: ntdll: Call instrumentation callback for KiUserModeCallback on x64. ntdll: Call instrumentation callback for LdrInitializeThunk on x64. ntdll: Call instrumentation callback for KiUserExceptionDispatcher on x64. ntdll: Call instrumentation callback from wine_syscall_dispatcher on x64. ntdll/tests: Add more tests for process instrumentation callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/6446

3 7

Re: [PATCH v2 0/3] MR6379: wined3d: Fixes for Vulkan device extensions.
by Elizabeth Figura (＠zfigura) 10 Sep '24

10 Sep '24

Fair enough. I'll make it "add" since it's not *quite* prepending it either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6379#note_81789

1 0

[PATCH v14 0/6] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 10 Sep '24

10 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v14: bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes and BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add unit tests for BluetoothSdpGetContainerElementData and BluetoothSdpGetElementData. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

3 7

Re: [PATCH v10 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
by AlexeyLushnikov (＠AlexeyLushnikov) 10 Sep '24

10 Sep '24

On Tue Sep 10 12:08:06 2024 +0000, Jacek Caban wrote: > We'd still leak if `GetDIBits` fails. We could move setting it after > `GetDIBits` call, but it's maybe easier to just duplicate `GetDIBits` > call inside if-else statement. Yes. I think the first variant is shorter, but it has an unnecessary assignment if info_size == sizeof(dib). The duplication of GetDIBits is clearer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81777

1 0

[PATCH 0/1] MR6469: odbc32: Only call process_detach() if the unixlib was successfully loaded.
by Hans Leidekker (＠hans) 10 Sep '24

10 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6469

2 1

Re: [PATCH v10 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
by Jacek Caban (＠jacek) 10 Sep '24

10 Sep '24

Jacek Caban (@jacek) commented about dlls/gdi32/emfdc.c: > if (!SelectObject( blit_dc, blit_bitmap )) goto err; > if (!BitBlt( blit_dc, 0, 0, bmp.bmWidth, bmp.bmHeight, *hdc, 0, 0, SRCCOPY )) > goto err; > + > + *hdc = blit_dc; > + *bitmap = blit_bitmap; > } > if (!GetDIBits( blit_dc, blit_bitmap, 0, INT_MAX, NULL, info, DIB_RGB_COLORS )) > goto err; We'd still leak if `GetDIBits` fails. We could move setting it after `GetDIBits` call, but it's maybe easier to just duplicate `GetDIBits` call inside if-else statement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81769

1 0