September 2024 - Wine-gitlab

[PATCH v9 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Arek Hiler (＠ivyl) 02 Sep '24

02 Sep '24

This is based on work done by Andrew Eikum. It has been in some form in Proton for the last 4 years. If server's sampling rate is not 48kHz **DOOM Eternal** will try to set it 48kHz for the streams using the implemented interface. There's a whole class of audio devices that use 44.1kHz sampling rate and at least PulseAudio / PipeWire tends to inherit the value from the hardware to avoid resampling. The value can also be overridden by the user via the audio server's config files. In such cases, if the interface is not present or stubbed, this results in **audio underruns and noticeable crackling**. It's easy to test with pipewire-pulse: ``` $ cat /etc/pipewire/pipewire.conf.d/sample-rate.conf context.properties = { default.clock.rate = 41100 } ``` With PulseAudio this should be doable via setting `default-sample-rate = 41100` in `/etc/pulse/daemon.conf`. -- v9: winepulse.drv: Implement set_sample_rate. https://gitlab.winehq.org/wine/wine/-/merge_requests/5585

6 8

[PATCH v3 0/2] MR6423: kernel32: Implement GetFirmwareType, GetFirmwareEnvironmentVariable*
by Grigory Vasilyev (＠h0tc0d3) 02 Sep '24

02 Sep '24

Kernel32 Implement: - `GetFirmwareType` - `GetFirmwareEnvironmentVariableExA` - `GetFirmwareEnvironmentVariableExW` - `GetFirmwareEnvironmentVariableA` - `GetFirmwareEnvironmentVariableW`. The code is needed to check SecureBoot status, security systems and for example to check the licenses of software that can use efi variables. Example: ```C #include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <windows.h> #include <winnt.h> /* x86_64-w64-mingw32-gcc wuefi.c -o wuefi.exe -Wl,--subsystem,console */ int main(int argc, char **argv) { BOOLEAN secureboot = 0; char asus_license[2048]; FIRMWARE_TYPE type; if(GetFirmwareType(&type)) printf("Firmware Type: %s\n", type == FirmwareTypeUefi ? "UEFI" : "BIOS"); if(GetFirmwareEnvironmentVariableA("SecureBoot", "{8be4df61-93ca-11d2-aa0d-00e098032b8c}", &secureboot, sizeof(BOOLEAN))) printf("SecureBoot: %s\n", secureboot ? "enabled" : "disabled"); if(GetFirmwareEnvironmentVariableW(L"SecureBoot", L"{8be4df61-93ca-11d2-aa0d-00e098032b8c}", &secureboot, sizeof(BOOLEAN))) printf("SecureBoot: %s\n", secureboot ? "enabled" : "disabled"); if(GetFirmwareEnvironmentVariableA("AsusOnboardToolLicense", "02076249-a52b-420e-bd53-aed044349379", asus_license, sizeof(asus_license))) printf("Asus License: \n%s\n\n", asus_license); return 0; } ``` ``` Firmware Type: UEFI SecureBoot: enabled SecureBoot: enabled Asus License: bigtext== [LicenseID]:FED7A1 [Model]:Dummy-BaseBoard-Id [Tools]:WAsusDmiS,LogoFlashS,ASUSFwConfigS,AsusEventLogS,AsusNvLockS [Customer]:DummyLic [Expire]:2022-11-24 ``` -- v3: kernel32: Implement GetFirmwareEnvironmentVariableExA, GetFirmwareEnvironmentVariableExW, GetFirmwareEnvironmentVariableA, GetFirmwareEnvironmentVariableW. kernel32: Implement GetFirmwareType. https://gitlab.winehq.org/wine/wine/-/merge_requests/6423

4 5

[PATCH 0/8] MR6427: winevulkan: Introduce a vulkan object structure.
by Rémi Bernon 02 Sep '24

02 Sep '24

I'm starting to consider wrapping more vulkan objects in win32u, I think it'll be useful to implement compositing (and incidentally shared resources with interop with the D3DKMT/NtGdi API), starting with nulldrv/offscreen swapchains. Alternatively we could export more functions from win32u and keep all the wrappers in winevulkan, but having access to win32u internals with a generic vulkan object wrapping mechanism seems to be more interesting. Right now this is not very convenient because the vulkan object hierarchy is only available in winevulkan. This introduces shared structures and API between win32u and winevulkan so they can manipulate the wrapped objects from both side. The interface would only expose what is necessary, ie: the object hierarchy and wrapped handles, the instance and device functions, and the objects rbtree for debugging, so win32u can insert its wrapper there as well. After moving the surface and swapchain wrappers to win32u, the interface would look like this: https://gitlab.winehq.org/rbernon/wine/-/blob/65ca1280d46a2dff792e298c22242… (I pushed a complete WIP branch to https://gitlab.winehq.org/rbernon/wine/-/commits/wip/vulkan-win32u-driver?r…) We can also consider moving all the winevulkan wrappers to win32u but it's not clear whether it's necessary or desirable, and we can also do that later using this interface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6427

1 8

[PATCH 0/1] MR6426: wpcap/tests: Skip tests when pcap_can_set_rfmon() returns PCAP_ERROR_PERM_DENIED.
by Hans Leidekker (＠hans) 02 Sep '24

02 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6426

2 1

[PATCH v3 0/8] MR6396: win32u: Stop setting DPI_PER_MONITOR_AWARE by default.
by Rémi Bernon 02 Sep '24

02 Sep '24

This activates the new DPI scaling, and stops pretending that every window is per-monitor DPI aware. It uses the GDI scaled surfaces for DPI-unaware windows, instead of the current higher resolution surfaces, which gives more blurry results but this is the same as Windows for DPI-unaware cases. -- v3: win32u: Stop setting DPI_PER_MONITOR_AWARE by default. explorer: Make the desktop thread per-monitor DPI aware. user32: Move dpiaware_init to SYSPARAMS_Init. server: Pass window's per-monitor DPI in set_window_pos. win32u: Pass window_from_point dpi to list_children_from_point. win32u: Map rect to window DPI in expose_window_surface. winex11: Map message pos to physical DPI in move_resize_window. winewayland: Remove unnecessary logical to physical DPI mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/6396

2 11

[PATCH v2 0/7] MR6396: win32u: Stop setting DPI_PER_MONITOR_AWARE by default.
by Rémi Bernon 02 Sep '24

02 Sep '24

This activates the new DPI scaling, and stops pretending that every window is per-monitor DPI aware. It uses the GDI scaled surfaces for DPI-unaware windows, instead of the current higher resolution surfaces, which gives more blurry results but this is the same as Windows for DPI-unaware cases. -- v2: win32u: Stop setting DPI_PER_MONITOR_AWARE by default. explorer: Make the desktop thread per-monitor DPI aware. server: Pass window's per-monitor DPI in set_window_pos. win32u: Pass window_from_point dpi to list_children_from_point. win32u: Map rect to window DPI in expose_window_surface. winex11: Map message pos to physical DPI in move_resize_window. winewayland: Remove unnecessary logical to physical DPI mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/6396

3 12

[PATCH v12 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect.
by Jacob Czekalla (＠JacobCzekalla) 02 Sep '24

02 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56873 -- v12: comctl32/edit: Fix incorrect size for format rect when it is smaller than text. comctl32/tests: Add test for edit control format rect size. user32/edit: Fix incorrect size for format rect when it is smaller than text. user32/tests: Add test for edit control format rect size. https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

4 6

[PATCH 0/3] MR5756: comdlg32: Fix a few issues with color dialog
by Fabian Maurer (＠DarkShadow44) 02 Sep '24

02 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5756

3 14

Re: [PATCH v8 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Huw Davies (＠huw) 02 Sep '24

02 Sep '24

Rebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_80684

1 0

[PATCH 0/2] MR6421: d3d10/effect: Rename some variable array fields to better reflect their meaning.
by Nikolay Sivov (＠nsivov) 02 Sep '24

02 Sep '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6421

3 3