September 2024 - Wine-gitlab

Re: [PATCH v3 0/1] MR6352: winegstreamer: Support IYUV alias for I420
by Aida Jonikienė 02 Sep '24

02 Sep '24

On Mon Sep 2 06:13:48 2024 +0000, Rémi Bernon wrote: > I don't know what @DodoGTA meant but it's actually **not** considered > good practice to push changes unnecessarily. > Rebasing MRs should only be done when they actually conflict (the Gitlab > indication on top is often misleading), as rebasing makes Gitlab > "Compare with previous version" feature much less useful. I meant only doing that when an MR update is actually needed (because merge commits aren't a good idea) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6352#note_80667

1 0

Re: [PATCH v3 0/1] MR6352: winegstreamer: Support IYUV alias for I420
by Rémi Bernon 02 Sep '24

02 Sep '24

However, you need to edit your commit to use your full name as committer. You don't need the "Signed-off-by" anymore but it's fine to keep it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6352#note_80664

1 0

Re: [PATCH v3 0/1] MR6352: winegstreamer: Support IYUV alias for I420
by Rémi Bernon 02 Sep '24

02 Sep '24

I don't know what @DodoGTA meant but it's actually **not** considered good practice to push changes unnecessarily. Rebasing MRs should only be done when they actually conflict (the Gitlab indication on top is often misleading), as rebasing makes Gitlab "Compare with previous version" feature much less useful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6352#note_80661

1 0

[PATCH v12 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 02 Sep '24

02 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v12: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 4

Re: [PATCH v2 0/1] MR6352: winegstreamer: Support IYUV alias for I420
by CreeperFace (＠dy-tea) 01 Sep '24

01 Sep '24

Will do -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6352#note_80636

1 0

[PATCH v2 0/2] MR6423: kernel32: Implement GetFirmwareType, GetFirmwareEnvironmentVariable*
by Grigory Vasilyev (＠h0tc0d3) 01 Sep '24

01 Sep '24

Kernel32 Implement: - `GetFirmwareType` - `GetFirmwareEnvironmentVariableExA` - `GetFirmwareEnvironmentVariableExW` - `GetFirmwareEnvironmentVariableA` - `GetFirmwareEnvironmentVariableW`. The code is needed to check SecureBoot status, security systems and for example to check the licenses of software that can use efi variables. Example: ```C #include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <windows.h> #include <winnt.h> /* x86_64-w64-mingw32-gcc wuefi.c -o wuefi.exe -Wl,--subsystem,console */ int main(int argc, char **argv) { BOOLEAN secureboot = 0; char asus_license[2048]; FIRMWARE_TYPE type; if(GetFirmwareType(&type)) printf("Firmware Type: %s\n", type == FirmwareTypeUefi ? "UEFI" : "BIOS"); if(GetFirmwareEnvironmentVariableA("SecureBoot", "{8be4df61-93ca-11d2-aa0d-00e098032b8c}", &secureboot, sizeof(BOOLEAN))) printf("SecureBoot: %s\n", secureboot ? "enabled" : "disabled"); if(GetFirmwareEnvironmentVariableW(L"SecureBoot", L"{8be4df61-93ca-11d2-aa0d-00e098032b8c}", &secureboot, sizeof(BOOLEAN))) printf("SecureBoot: %s\n", secureboot ? "enabled" : "disabled"); if(GetFirmwareEnvironmentVariableA("AsusOnboardToolLicense", "02076249-a52b-420e-bd53-aed044349379", asus_license, sizeof(asus_license))) printf("Asus License: \n%s\n\n", asus_license); return 0; } ``` ``` Firmware Type: UEFI SecureBoot: enabled SecureBoot: enabled Asus License: bigtext== [LicenseID]:FED7A1 [Model]:Dummy-BaseBoard-Id [Tools]:WAsusDmiS,LogoFlashS,ASUSFwConfigS,AsusEventLogS,AsusNvLockS [Customer]:DummyLic [Expire]:2022-11-24 ``` -- v2: kernel32: Implement GetFirmwareEnvironmentVariableExA, GetFirmwareEnvironmentVariableExW, GetFirmwareEnvironmentVariableA, GetFirmwareEnvironmentVariableW. kernel32: Implement GetFirmwareType. https://gitlab.winehq.org/wine/wine/-/merge_requests/6423

3 4

[PATCH 0/1] MR6423: kernel32: Implement GetFirmwareType, GetFirmwareEnvironmentVariableExA,...
by Grigory Vasilyev (＠h0tc0d3) 01 Sep '24

01 Sep '24

kernel32: Implement GetFirmwareType, GetFirmwareEnvironmentVariableExA, GetFirmwareEnvironmentVariableExW, GetFirmwareEnvironmentVariableA, GetFirmwareEnvironmentVariableW. Example: ```C #include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <windows.h> #include <winnt.h> /* x86_64-w64-mingw32-gcc wuefi.c -o wuefi.exe -Wl,--subsystem,console */ int main(int argc, char **argv) { BOOLEAN secureboot = 0; char asus_license[2048]; FIRMWARE_TYPE type; if(GetFirmwareType(&type)) printf("Firmware Type: %s\n", type == FirmwareTypeUefi ? "UEFI" : "BIOS"); if(GetFirmwareEnvironmentVariableA("SecureBoot", "{8be4df61-93ca-11d2-aa0d-00e098032b8c}", &secureboot, sizeof(BOOLEAN))) printf("SecureBoot: %s\n", secureboot ? "enabled" : "disabled"); if(GetFirmwareEnvironmentVariableW(L"SecureBoot", L"{8be4df61-93ca-11d2-aa0d-00e098032b8c}", &secureboot, sizeof(BOOLEAN))) printf("SecureBoot: %s\n", secureboot ? "enabled" : "disabled"); if(GetFirmwareEnvironmentVariableA("AsusOnboardToolLicense", "02076249-a52b-420e-bd53-aed044349379", asus_license, sizeof(asus_license))) printf("Asus License: \n%s\n\n", asus_license); return 0; } ``` ``` Firmware Type: UEFI SecureBoot: enabled SecureBoot: enabled Asus License: bigtext== [LicenseID]:FED7A1 [Model]:Dummy-BaseBoard-Id [Tools]:WAsusDmiS,LogoFlashS,ASUSFwConfigS,AsusEventLogS,AsusNvLockS [Customer]:DummyLic [Expire]:2022-11-24 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6423

6 8

Re: [PATCH v2 0/1] MR6352: winegstreamer: Support IYUV alias for I420
by Aida Jonikienė 01 Sep '24

01 Sep '24

You should rebase and force push to update a MR (this keeps things cleaner); Julliard will probably pick your commit manually (but it's good practice to do that) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6352#note_80626

1 0