January 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/2] MR7211: windowscodecs: Implement IWICBitmapFlipRotator(WICBitmapTransformRotate90) for bitmaps with bpp >= 8.
by Dmitry Timoshkov (＠dmitry) 01 Feb '25

01 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7211

4 8

[PATCH v6 0/5] MR6889: threadpoolwinrt: Implement IAsyncAction and IAsyncInfo.
by Vibhav Pant (＠vibhavp) 01 Feb '25

01 Feb '25

This MR adds an implementation for the `IAsyncAction` and `IAsyncInfo` interfaces exported by `Windows.System.Threading`, including support for setting `IAsyncActionCompletedHandler` values for an `IAsyncAction`. It also re-writes (or factors?) the `IAsyncOperation<boolean>` implementation in dlls/cryptowinrt to use `ThreadPoolStatics::RunAsync`, by introducing a type-punning variant of `AsyncOperationCompletedHandler<T>` (similar to `WineAsyncOperationCompletedHandler`), which is a wrapper around the `IAsyncAction` returned by `RunAsync`. The new `IAsyncOperation<T>` implementation is simpler, and if merged, can be exported to other dlls (windows.gaming.input and windows.security.credentials.ui.userconsentverifier for now). -- v6: cryptowinrt: Rewrite IAsyncOperation using Windows.System.Threading. https://gitlab.winehq.org/wine/wine/-/merge_requests/6889

3 9

[PATCH v12 0/2] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 31 Jan '25

31 Jan '25

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- v12: programs/cmd: Tests patch from @epo https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

3 3

[PATCH v10 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 31 Jan '25

31 Jan '25

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- v10: programs/cmd: Cleanup DIR /O logic. https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

2 1

[PATCH v5 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu 31 Jan '25

31 Jan '25

-- v5: ntdll: Allow renaming a file/directory to a different case of itself. https://gitlab.winehq.org/wine/wine/-/merge_requests/246

2 9

Re: [PATCH v9 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by eric pouech (＠epo) 31 Jan '25

31 Jan '25

sorry, forgot to mention it but all the tests above pass with your patch (and a bunch fail without) (you should theorically also get that with CI... in theory) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_93334

1 0

Re: [PATCH v9 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 31 Jan '25

31 Jan '25

On Fri Jan 31 17:26:57 2025 +0000, eric pouech wrote: > Thanks for the submission. > I'm not thrilled by the outcome style-wise, but given the starting > point, I fully agree with you that it'll way too large to go further. > Two remarks though: > The commit message should read: "programs/cmd: Cleanup DIR /O logic." > (without the quotes) we want to trace which module is addressed by the > change, and commit line should be terminated by a '.' > Content-wise, we definitively need to embed the tests (as the ones I > posted above) inside the merge request in order to detect potential > further regressions. This means the MR shall contain two patches: > * first patch in MR: the tests (marked with @todo_wine@ for the failing > ones), > * the second patch in MR: basically your current patch + removal of > @todo_wine@ that now pass. > Either you feel up to do it (feel free to use the patch of tests above); > if not, I can repackage your patch into the desired form. Thanks for the feedback and guidance. I appreciate it. I can certainly try to change the commit message and add the test patch to the MR. I was never able to get the tests to run on my system, however. I believe that it's likely that my build is inadequate. I am not building a full Wine with WOW64 support, etc. Perhaps the CI will run the tests and perhaps I can see the results to see if they are failing, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_93332

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri 31 Jan '25

31 Jan '25

Great! Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93329

1 0

[PATCH v10 0/23] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 31 Jan '25

31 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v10: dlls/oleaut32: ITypeComp::BindType() should dispatch ITypeLibComp::BindType() dlls/oleaut32: Invert if stmt in ITypeInfoImpl_Constructor() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

1 0

[PATCH v9 0/21] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 31 Jan '25

31 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v9: dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: Consistently use TLB_get_bstr() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

1 0