January 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v9 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 31 Jan '25

31 Jan '25

On Fri Jan 31 17:26:57 2025 +0000, eric pouech wrote: > Thanks for the submission. > I'm not thrilled by the outcome style-wise, but given the starting > point, I fully agree with you that it'll way too large to go further. > Two remarks though: > The commit message should read: "programs/cmd: Cleanup DIR /O logic." > (without the quotes) we want to trace which module is addressed by the > change, and commit line should be terminated by a '.' > Content-wise, we definitively need to embed the tests (as the ones I > posted above) inside the merge request in order to detect potential > further regressions. This means the MR shall contain two patches: > * first patch in MR: the tests (marked with @todo_wine@ for the failing > ones), > * the second patch in MR: basically your current patch + removal of > @todo_wine@ that now pass. > Either you feel up to do it (feel free to use the patch of tests above); > if not, I can repackage your patch into the desired form. Thanks for the feedback and guidance. I appreciate it. I can certainly try to change the commit message and add the test patch to the MR. I was never able to get the tests to run on my system, however. I believe that it's likely that my build is inadequate. I am not building a full Wine with WOW64 support, etc. Perhaps the CI will run the tests and perhaps I can see the results to see if they are failing, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_93332

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri 31 Jan '25

31 Jan '25

Great! Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93329

1 0

[PATCH v10 0/23] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 31 Jan '25

31 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v10: dlls/oleaut32: ITypeComp::BindType() should dispatch ITypeLibComp::BindType() dlls/oleaut32: Invert if stmt in ITypeInfoImpl_Constructor() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

1 0

[PATCH v9 0/21] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 31 Jan '25

31 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v9: dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: Consistently use TLB_get_bstr() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

1 0

[PATCH 0/1] MR7234: netapi32: Add stubs for DsGetDcOpenA/W.
by Dmitry Timoshkov (＠dmitry) 31 Jan '25

31 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7234

3 2

Re: [PATCH v9 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by eric pouech (＠epo) 31 Jan '25

31 Jan '25

Thanks for the submission. I'm not thrilled by the outcome style-wise, but given the starting point, I fully agree with you that it'll way too large to go further. Two remarks though: The commit message should read: "programs/cmd: Cleanup DIR /O logic." (without the quotes) we want to trace which module is addressed by the change, and commit line should be terminated by a '.' Content-wise, we definitively need to embed the tests (as the ones I posted above) inside the merge request in order to detect potential further regressions. This means the MR shall contain two patches: * first patch in MR: the tests (marked with @todo_wine@ for the failing ones), * the second patch in MR: basically your current patch + removal of @todo_wine@ that now pass. Either you feel up to do it (feel free to use the patch of tests above); if not, I can repackage your patch into the desired form. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_93325

1 0

[PATCH 0/6] MR7233: wineswmidi: Add SW Synth MIDI driver part 0.
by Anton Baskanov (＠baskanov) 31 Jan '25

31 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7233

2 6

[PATCH v10 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 31 Jan '25

31 Jan '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v10: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

4 4

[PATCH v8 0/19] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 31 Jan '25

31 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v8: dlls/oleaut32: Validate args of ITypeLibComp_fnBind() dlls/oleaut32: Fix wFlags check in ITypeLibComp_fnBind() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

1 0

[PATCH v7 0/17] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 31 Jan '25

31 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v7: dlls/oleaut32: Shink down ITypeLibComp_fnBind() verbosity some dlls/oleaut32: Use consistent param identifers in ITypeComp dlls/oleaut32: Validate arguments correctly in ITypeComp interface dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use array indexing in ITypeLib2_Constructor_SLTG() This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

1 0