January 2025 - Wine-gitlab - list.winehq.org

[PATCH v8 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 29 Jan '25

29 Jan '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v8: ntdll: Update NtQueryDirectoryFile to purge cache if scan is reset with a new mask ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

4 22

Re: [PATCH v3 0/5] MR7225: msvcr120: Add _FCbuild, cimag, cimags and crealf implementation. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7225

1 0

Re: [PATCH v2 0/1] MR7220: winex11.drv: Update window shape before putting surface image. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7220

1 0

Re: [PATCH v3 0/1] MR7172: win32u: Implement a couple of syscalls. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7172

1 0

Re: [PATCH v3 0/2] MR7224: wbemprox: Implement Win32_PnPEntity.Service. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7224

1 0

Re: [PATCH v2 0/1] MR7218: crypt32/tests: Avoid use after free in testEmptyStore(). - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7218

1 0

Re: [PATCH v2 0/8] MR7215: crypt32: Improve support for CMSGs. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7215

1 0

Re: [PATCH v2 0/1] MR7207: d3d9: Fix IUnknown delegation in IDirect3DDevice9On12. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7207

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf - closed
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

This merge request was closed by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

I have cleaned up the patches and created !7225 since I can't push to your branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93216

1 0