October 2025 - Wine-gitlab - list.winehq.org

[PATCH v10 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Vibhav Pant (＠vibhavp) 13 Oct '25

13 Oct '25

-- v10: rometadata: Implement IMetaDataTables::{GetColumn, GetColumnInfo}. rometadata/tests: Add tests for IMetaDataTables::{GetColumnInfo, GetColumn}. rometadata: Implement IMetaDataTables::Get{String,Blob,Guid}. rometadata: Implement IMetaDataTables::GetRow. rometadata: Implement IMetaDataTables::GetTableInfo. rometadata: Implement IMetaDataTables::{Get{String,Blob,Guid,UserString}HeapSize, GetNumTables}. https://gitlab.winehq.org/wine/wine/-/merge_requests/9147

3 8

[PATCH 0/1] MR9167: mmdevapi/tests: Use wine_dbgstr_longlong().
by Sven Baars (＠sbaars) 13 Oct '25

13 Oct '25

Fixes compiler warnings on older systems. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9167

3 2

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Vibhav Pant (＠vibhavp) 13 Oct '25

13 Oct '25

v9: * Address feedback. * Remove `tables_set_key_idx`, and calculate the primary key index in `assembly_get_table` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118376

1 0

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Vibhav Pant (＠vibhavp) 13 Oct '25

13 Oct '25

On Mon Oct 13 09:20:43 2025 +0000, Hans Leidekker wrote: > If you make this an array of struct metadata_stream and add the name to > struct metadata_stream you don't need the streams array in assembly_parse_headers(). But then wouldn't we need to always iterate through the array with `strcmp` to get a particular stream (for instance, in `assembly_get_heap_size`, `assembly_get_{string, blob, guid}`)? The spec doesn't say that streams need to appear in a certain order, so we wouldn't be able to use fixed indices to this array. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118375

1 0

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Vibhav Pant (＠vibhavp) 13 Oct '25

13 Oct '25

On Mon Oct 13 09:20:43 2025 +0000, Hans Leidekker wrote: > This is static data, it should be possible to encode this without an > init function. Sure. I have removed this and the associated `key_idx` field in the static schema data. Instead, we just find the primary key column in `assembly_get_table` now. I didn't want to hardcode the primary key index in the schema macros, because I wanted to keep the macros as self-descriptive as possible (through the `*_PRIMARY` column macros, in this case). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118374

1 0

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Vibhav Pant (＠vibhavp) 13 Oct '25

13 Oct '25

On Mon Oct 13 09:20:43 2025 +0000, Hans Leidekker wrote: > Using an offset variable would be cleaner. Sure, thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118373

1 0

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Vibhav Pant (＠vibhavp) 13 Oct '25

13 Oct '25

On Mon Oct 13 09:20:43 2025 +0000, Hans Leidekker wrote: > What if assembly->stream_strings.size == 1? This could be written > without the padding variable. Hm, so II.24.2.3 mandates that the first string should always be `\0`, and II.24.2.2 says that stream sizes should be a multiple of 4. Nonetheless, this should still handle a string heap with a single NUL entry, so rewritten this to subtract padding bytes as long as `stream_strings.size > 1`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118367

1 0

Re: [PATCH v3 0/4] MR8958: win32u: Fixes for the OpenGL drawables mess.
by Rémi Bernon 13 Oct '25

13 Oct '25

On Mon Oct 13 10:09:28 2025 +0000, li xiao wrote: > When I merged this request and submitted win32u: Don't store the window > OpenGL drawables on the DCs.:, I encountered a deadlock while running a > software using wine: 01 a0:err:sync:RtlpWaitForCriticalSection section > 00007F4A4ACC5570 "?" wait timed out in thread 01a0, blocked by 0134, > retrying (60 sec). Before the merger, it's ok. > \ > After this submission : **win32u: Don't store the window OpenGL > drawables on the DCs.The lifecycle of opengl_rrawable is no longer > related to DC,Why is there still** > ```c > struct opengl_drawable *opengl_drawable > ``` > **in DC?** Hi, sorry if this has caused some more issues but if there's a bug please submit a bug report to https://bugs.winehq.org with some more details about it happens and how to reproduce it. Regarding the `opengl_drawable` member in the DC structure, it's still being used for non-Window DCs, like memory DCs, which need to keep a reference on their eventual OpenGL surface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8958#note_118366

1 0

Re: [PATCH v3 0/4] MR8958: win32u: Fixes for the OpenGL drawables mess.
by li xiao (＠xiaolizai) 13 Oct '25

13 Oct '25

When I merged this request and submitted win32u: Don't store the window OpenGL drawables on the DCs.:, I encountered a deadlock while running a software using wine: 01 a0:err:sync:RtlpWaitForCriticalSection section 00007F4A4ACC5570 "?" wait timed out in thread 01a0, blocked by 0134, retrying (60 sec). Before the merger, it's ok. \ After this submission : **win32u: Don't store the window OpenGL drawables on the DCs.The lifecycle of opengl_rrawable is no longer related to DC,Why is there still** ```c struct opengl_drawable *opengl_drawable ``` **in DC?** -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8958#note_118363

1 0

[PATCH v3 0/6] MR9150: comctl32: Remove v6 only exports.
by Zhiyi Zhang (＠zhiyi) 13 Oct '25

13 Oct '25

-- v3: comctl32: Remove v6 only exports. comctl32: Remove syslink from comctl32 v5. comctl32: Remove taskdialog from comctl32 v5. comctl32/tests: Test v6 only exports. comctl32: Remove user32 control copies in comctl32 v5. comctl32/tests: Add RegisterClassNameW() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/9150

3 7