October 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Hans Leidekker (＠hans) 13 Oct '25

13 Oct '25

Hans Leidekker (@hans) commented about dlls/rometadata/assembly.c: > + ULONG i; > + > + for (i = 0; i < TABLE_MAX; i++) > + { > + struct table_schema *schema = table_schemas[i]; > + ULONG j; > + > + for (j = 0; j < schema->columns_len; j++) > + { > + if (schema->columns[j].primary_key) > + { > + schema->key_idx = j; > + break; > + } > + } > + } This is static data, it should be possible to encode this without an init function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118349

1 0

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Hans Leidekker (＠hans) 13 Oct '25

13 Oct '25

Hans Leidekker (@hans) commented about dlls/rometadata/assembly.c: > + break; > + } > + } > + if (FAILED(hr)) return hr; > + /* The stream name is padded to the next 4-byte boundary (ECMA-335 Partition II.24.2.2) */ > + streams_cur += offsetof(struct stream_hdr, name[(streams[j].name_len + 4) & ~3]); > + } > + > + if (assembly->stream_strings.size) > + { > + /* IMetaDataTables::GetStringHeapSize returns the string heap size without the nul byte padding. */ > + const BYTE *ptr = assembly->stream_strings.start + assembly->stream_strings.size - 1; > + ULONG padding; > + > + for (padding = 0; !ptr[0] && !ptr[-1]; ptr--, padding++) /* nothing */; > + assembly->stream_strings.size -= padding; What if assembly->stream_strings.size == 1? This could be written without the padding variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118348

1 0

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Hans Leidekker (＠hans) 13 Oct '25

13 Oct '25

Hans Leidekker (@hans) commented about dlls/rometadata/assembly.c: > + UINT32 size; > + const BYTE *start; > +}; > + > +struct assembly > +{ > + HANDLE file; > + HANDLE map; > + const BYTE *data; > + UINT64 size; > + > + struct metadata_stream stream_tables; > + struct metadata_stream stream_strings; > + struct metadata_stream stream_blobs; > + struct metadata_stream stream_guids; > + struct metadata_stream stream_user_strings; If you make this an array of struct metadata_stream and add the name to struct metadata_stream you don't need the streams array in assembly_parse_headers(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118347

1 0

Re: [PATCH v9 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods.
by Hans Leidekker (＠hans) 13 Oct '25

13 Oct '25

Hans Leidekker (@hans) commented about dlls/rometadata/assembly.c: > +{ > + const BYTE *ptr; > + ULONG size_len; > + HRESULT hr; > + > + if (idx >= assembly->stream_blobs.size) return E_INVALIDARG; > + ptr = assembly->stream_blobs.start + idx; > + if (FAILED(hr = decode_int(ptr, size, &size_len))) return hr; > + *blob = ptr + size_len; > + return S_OK; > +} > + > +const GUID *assembly_get_guid(const assembly_t *assembly, ULONG idx) > +{ > + idx = (idx - 1) * sizeof(GUID); /* Indices into the GUID heap are 1-based */ > + return idx < assembly->stream_guids.size ? (const GUID *)(assembly->stream_guids.start + idx) : NULL; Using an offset variable would be cleaner. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147#note_118350

1 0

[PATCH v2 0/6] MR9150: comctl32: Remove v6 only exports.
by Zhiyi Zhang (＠zhiyi) 13 Oct '25

13 Oct '25

-- v2: comctl32: Remove v6 only exports. comctl32: Remove syslink from comctl32 v5. comctl32: Remove taskdialog from comctl32 v5. comctl32/tests: Test v6 only exports. comctl32: Remove user32 control copies in comctl32 v5. comctl32/tests: Add RegisterClassNameW() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/9150

2 7

[PATCH v5 0/4] MR9112: XCOPY and COPY should not attempt to copy a file to itself.
by Joe Souza (＠JoeS209) 13 Oct '25

13 Oct '25

Current code attempts to copy a file to itself. File is not actually copied; instead, a file sharing error is received. This result is ugly and differs from native. Behavior now appears to be the same as native with changes in this MR . -- v5: cmd: Don't attempt to copy a file to itself. cmd: Reset return_code after successful COPY. https://gitlab.winehq.org/wine/wine/-/merge_requests/9112

2 4

[PATCH v4 0/3] MR9112: XCOPY and COPY should not attempt to copy a file to itself.
by Joe Souza (＠JoeS209) 13 Oct '25

13 Oct '25

Current code attempts to copy a file to itself. File is not actually copied; instead, a file sharing error is received. This result is ugly and differs from native. Behavior now appears to be the same as native with changes in this MR . -- v4: cmd: Don't attempt to copy a file to itself. cmd/tests: Add tests for COPY to self. https://gitlab.winehq.org/wine/wine/-/merge_requests/9112

2 4

[PATCH 0/2] MR9164: advapi, ntdll: Add a couple of event tracing stubs.
by Paul Gofman (＠gofman) 12 Oct '25

12 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9164

2 3

[PATCH v3 0/1] MR8988: win32u: change the stretch mode of dst hdc from BlackOnWhite to ColorOnColor...
by Kun Yang (＠yangkun) 12 Oct '25

12 Oct '25

win32u: change the stretch mode of dst hdc from BlackOnWhite to ColorOnColor when using StretchBlt in TransparentBlt. In NtGdiTransparentBlt function, the StretchBlt mode of dst hdc is not set. The Default StretchBlt Mode in wine is BlackOnWhite. It is not correct to use this StretchBltMode in TransparentBlt dealing with color bitmap. According to MSDN, it should be converted to ColorOnColor. My test code shows that, the image converted by wine generates a lot of chromatic noise. [test_blt.c](/uploads/26101bc7bdb27400d02c8ff5bf741864/test_blt.c) [test_blt.exe](/uploads/98ee3ab7ce0d590e1511bd8a5fb5a1bb/test_blt.exe) ![source](/uploads/0c56c5e6d1280040ba08cd3dee7acd95/source.bmp) ![result_wrong](/uploads/2076396e069f852914313a8fb86dd5e2/result_wrong.bmp) ![result](/uploads/cf3ec00bf0f0e7f3ea7fe1e2085385d6/result.bmp) -- v3: win32u: change the stretch mode of dst hdc from BlackOnWhite to ColorOnColor when using StretchBlt in TransparentBlt. https://gitlab.winehq.org/wine/wine/-/merge_requests/8988

3 5

[PATCH 0/2] MR9162: shell32: Set SFGAO_HASSUBFOLDER correctly for normal shellfolders.
by Elizabeth Figura (＠zfigura) 12 Oct '25

12 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9162

4 5