November 2025 - Wine-gitlab

Re: [PATCH v2 0/1] MR9477: shell32: Implement the function PickIconDlg. - closed
by Matthias Zorn (＠Matthias-Zorn.0178) 20 Nov '25

20 Nov '25

This merge request was closed by Matthias Zorn. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9477

1 0

[PATCH v3 0/1] MR9479: dlls/sane.ds: Load last settings from registry immediatly when opening the DS
by Bernd Herd (＠herdsoft) 20 Nov '25

20 Nov '25

This allows combining the capability negotiation with the application program with the user interface. # Capability values ignored with User Interface The recent patch to save sanner parameters from the twain user interface to the registry restores these parameters from the registry while displaying the dialog box. Settings performed by the application program via the capabilities mechanism are thus overwritten from the registry and ignored. So negotiated parameters are only honoured if the Twain user Interface is not being displayed. In that case _all_ old settings from the previous scan with UI displayed are ignored. # Solution in this merge request The TWAIN 2.4 specification says on Page 4-2 (PDF-Page 76): ``` At the time of loading the data source, all current values for the appropriate capabilities would be set to values that have either been restored from a previous session, or those that are "preferred" by the data source. This current value will remain until it has been explicitly changed by the calling application, or that application issues a MSG_RESET. ``` This is the approach choosen for this merge request: The new function SANE_LoadOptions loads parameter values from the registry when the data source is being opened and transfers them to the sane parameter store. The code in InitializeDialog, that loaded data from the registry, is restored to an older version and does not handle the registry at all. Instead dialog controls are filled based on the information in the SANE parameter database. Saving changed parameters remains as before. -- v3: dlls/sane.ds: Load last settings from registry immediatly when opening the DS https://gitlab.winehq.org/wine/wine/-/merge_requests/9479

3 2

[PATCH 0/2] MR9530: dlls/sane.ds: Added cancel button and progress bar to progress dialog
by Bernd Herd (＠herdsoft) 20 Nov '25

20 Nov '25

Control display of progress dialog with CAP_INDICATORS. Use PeekMessage/DispatchMessage loop while scanning. Display some informations on scan job in progress dialog. If ADF is enabled and not filled with paper, display an error message to the user and allow a retry. Also displays paper jammed message and cover open message. Added german translation for the new error messages and progress dialog controls. ![no_docs_error.png](/uploads/0ff5e941fbae3685e0a94ca8031f075b/no_docs_error.png){width=389 height=320} Error message display are controlled with CAP_INDICATORS if Data Source UI is not shown. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9530

3 11

[PATCH v2 0/4] MR9541: win32u: Reduce EGL memory usage by skipping some devices initialization.
by Rémi Bernon 20 Nov '25

20 Nov '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58833 -- v2: win32u: Skip non-display software EGL devices initialization. win32u: Terminate non-display EGL devices after initialization. win32u: Add the display device first in the EGL device list. win32u: Keep devices EGL platforms in a list. https://gitlab.winehq.org/wine/wine/-/merge_requests/9541

2 6

[PATCH 0/1] MR9544: win32u: Release internal OpenGL drawables outside of the user lock.
by Rémi Bernon 20 Nov '25

20 Nov '25

Sometimes windows get destroyed while wined3d still has some internal drawables allocated, and the cached DCs gets removed and destroyed as soon as the window itself is, causing free_dce to be called with the user lock held already. Then opengl_drawable_release grabing the surfaces lock with the user lock held causes deadlocks with other threads creating or presenting surfaces which need to take the locks in the reverse order. Fixes: a085746bbe3594e4ea01ea578823383e6447b6b6 This is visible in several d2d/d3d tests timing out since that change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9544

1 1

Re: [PATCH v2 0/1] MR9410: urlmon: FindMimeFromData return only the mime type
by Jacek Caban (＠jacek) 20 Nov '25

20 Nov '25

Jacek Caban (@jacek) commented about dlls/urlmon/mimefilter.c: > > TRACE("found %s for %s\n", debugstr_w(ret), debugstr_an((const char*)buf, min(32, size))); > > - len = lstrlenW(ret)+1; > - *ret_mime = CoTaskMemAlloc(len*sizeof(WCHAR)); > + len = lstrlenW(ret); > + for(i = 0; i < len; i++) > + { > + if (ret[i] == ';') > + { > + len = i; > + break; > + } > + } ```suggestion:-8+0 len = wcsspn(ret, L";"); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9410#note_123131

1 0

Re: [PATCH v2 0/1] MR9410: urlmon: FindMimeFromData return only the mime type
by Jacek Caban (＠jacek) 20 Nov '25

20 Nov '25

Jacek Caban (@jacek) commented about dlls/urlmon/mimefilter.c: > + len = lstrlenW(ret); > + for(i = 0; i < len; i++) > + { > + if (ret[i] == ';') > + { > + len = i; > + break; > + } > + } > + > + *ret_mime = CoTaskMemAlloc((len+1)*sizeof(WCHAR)); > if(!*ret_mime) > return E_OUTOFMEMORY; > > memcpy(*ret_mime, ret, len*sizeof(WCHAR)); > + ((WCHAR*)(*ret_mime))[len] = 0; ```suggestion:-0+0 (*ret_mime)[len] = 0; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9410#note_123132

1 0

[PATCH v2 0/1] MR9516: jscript: Do existing prop lookups for external props only on objects with volatile props.
by Gabriel Ivăncescu 20 Nov '25

20 Nov '25

-- v2: jscript: Do existing prop lookups for external props only on objects with https://gitlab.winehq.org/wine/wine/-/merge_requests/9516

2 5

[PATCH 0/2] MR9543: msado15: Don't use row index in _Recordset::get_EditMode.
by Piotr Caban (＠piotr) 20 Nov '25

20 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9543

2 2

[PATCH v3 0/3] MR9526: win32u/tests: Test which Vulkan/GL/D3D graphics objects hold shared resource handles.
by Derek Lesho (＠dlesho) 20 Nov '25

20 Nov '25

In prep for my OpenGL shared resource series. The behavior there seems to be heavily driver-specific. -- v3: win32u/tests: Test shared handle lifetime. https://gitlab.winehq.org/wine/wine/-/merge_requests/9526

2 4