November 2025 - Wine-gitlab

Re: [PATCH v5 0/1] MR8988: win32u: change the stretch mode of dst hdc from BlackOnWhite to ColorOnColor... - approved
by Jinoh Kang (＠iamahuman) 04 Nov '25

04 Nov '25

This merge request was approved by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8988

1 0

[PATCH 0/1] MR9359: d3d9/tests: Fix value of stride passed to DrawPrimitiveUP (ASan).
by Bernhard Übelacker 04 Nov '25

04 Nov '25

Other calls to `d3d9_device_DrawPrimitiveUP` use just the size of one dimension of the `quad` array as parameter `stride`. Therefore using the size of the whole `quad` variable causes the function call with `D3DPT_TRIANGLESTRIP` and `primitive_count=2` to read "64 * (2+2) = 256 bytes" which overflows the allocated "64 bytes". [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=160603) <details> <summary>ASan report details</summary> ``` ================================================================= ==312==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0001401c8540 at pc 0x6ffffe8dc03b bp 0x7ffffe1fe930 sp 0x7ffffe1fe978 READ of size 256 at 0x0001401c8540 thread T0 #0 0x6ffffe8dc03a in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x6ffff97c7abb in wined3d_streaming_buffer_upload .../wine/dlls/wined3d/buffer.c:1438 #2 0x6ffffdd4519d in d3d9_device_DrawPrimitiveUP .../wine/dlls/d3d9/device.c:3345 #3 0x0001400b55f0 in clear_test .../wine/dlls/d3d9/tests/visual.c:1464 #4 0x0001400a900c in func_visual .../wine/dlls/d3d9/tests/visual.c:28886 #5 0x00014017ada2 in run_test .../wine/include/wine/test.h:768 #6 0x00014017a7ab in main .../wine/include/wine/test.h:888 #7 0x00014017ca7a in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #8 0x6fffffc67a74 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a74) #9 0x6fffffde06a6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506a6) 0x0001401c8540 is located 32 bytes before global variable '"Clear rectangle 3(pos, neg) has "...' defined in '.../wine/dlls/d3d9/tests/visual.c:1230' (0x0001401c8560) of size 44 '"Clear rectangle 3(pos, neg) has "...' is ascii string 'Clear rectangle 3(pos, neg) has color %08x ' 0x0001401c8540 is located 0 bytes after global variable 'clear_test.quad' defined in '.../wine/dlls/d3d9/tests/visual.c:1168' (0x0001401c8500) of size 64 SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/wined3d/buffer.c:1438 in wined3d_streaming_buffer_upload Shadow bytes around the buggy address: 0x0001401c8280: f9 f9 f9 f9 00 00 00 00 00 06 f9 f9 f9 f9 f9 f9 0x0001401c8300: 00 00 00 00 00 02 f9 f9 f9 f9 f9 f9 00 00 00 00 0x0001401c8380: 00 04 f9 f9 f9 f9 f9 f9 00 00 00 00 02 f9 f9 f9 0x0001401c8400: f9 f9 f9 f9 00 00 00 00 00 00 00 00 02 f9 f9 f9 0x0001401c8480: f9 f9 f9 f9 00 00 00 00 00 00 00 00 f9 f9 f9 f9 =>0x0001401c8500: 00 00 00 00 00 00 00 00[f9]f9 f9 f9 00 00 00 00 0x0001401c8580: 00 04 f9 f9 f9 f9 f9 f9 00 00 00 00 00 04 f9 f9 0x0001401c8600: f9 f9 f9 f9 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 0x0001401c8680: 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9 00 00 00 02 0x0001401c8700: f9 f9 f9 f9 00 00 00 02 f9 f9 f9 f9 00 00 00 02 0x0001401c8780: f9 f9 f9 f9 00 00 00 02 f9 f9 f9 f9 00 00 00 02 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9359

2 2

[PATCH v2 0/4] MR9296: dmsynth, dmusic: Reduce memory usage part 1
by Anton Baskanov (＠baskanov) 04 Nov '25

04 Nov '25

-- v2: dmsynth: Release the waves when voices finish playing. dmsynth: Implement callback support in synth_Unload(). dmsynth: Call fluid_sample_set_sound_data() with copy_data = FALSE. dmusic: Reuse downloaded waves. https://gitlab.winehq.org/wine/wine/-/merge_requests/9296

4 10

[PATCH 0/1] MR9353: opengl32: Take GL_CLIENT_STORAGE_BIT into account when picking vk memory type in create_buffer_storage.
by Jacek Caban (＠jacek) 04 Nov '25

04 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9353

3 2

[PATCH 0/1] MR9361: win32u: Dispatch to the KHR function pointer when appropriate.
by Rémi Bernon 04 Nov '25

04 Nov '25

Wine-Bug: http://bugs.winehq.org/show_bug.cgi?id=58918 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9361

1 1

[PATCH v2 0/1] MR9360: d3dx9_36/tests: Add end marker to the invalid tests (ASan).
by Bernhard Übelacker 04 Nov '25

04 Nov '25

This is to avoid reading beyond the input buffer in `get_shader_semantics`. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=160604) <details> <summary>ASan report details</summary> ``` ================================================================= ==1268==ERROR: AddressSanitizer: global-buffer-overflow on address 0x000140212064 at pc 0x6ffffad7854b bp 0x7ffffe1ff740 sp 0x7ffffe1ff788 READ of size 4 at 0x000140212064 thread T0 #0 0x6ffffad7854a in get_shader_semantics .../wine/dlls/d3dx9_36/shader.c:2842 #1 0x6ffffad77c3b in D3DXGetShaderInputSemantics .../wine/dlls/d3dx9_36/shader.c:3008 #2 0x0001400c9006 in test_shader_semantics .../wine/dlls/d3dx9_36/tests/shader.c:6754 #3 0x0001400c1925 in func_shader .../wine/dlls/d3dx9_36/tests/shader.c:6983 #4 0x000140127d92 in run_test .../wine/include/wine/test.h:768 #5 0x00014012779b in main .../wine/include/wine/test.h:888 #6 0x000140129a6a in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #7 0x6fffffc67a74 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a74) #8 0x6fffffde06a6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506a6) 0x000140212064 is located 60 bytes before global variable 'test_shader_semantics.vs_1_1' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6650' (0x0001402120a0) of size 116 0x000140212064 is located 28 bytes before global variable 'test_shader_semantics.invalid_3' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6646' (0x000140212080) of size 4 0x000140212064 is located 0 bytes after global variable 'test_shader_semantics.invalid_2' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6642' (0x000140212060) of size 4 SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/d3dx9_36/shader.c:2842 in get_shader_semantics Shadow bytes around the buggy address: 0x000140211d80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211e00: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211e80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211f00: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211f80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 =>0x000140212000: f9 f9 f9 f9 f9 f9 f9 f9 04 f9 f9 f9[04]f9 f9 f9 0x000140212080: 04 f9 f9 f9 00 00 00 00 00 00 00 00 00 00 00 00 0x000140212100: 00 00 04 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00 0x000140212180: 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 00 00 00 00 0x000140212200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000140212280: 00 00 00 04 f9 f9 f9 f9 00 00 00 00 f9 f9 f9 f9 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==1268==ABORTING ``` </details> -- v2: d3dx9_36/tests: Add end marker to the invalid tests (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/9360

1 3

[PATCH 0/1] MR9360: d3dx9_36/tests: Add end marker to the invalid tests (ASan).
by Bernhard Übelacker 04 Nov '25

04 Nov '25

This is to avoid reading beyond the intput buffer in `get_shader_semantics`. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=160604) <details> <summary>ASan report details</summary> ``` ================================================================= ==1268==ERROR: AddressSanitizer: global-buffer-overflow on address 0x000140212064 at pc 0x6ffffad7854b bp 0x7ffffe1ff740 sp 0x7ffffe1ff788 READ of size 4 at 0x000140212064 thread T0 #0 0x6ffffad7854a in get_shader_semantics .../wine/dlls/d3dx9_36/shader.c:2842 #1 0x6ffffad77c3b in D3DXGetShaderInputSemantics .../wine/dlls/d3dx9_36/shader.c:3008 #2 0x0001400c9006 in test_shader_semantics .../wine/dlls/d3dx9_36/tests/shader.c:6754 #3 0x0001400c1925 in func_shader .../wine/dlls/d3dx9_36/tests/shader.c:6983 #4 0x000140127d92 in run_test .../wine/include/wine/test.h:768 #5 0x00014012779b in main .../wine/include/wine/test.h:888 #6 0x000140129a6a in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #7 0x6fffffc67a74 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a74) #8 0x6fffffde06a6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506a6) 0x000140212064 is located 60 bytes before global variable 'test_shader_semantics.vs_1_1' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6650' (0x0001402120a0) of size 116 0x000140212064 is located 28 bytes before global variable 'test_shader_semantics.invalid_3' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6646' (0x000140212080) of size 4 0x000140212064 is located 0 bytes after global variable 'test_shader_semantics.invalid_2' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6642' (0x000140212060) of size 4 SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/d3dx9_36/shader.c:2842 in get_shader_semantics Shadow bytes around the buggy address: 0x000140211d80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211e00: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211e80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211f00: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211f80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 =>0x000140212000: f9 f9 f9 f9 f9 f9 f9 f9 04 f9 f9 f9[04]f9 f9 f9 0x000140212080: 04 f9 f9 f9 00 00 00 00 00 00 00 00 00 00 00 00 0x000140212100: 00 00 04 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00 0x000140212180: 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 00 00 00 00 0x000140212200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000140212280: 00 00 00 04 f9 f9 f9 f9 00 00 00 00 f9 f9 f9 f9 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==1268==ABORTING ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9360

2 3

[PATCH 0/2] MR9311: dwrite, win32u: Stop supporting very old FreeType versions.
by Brendan Shanks (＠bshanks) 04 Nov '25

04 Nov '25

The new requirement is v2.5.0 (released in June 2013). If we wanted to go farther, the next stop would be v2.8.1 (released September 2017). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9311

4 6

[PATCH v19 0/11] MR9209: vccorlib140: Implement Platform::Exceptions.
by Vibhav Pant (＠vibhavp) 04 Nov '25

04 Nov '25

-- v19: vccorlib140: Implement __abi_translateCurrentException. vccorlib140: Throw exceptions on error paths. vccorlib140: Add Platform::Exception::CreateException() implementation. vccorlib140: Add Platform::Exception::Message::get() implementation. vccorlib140: Add Platform::COMException constructor implementation. vccorlib140: Add Platform::Exception(HSTRING) constructor implementation. msvcrt: Sync cxx.h file with msvcp90 and vccorlib140. vccorlib140: Add Platform::Exception constructor implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/9209

5 15

[PATCH v3 0/4] MR9354: ntdll: Fix a couple of epilogue unwind issues on x64.
by Paul Gofman (＠gofman) 04 Nov '25

04 Nov '25

-- v3: ntdll: Handle 0xff jump opcode in epilogue unwind on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/9354

2 5