November 2025 - Wine-gitlab

[PATCH v2 0/4] MR9354: ntdll: Fix a couple of epilogue unwind issues on x64.
by Paul Gofman (＠gofman) 04 Nov '25

04 Nov '25

-- v2: ntdll: Handle 0xff jump opcode in epilogue unwind on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/9354

2 5

[PATCH v10 0/2] MR9351: msvcrt: Correctly handle refcounts for WinRT exceptions
by Vibhav Pant (＠vibhavp) 04 Nov '25

04 Nov '25

Follow up to https://gitlab.winehq.org/wine/wine/-/merge_requests/9209#note_120396 -- v10: ucrtbase: Add __C_specific_handler tests. msvcrt: Call the destructor for C++ exceptions in __C_specific_handler. https://gitlab.winehq.org/wine/wine/-/merge_requests/9351

4 3

[PATCH 0/1] MR9350: shell32: Fix a memory leak issue.
by Zhao Yi (＠Zhaoyi) 04 Nov '25

04 Nov '25

Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9350

2 2

Re: [PATCH v3 0/2] MR9287: uxtheme: Handle NULL options in DrawThemeTextEx().
by Zhiyi Zhang (＠zhiyi) 04 Nov '25

04 Nov '25

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > + hdc = GetDC(hwnd); > + SetRect(&rect, 0, 0, 1, 1); > + > + hr = DrawThemeTextEx(NULL, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == E_HANDLE, "Got unexpected hr %#lx.\n", hr); > + > + hr = DrawThemeTextEx(htheme, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); > + > + options.dwSize = sizeof(options); > + options.dwFlags = DTT_VALIDBITS; > + options.iFontPropId = TMT_BODYFONT; > + hr = DrawThemeTextEx(htheme, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, &options); > + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); > + > + options.crText = CLR_INVALID; Same here. You should specify DTT_TEXTCOLOR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9287#note_120702

1 0

Re: [PATCH v3 0/2] MR9287: uxtheme: Handle NULL options in DrawThemeTextEx().
by Zhiyi Zhang (＠zhiyi) 04 Nov '25

04 Nov '25

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > + skip("Theming is inactive.\n"); > + DestroyWindow(hwnd); > + return; > + } > + > + hdc = GetDC(hwnd); > + SetRect(&rect, 0, 0, 1, 1); > + > + hr = DrawThemeTextEx(NULL, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == E_HANDLE, "Got unexpected hr %#lx.\n", hr); > + > + hr = DrawThemeTextEx(htheme, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); > + > + options.dwSize = sizeof(options); > + options.dwFlags = DTT_VALIDBITS; You're not supposed to use DTT_VALIDBITS here. DTT_VALIDBITS means all member values are valid. See https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/ns-uxtheme-dtto…. You should specify DTT_FONTPROP here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9287#note_120701

1 0

Re: [PATCH v3 0/2] MR9287: uxtheme: Handle NULL options in DrawThemeTextEx().
by Zhiyi Zhang (＠zhiyi) 04 Nov '25

04 Nov '25

On Tue Nov 4 13:39:10 2025 +0000, Nikolay Sivov wrote: > Actually TMT_TEXTCOLOR looks fine, but TMT_FONT should probably be using TMT_GLYPHFONT. Actually, TMT_FONT is both a property type and a valid property ID. Yeah, I know. It's terrible. However, this can be confirmed with remarks from MSDN. For example, see https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-draw… The following code also shows that TMT_FONT is a valid property ID. You can see the lfFaceName is valid after the call whereas using TMT_GLYPHFONT is not. ``` { LOGFONTW logfont = {0}; htheme = OpenThemeData(NULL, WC_BUTTONW); hdc = GetDC(hwnd); hr = GetThemeFont(htheme, hdc, BP_COMMANDLINK, 0, TMT_FONT, &logfont); ok(hr == S_OK, "GetThemePartSize failed, hr %#lx.\n", hr); ok(0, "logfont.facename %s.\n", wine_dbgstr_w(logfont.lfFaceName)); } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9287#note_120700

1 0

[PATCH v9 0/2] MR9351: msvcrt: Correctly handle refcounts for WinRT exceptions
by Vibhav Pant (＠vibhavp) 04 Nov '25

04 Nov '25

Follow up to https://gitlab.winehq.org/wine/wine/-/merge_requests/9209#note_120396 -- v9: ucrtbase: Add __C_specific_handler tests. msvcrt: Call the destructor for C++ exceptions in __C_specific_handler. https://gitlab.winehq.org/wine/wine/-/merge_requests/9351

3 2

[PATCH v7 0/2] MR9351: msvcrt: Correctly handle refcounts for WinRT exceptions
by Vibhav Pant (＠vibhavp) 04 Nov '25

04 Nov '25

Follow up to https://gitlab.winehq.org/wine/wine/-/merge_requests/9209#note_120396 -- v7: ucrtbase: Add __C_specific_handler tests. msvcrt: Call the destructor for C++ exceptions in __C_specific_handler. https://gitlab.winehq.org/wine/wine/-/merge_requests/9351

4 4

[PATCH 0/8] MR9358: msado: Initial patches for internat IRowset implementation for storing data in memory.
by Piotr Caban (＠piotr) 04 Nov '25

04 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9358

2 8

[PATCH v3 0/2] MR9356: ntdll: Exclude SxS DLLs when finding a DLL with its base name.
by Zhiyi Zhang (＠zhiyi) 04 Nov '25

04 Nov '25

WinSxS DLLs are found via find_actctx_dll(). When activation contexts are inactive, GetModuleHandle() shouldn't find WinSxS DLLs with the same base name of a normal DLL. -- v3: ntdll: Exclude SxS DLLs when finding a DLL with its base name and no activation contexts. kernel32/tests: Add more GetModuleHandle() tests for WinSxS. https://gitlab.winehq.org/wine/wine/-/merge_requests/9356

2 2