February 2025 - Wine-gitlab

Re: [PATCH v2 0/1] MR7423: subst: Add basic implementation. - approved
by Alexandre Julliard (＠julliard) 25 Feb '25

25 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7423

1 0

Re: [PATCH v3 0/4] MR7381: imm32: Move the IME UI window to the bottom at creation. - approved
by Alexandre Julliard (＠julliard) 25 Feb '25

25 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7381

1 0

Re: [PATCH v2 0/1] MR7420: comctl32: Fix Alloc/HeapAlloc mismatches. - approved
by Alexandre Julliard (＠julliard) 25 Feb '25

25 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7420

1 0

[PATCH 0/2] MR7417: mfplat: Modify MFCreateWaveFormatExFromMFMediaType to allow MF_MT_AM_FORMAT_TYPE to be missing or set to GUID_NULL.
by Brendan McGrath (＠redmcg) 25 Feb '25

25 Feb '25

This MR: - adds tests for when MF_MT_AM_FORMAT_TYPE is missing or set to GUID_NULL; and - modifies MFCreateWaveFormatExFromMFMediaType to pass these tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7417

3 7

[PATCH 0/1] MR4662: properly track refcount and dependencies with forwarded exports.
by YUAN RUI (＠number201724) 25 Feb '25

25 Feb '25

fix: https://bugs.winehq.org/show_bug.cgi?id=52094 tests: ``` #include <Windows.h> #ifdef FROM_IMPORT #pragma comment(lib, "python3.lib") extern "C" int Py_IsInitialized(); #endif int main() { #ifdef FROM_IMPORT // test from import table Py_IsInitialized( ); #else // //Test ref count int (*Py_IsInitialized)(); HMODULE hmod_310 = LoadLibraryA( "C:\\Python310\\python310.dll" ); HMODULE hmod = LoadLibraryA( "C:\\Python310\\python3.dll" ); if ( !hmod ) return 0; *(FARPROC*)&Py_IsInitialized = GetProcAddress( hmod, "Py_IsInitialized" ); FreeLibrary( hmod_310 ); Py_IsInitialized( ); FreeLibrary( hmod ); // test dependencies hmod = LoadLibraryA( "C:\\Python310\\python3.dll" ); if ( !hmod ) return 0; *(FARPROC*)&Py_IsInitialized = GetProcAddress( hmod, "Py_IsInitialized" ); Py_IsInitialized(); FreeLibrary( hmod ); #endif return 0; } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4662

5 5

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Nikolay Sivov (＠nsivov) 25 Feb '25

25 Feb '25

On Tue Feb 25 20:23:00 2025 +0000, Stefan Brüns wrote: > @d1saster - Maybe you could extend the test so all 4 cases (2 fill > modes, intersecting/non-intersecting) are tested (marking the > ALTERNATE-intersecting one as known-fail). This isn't about percentage or how common it is. It's not clear this is the right direction to me, for example groups could contain path geometries with different filling modes, or other groups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95936

1 0

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Nikolay Sivov (＠nsivov) 25 Feb '25

25 Feb '25

This is included in wine-staging now, you could use that for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95935

1 0

[PATCH 0/3] MR3124: Move periodic registry save out of wineserver
by Paul Gofman (＠gofman) 25 Feb '25

25 Feb '25

The problem is that registry save is a very heavy operation (scheduled each 30sec in wineserver) during which server doesn't process any requests and the whole prefix is stalled for the duration of the operation. For some reference, the process takes from 50-100ms here up to 1-1.5sec with default initial registry (after some registry modifications which trigger actual registry flush), depending on the filesystem type and state (as huge time may be spent in file close / rename). With the same registry after this patchset the server part (flush_key returning the whole registry data) is taking ~4-5mcs, measured from the client side so that already includes data transfer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3124

5 9

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Stefan Brüns 25 Feb '25

25 Feb '25

On Tue Feb 25 20:20:12 2025 +0000, Stefan Brüns wrote: > I think the current implementation is only incorrect when the fill mode > is D2D1_FILL_MODE_ALTERNATE (0) (aka Even-Odd), but correct for > D2D1_FILL_MODE_WINDING (1). More specifically, when the fill mode is > ALTERNATE *and* there are intersections - for all of the other three > cases (WINDING with and without intersections, ALTERNATE without), it is correct. > According to my experience, even-odd fill mode is quite uncommon. Having > an implementation which is correct 99% of the time in real-world usage, > and leaving the remainder with an explicit, verbose FIXME is an > definitive improvement. Today, the result is always incorrect. @d1saster - Maybe you could extend the test so all 4 cases (2 fill modes, intersecting/non-intersecting) are tested (marking the ALTERNATE-intersecting one as known-fail). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95932

1 0

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Stefan Brüns 25 Feb '25

25 Feb '25

On Sat Sep 28 19:59:05 2024 +0000, Nikolay Sivov wrote: > It wouldn't consider it sufficient, it's clear that there is more to it > than copying data from individual geometries. So the question is the > same - what needs to be done to make it work properly, once it's > understood, we could implement it partially if it's too hard to do properly. I think the current implementation is only incorrect when the fill mode is D2D1_FILL_MODE_ALTERNATE (0) (aka Even-Odd), but correct for D2D1_FILL_MODE_WINDING (1). More specifically, when the fill mode is ALTERNATE *and* there are intersections - for all of the other three cases (WINDING with and without intersections, ALTERNATE without), it is correct. According to my experience, even-odd fill mode is quite uncommon. Having an implementation which is correct 99% of the time in real-world usage, and leaving the remainder with an explicit, verbose FIXME is an definitive improvement. Today, the result is always incorrect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95931

1 0