February 2025 - Wine-gitlab

[PATCH 0/7] MR7422: winebus/dinput: Support arbitrary number of axes in the virtual PID descriptor
by Tomasz Pakuła 25 Feb '25

25 Feb '25

Related Wine issue: https://bugs.winehq.org/show_bug.cgi?id=52714 I'm starting work on updating/extending Linux force feedback API and one of my goals is to expose the number and an array that contains the device's ffb-enabled axes. As I'm mainly working with USB PID driver, I already have a POC of obtaining this data. What prompted this is that currently Wine always creates virtual joysticks with two PID ffb axes. This causes issues with [Richard Burns Rally](https://github.com/ValveSoftware/Proton/issues/6702#issuecomment-267…, as this game incorrectly initializes a `CONSTANT_FORCE` effect with all the FFB axes that contain `DIDOI_FFACTUATOR` flag and then trying to update `cAxes` and `rgdwAxes` values which leads to `DIERR_INVALIDPARAM`. Now, this flag is set by wine while enumerating virtual device's axes and while `(axis index < FFB axes)`, flag is applied. This means, that every device which has FFB functionality and at least two axes, will report FFB on `X`, `Y`. While updated API would mean a lot of steering wheels would correctly report only 1 axis, a lot of USB PID wheels still include `X` and `Y` in their `AXES_ENABLE` and `DIRECTION` usages. This, again, would lead to broken FFB. On Windows, there's a possibility of overwriting some joystick capabilities with registry entries, which ends up removing `DIDOI_FFACTUATOR` flag from a selected axis. This doesn't work in Wine. This MR allows Wine to add an arbitrary number (up to `PID_AXES_MAX`) of axes to the PID descriptor, based on the value of Haptic Axes from SDL or from Linux FF api in the future (I'm working on it). Additionally, to work around RBR and other games with similar, wrong FFB handling, I introduced a [hint](https://github.com/libsdl-org/SDL/issues/12341) to SDL that allows a dynamic overwrite of the number of haptic axes. For the Linux API, I'll figure out a nice way to override when the number of axes will be exposed. With these changes, I was able to successfully get force feedback on my Moza Racing R9 with all axes usable. With additional traces in the dinput code, I confirmed that with one axis defined in the PID descriptor, the game created a constant force effect with just one axis and `cAxes = 1`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7422

1 7

[PATCH v5 0/1] MR5658: winevulkan: Make device memory wrapper available in callbacks.
by Arek Hiler (＠ivyl) 25 Feb '25

25 Feb '25

With [`VK_EXT_device_address_binding_report`](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_device_address_binding_report.html) we can get [debug_util](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/ht… callbacks used to track memory bindings. Since it's the host's implementation that starts the callback we have to be sure that we have a way of converting it to the client side's variant before it's added to the handle map - i.e. we don't know the host handle at that time yet. This is [used by vkd3d-proton](https://github.com/HansKristian-Work/vkd3d-proton/pull/1962). Requires Mesa with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28649 (24.3 is modern enough to have it). before (note the missing BIND for VkDevice which actually means `VkDeviceMemory`): ``` vkd3d-proton % WINEDLLOVERRIDES="d3d12=n;d3d12core=n" \ VKD3D_TEST_FILTER=create_placed_resource_size \ VKD3D_CONFIG=fault VKD3D_DEBUG=trace \ ~/build/wine/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800101600000 || size 000000000019a000. 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800101600000 || size 000000000019a000. 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800101600000 || size 0000000001000000. 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 6669.627:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800101600000 || size 0000000001000000 ``` after: ``` vkd3d-proton % WINEDLLOVERRIDES="d3d12=n;d3d12core=n" \ VKD3D_TEST_FILTER=create_placed_resource_size \ VKD3D_CONFIG=fault VKD3D_DEBUG=trace \ ~/build/wine/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800101600000 || size 0000000001000000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800101600000 || size 000000000019a000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800101600000 || size 000000000019a000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800101600000 || size 0000000001000000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800101600000 || size 0000000001000000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800101600000 || size 0000000001000000. 4015.597:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800101600000 || size 0000000001000000. ``` [The spec guarantees](https://registry.khronos.org/vulkan/specs/1.3-extensions/html/v… the following: > An application can receive multiple callbacks if multiple VkDebugUtilsMessengerEXT objects are created. A callback will always be executed in the same thread as the originating Vulkan call. -- v5: winevulkan: Make device memory wrapper available in callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/5658

2 1

Re: [PATCH v11 0/1] MR7400: cmd: Allow any key to continue past DIR /P pauses.
by eric pouech (＠epo) 25 Feb '25

25 Feb '25

On Tue Feb 25 08:50:37 2025 +0000, Joe Souza wrote: > Hmm. The changes in this merge request should affect only Ctrl-C at a > /P pause. Otherwise should behave the same. I will look at this later > today. Thanks. sorry, my post wasn't 100% clear: * run cmd with full blown console (./wine wineconsole cmd) * run 'dir /p /s \\\*' * pressing any key works (and pages output) * but ctrl-c doesn't stop dir /p as it should -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7400#note_95858

1 0

[PATCH 0/1] MR7420: comctl32: Fix Alloc/HeapAlloc mismatches.
by Haoyang Chen (＠chenhaoyang) 25 Feb '25

25 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7420

3 2

[PATCH v8 0/1] MR7400: cmd: Allow any key to continue past DIR /P pauses.
by Joe Souza (＠JoeS209) 25 Feb '25

25 Feb '25

Current code requires entering a newline character in order to continue past DIR /P prompts. This change allows any key to be pressed instead. Code to handle this was similar to existing WCMD_pause() so we leveraged that code for this purpose as well. Key to the fix was the removal of ENABLE_LINE_INPUT from the console flags, and ENABLE_PROCESSED_INPUT was added in order to preserve the ability to abort the operation via Ctrl-C. -- v8: cmd: Allow any key to continue past DIR /P pauses. https://gitlab.winehq.org/wine/wine/-/merge_requests/7400

3 4

[PATCH 0/1] MR7421: krnl386: Silence a warning in GetSystemDirectory16().
by Arek Hiler (＠ivyl) 25 Feb '25

25 Feb '25

``` With GCC 14.2 on Debian 11: $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 14.2.0 Copyright (C) 2024 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. The following error happens: In file included from ~/src/wine/dlls/krnl386.exe16/file.c:33: In function 'lstrcpyA', inlined from 'GetSystemDirectory16' at ~/src/wine/dlls/krnl386.exe16/file.c:648:9, inlined from 'get_search_path' at ~/src/wine/dlls/krnl386.exe16/file.c:192:12: ~/src/wine/include/winbase.h:2939:12: error: argument 1 null where non-null expected [-Werror=nonnull] 2939 | return strcpy( dst, src ); | ^~~~~~~~~~~~~~~~~~ In file included from ~/src/wine/dlls/krnl386.exe16/file.c:28: ~/src/wine/include/msvcrt/string.h: In function 'get_search_path': ~/src/wine/include/msvcrt/string.h:53:26: note: in a call to function 'strcpy' declared 'nonnull' 53 | _ACRTIMP char* __cdecl strcpy(char*,const char*); | ^~~~~~ In function 'lstrcatA', inlined from 'GetSystemDirectory16' at ~/src/wine/dlls/krnl386.exe16/file.c:649:9, inlined from 'get_search_path' at ~/src/wine/dlls/krnl386.exe16/file.c:192:12: ~/src/wine/include/winbase.h:2952:12: error: argument 1 null where non-null expected [-Werror=nonnull] 2952 | return strcat( dst, src ); | ^~~~~~~~~~~~~~~~~~ ~/src/wine/include/winbase.h:2952:12: note: in a call to built-in function '__builtin_strlen' (built using --with-mingw and --enable-werror to turn it into an error) The warning doesn't really matter as get_search_path() calls GetSystemDirectory16(NULL, 0) to get the size for allocation. `if (count >= len)` in the latter saves us from ever atempting to strcpy() onto NULL, but the compiler is not smart enough to figure out that len will be greater than 0. This change mimics kernel32's GetSystemDirectoryW(). ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7421

2 1

[PATCH 0/1] MR7323: wininet: Treat Expires value "-1" the same as "0"
by Yongjie Yao (＠yaoyongjie) 25 Feb '25

25 Feb '25

fix "err:wininet:HTTP_ParseDateAsAsctime unexpected weekday L"-1"" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7323

2 2

[PATCH v7 0/2] MR7324: Use Microsoft provided coefficients for YUV to RGB conversion.
by Brendan McGrath (＠redmcg) 25 Feb '25

25 Feb '25

The current YUV to RGB conversion provides values in studio-range [16-235], but full-range is required [0-255]. As a result, we currently write the value of 16 to represent black, and so we get gray instead. This MR changes the coefficients used in the conversion so that the resultant output is in full-range. It actually uses two sets of coefficients as these differ between SD and HD. Also included is a number of Direct Draw 7 tests. The coefficients used are documented here: https://learn.microsoft.com/en-us/windows/win32/medfound/recommended-8-bit-… -- v7: wined3d: Use Microsoft provided coefficients for YUV to RGB conversion. ddraw/tests: Test yuv to rgb blt in ddraw7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7324

2 4

[PATCH v2 0/4] MR7381: imm32: Move the IME UI window to the bottom at creation.
by Zhiyi Zhang (＠zhiyi) 25 Feb '25

25 Feb '25

Tidy Cauldron (2708320), a Unity game, uses EnumWindows() to find the first window in the current thread and maximizes the window when changing to windowed mode. However, before this patch, the IME UI window and the DXGI fallback device window are on top of the game window at creation and thus they could get maximized instead. This causes the game window to lose focus and freeze. -- v2: dxgi: Move the fallback device window to the bottom at creation. d3d11/tests: Test that the fallback device window shouldn't be above normal windows at creation. imm32: Move the IME UI window to the bottom at creation. imm32/tests: Test that the IME UI window shouldn't be above normal windows at creation. https://gitlab.winehq.org/wine/wine/-/merge_requests/7381

4 7

Re: [PATCH v4 0/1] MR7221: ieframe: Add IShellWindows stub implementation.
by Helix Graziani (＠TornadoCookie) 24 Feb '25

24 Feb '25

On Tue Feb 4 14:36:04 2025 +0000, Jacek Caban wrote: > I think it's because we register it in a wrong way, see > `HKEY_CLASSES_ROOT\CLSID\{9BA05972-F6A8-11CF-A442-00A0C90A8F39}`. On > Wine, it contains `InprocServer32` key, while on Windows it uses > `LocalServer32`. We should probably remove `threading()` attribute from > `ShellWindows` coclass in `exdisp.idl` and have `.rgs` file in shell > registering it manually. Interesting. I'll try using the values from Windows and seeing what it does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7221#note_95821

1 0