February 2025 - Wine-gitlab

Re: [PATCH v2 0/2] MR7392: server: Add an epoll_pwait2 path for server_main_loop if supported.
by William Horvath (＠whrvt) 20 Feb '25

20 Feb '25

On Thu Feb 20 21:41:59 2025 +0000, Paul Gofman wrote: > On Windows sleep / timer resolution is 16ms by default however. That can > be changed systemwide with NtSetTimerResolution() / > winmm.timeBeginPeriod and AFAIK (didn't test that myself) 0.5ms is the > best supported resolution (only available through NtSetTimerResolution). > So it is interesting what the game does exactly, which sort of delays or > waits affect the performance and how that works on Windows. > Just making sleep precision as good as possible might instead negatively > affact the performance in some other games. Well, for one, I'd like to see an example of a real game that doesn't call timeBeginPeriod(1), but that's besides the point. We already simulate a 1ms timer period by having the tick count increase every millisecond, and this is absolutely not intended to change that. What this is addressing is unrelated server calls from other threads pushing the **global** `current_time` and `monotonic_time` (updated each timeout) forward. That causes the timeouts for alertable `SleepEx` (used in those games' frame limiters) to expire for up to 1ms from that last update, as it's ceil'd to the next millisecond to avoid spinning with a 0 timeout. This causes, on average, an additional 0.5ms waited, depending on where we land on the tick boundary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7392#note_95431

1 0

[PATCH v2 0/2] MR7365: gdiplus: Add support for more image color formats.
by Dmitry Timoshkov (＠dmitry) 20 Feb '25

20 Feb '25

-- v2: gdiplus/tests: Add some tests for loading TIFF images in various color formats. gdiplus: Add support for more image color formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/7365

3 5

Re: [PATCH v2 0/2] MR7392: server: Add an epoll_pwait2 path for server_main_loop if supported.
by Paul Gofman (＠gofman) 20 Feb '25

20 Feb '25

On Windows sleep / timer resolution is 16ms by default however. That can be changed systemwide with NtSetTimerResolution() / winmm.timeBeginPeriod and AFAIK (didn't test that myself) 0.5ms is the best supported resolution (only available through NtSetTimerResolution). So it is interesting what the game does exactly, which sort of delays or waits affect the performance and how that works on Windows. Just making sleep precision as good as possible might instead negatively affact the performance in some other games. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7392#note_95428

1 0

[PATCH 0/1] MR7371: makefiles: Handle absolute path in create_dir() due to --with-wine64=(absolute path).
by Jinoh Kang (＠iamahuman) 20 Feb '25

20 Feb '25

Since commit 7620f21ff98 (makefiles: Generate the wow64 symlinks from makedep., 2025-02-18), makedep generates a symlink target for "<wine64_dir>/loader-wow64". This causes <wine64-dir> to be added as an "ignore path," ultimately leading to create_file_directories() and then create_dir(). create_dir() only expects relative paths. If it's passed an absolute path, it will recognize the "/" prefix as an empty path component followed by slash, and will attempt to mkdir(""), which fails. Fix this by skipping initial slashes in create_dir(). Fixes: 7620f21ff98a85249b0b110bcba9953b32763f28 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7371

3 3

[PATCH v2 0/4] MR7375: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND
by Edward OC (＠funfunctor) 20 Feb '25

20 Feb '25

Trivial, small set of cleanups patches to start with, non-controversial and NOP functionally speaking. These are to help get the review process going in making ways towards the bar being lowered for contributing to the oleaut32 implementation. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v2: dlls/oleaut32: Fix ITypeLib2_Constructor_SLTG() regression dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND https://gitlab.winehq.org/wine/wine/-/merge_requests/7375

2 4

Re: [PATCH v2 0/2] MR7392: server: Add an epoll_pwait2 path for server_main_loop if supported.
by William Horvath (＠whrvt) 20 Feb '25

20 Feb '25

Just fixed a forward decl. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7392#note_95422

1 0

[PATCH 0/2] MR7392: server: Add an epoll_pwait2 path for server_main_loop if supported.
by William Horvath (＠whrvt) 20 Feb '25

20 Feb '25

This mitigates a side effect of the global current_time and monotonic_time being updated on every server call's timeout, where the end time of any unrelated server call is moved into the future (depending on the frequency of server calls). By using a more granular timeout, the overall frequency of server calls doesn't have as great of an effect on each individual timeout, as we don't have to wait for an entire millisecond (which was due to the ceiling operation in get_next_timeout). This [issue](https://bugs.winehq.org/show_bug.cgi?id=57849) gives a few examples of this causing significant degradation in the behavior of some games, which use alertable (server) waits for their FPS limiter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7392

4 4

[PATCH 0/5] MR7391: winebth.sys part 4: Implement IOCTL_BTH_GET_DEVICE_INFO.
by Vibhav Pant (＠vibhavp) 20 Feb '25

20 Feb '25

This MR introduces an initial implementation for `IOCTL_BTH_GET_DEVICE_INFO` which returns a list of known/cached devices by BlueZ. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7391

2 5

[PATCH 0/1] MR7390: po: update Polish translation
by Adam Markowski (＠AMark) 20 Feb '25

20 Feb '25

Updates and fixes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7390

2 1

[PATCH v3 0/1] MR7363: http.sys: Avoid crashes in complete_irp() if http header value is space
by Wei Xie (＠wayne) 20 Feb '25

20 Feb '25

The value_len returned by the parse_header function may be less than 0 -- v3: http.sys: Avoid crashes in complete_irp() if http header value is space https://gitlab.winehq.org/wine/wine/-/merge_requests/7363

3 3