February 2025 - Wine-gitlab

Re: [PATCH v9 0/2] MR5238: krnl386, mmsystem: Simulate a hardware interrupt in MMSYSTDRV_Callback3216. - approved
by Alexandre Julliard (＠julliard) 20 Feb '25

20 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5238

1 0

Re: [PATCH v2 0/1] MR7380: oleaut32: Make OleLoadPicture load DIBs using WIC decoder. - approved
by Alexandre Julliard (＠julliard) 20 Feb '25

20 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7380

1 0

Re: [PATCH v2 0/1] MR7379: winebth.sys: Fix refcount leak while updating properties for a local radio. - approved
by Alexandre Julliard (＠julliard) 20 Feb '25

20 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7379

1 0

[PATCH v15 0/8] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 20 Feb '25

20 Feb '25

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. For reference, here's how current_modref is being passed around (before this patch): ```mermaid graph TB fii["fixup_imports_ilonly (directly sets current_modref)"] fi["fixup_imports (directly sets current_modref)"] pa["process_attach (directly sets current_modref)"] ld[load_dll] id["import_dll (directly uses current_modref)"] bin["build_import_name (directly uses current_modref)"] foe["find_ordinal_export (uses current_modref for relay)"] ffe["find_forwarded_export (directly uses current_modref)"] fne[find_named_export] MI[MODULE_InitDLL] fii --> ld fi --> id pa --> MI -.-> DllMain id --> bin id --> ld id --> foe id --> fne --> foe --> ffe --> foe ffe --> fne ffe --> bin style DllMain color:red; ``` -- v15: ntdll: Remove superflous NULL check for importer. ntdll: Properly track refcount on dynamic imports of export forwarders. ntdll: Explicitly ignore dynamic (GetProcAddress) importers as relay/snoop user module. ntdll: Eagerly call process_attach() on dynamic imports of export forwarders. ntdll: Properly track refcount on static imports of export forwarders. ntdll: Register module dependency for export forwarders regardless of whether the dependency is already loaded. ntdll: Don't re-add a module dependency if it already exists. ntdll: Sink module dependency registration towards the end of the https://gitlab.winehq.org/wine/wine/-/merge_requests/7

3 10

Re: [PATCH v2 0/2] MR7392: server: Add an epoll_pwait2 path for server_main_loop if supported.
by William Horvath (＠whrvt) 20 Feb '25

20 Feb '25

On Thu Feb 20 21:41:59 2025 +0000, Paul Gofman wrote: > On Windows sleep / timer resolution is 16ms by default however. That can > be changed systemwide with NtSetTimerResolution() / > winmm.timeBeginPeriod and AFAIK (didn't test that myself) 0.5ms is the > best supported resolution (only available through NtSetTimerResolution). > So it is interesting what the game does exactly, which sort of delays or > waits affect the performance and how that works on Windows. > Just making sleep precision as good as possible might instead negatively > affact the performance in some other games. Well, for one, I'd like to see an example of a real game that doesn't call timeBeginPeriod(1), but that's besides the point. We already simulate a 1ms timer period by having the tick count increase every millisecond, and this is absolutely not intended to change that. What this is addressing is unrelated server calls from other threads pushing the **global** `current_time` and `monotonic_time` (updated each timeout) forward. That causes the timeouts for alertable `SleepEx` (used in those games' frame limiters) to expire for up to 1ms from that last update, as it's ceil'd to the next millisecond to avoid spinning with a 0 timeout. This causes, on average, an additional 0.5ms waited, depending on where we land on the tick boundary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7392#note_95431

1 0

[PATCH v2 0/2] MR7365: gdiplus: Add support for more image color formats.
by Dmitry Timoshkov (＠dmitry) 20 Feb '25

20 Feb '25

-- v2: gdiplus/tests: Add some tests for loading TIFF images in various color formats. gdiplus: Add support for more image color formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/7365

3 5

Re: [PATCH v2 0/2] MR7392: server: Add an epoll_pwait2 path for server_main_loop if supported.
by Paul Gofman (＠gofman) 20 Feb '25

20 Feb '25

On Windows sleep / timer resolution is 16ms by default however. That can be changed systemwide with NtSetTimerResolution() / winmm.timeBeginPeriod and AFAIK (didn't test that myself) 0.5ms is the best supported resolution (only available through NtSetTimerResolution). So it is interesting what the game does exactly, which sort of delays or waits affect the performance and how that works on Windows. Just making sleep precision as good as possible might instead negatively affact the performance in some other games. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7392#note_95428

1 0

[PATCH 0/1] MR7371: makefiles: Handle absolute path in create_dir() due to --with-wine64=(absolute path).
by Jinoh Kang (＠iamahuman) 20 Feb '25

20 Feb '25

Since commit 7620f21ff98 (makefiles: Generate the wow64 symlinks from makedep., 2025-02-18), makedep generates a symlink target for "<wine64_dir>/loader-wow64". This causes <wine64-dir> to be added as an "ignore path," ultimately leading to create_file_directories() and then create_dir(). create_dir() only expects relative paths. If it's passed an absolute path, it will recognize the "/" prefix as an empty path component followed by slash, and will attempt to mkdir(""), which fails. Fix this by skipping initial slashes in create_dir(). Fixes: 7620f21ff98a85249b0b110bcba9953b32763f28 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7371

3 3

[PATCH v2 0/4] MR7375: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND
by Edward OC (＠funfunctor) 20 Feb '25

20 Feb '25

Trivial, small set of cleanups patches to start with, non-controversial and NOP functionally speaking. These are to help get the review process going in making ways towards the bar being lowered for contributing to the oleaut32 implementation. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v2: dlls/oleaut32: Fix ITypeLib2_Constructor_SLTG() regression dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND https://gitlab.winehq.org/wine/wine/-/merge_requests/7375

2 4

Re: [PATCH v2 0/2] MR7392: server: Add an epoll_pwait2 path for server_main_loop if supported.
by William Horvath (＠whrvt) 20 Feb '25

20 Feb '25

Just fixed a forward decl. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7392#note_95422

1 0