February 2025 - Wine-gitlab

[PATCH v5 0/4] MR7173: rtworkq: Support putting work on RTWQ_CALLBACK_QUEUE_UNDEFINED.
by Conor McCarthy (＠cmccarthy) 20 Feb '25

20 Feb '25

-- v5: rtworkq: Support putting work on any id in RTWQ_CALLBACK_QUEUE_PRIVATE_MASK. rtworkq: Support putting work on RTWQ_CALLBACK_QUEUE_UNDEFINED. rtworkq/tests: Test putting work on an undefined queue id. mfplat/tests: Test putting work on an undefined queue id. https://gitlab.winehq.org/wine/wine/-/merge_requests/7173

3 5

Re: [PATCH v2 0/1] MR7363: http.sys: Avoid crashes in complete_irp() if http header value is space
by Wei Xie (＠wayne) 20 Feb '25

20 Feb '25

You are right. `while (p > *value && isspace(p) --p;` will lost a character of the value, such as `{'F', 'r', 'o', 'm', ' ', ' ', '\r', ' ', 'v', '\r', '\0'}`. This is a test string with value_len less than 0, `{'F', 'r', 'o', 'm', ' ', ' ', '\r', ' ', '\r', '\n', '\0'}` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7363#note_95338

1 0

[PATCH v2 0/1] MR7374: wine.inf: Add VC runtime version key.
by Bernhard Kölbl 20 Feb '25

20 Feb '25

The Unreal engine bootstrapper relies on this to detect VC presence since version 5.3. -- v2: wine.inf: Add VC runtime version key. https://gitlab.winehq.org/wine/wine/-/merge_requests/7374

1 2

[PATCH v7 0/12] MR7174: rtworkq: Fix handling of platform startup and lock counts.
by Conor McCarthy (＠cmccarthy) 20 Feb '25

20 Feb '25

Startup and lock counts in native Windows are separate, and the lock count does not decrease when an async result is freed if the platform has been started. -- v7: rtworkq: Do not cancel pending callbacks when closing a thread pool. rtworkq/tests: Test queue shutdown with pending items. rtworkq/tests: Test scheduled items. mfplat/tests: Check for async result release after canceling work and shutting down. mfplat/tests: Release callback2 in test_event_queue(). mfplat: Free the inner cookie passed to resolver_create_cancel_object(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7174

3 15

[PATCH v13 0/7] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 20 Feb '25

20 Feb '25

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. For reference, here's how current_modref is being passed around (before this patch): ```mermaid graph TB fii["fixup_imports_ilonly (directly sets current_modref)"] fi["fixup_imports (directly sets current_modref)"] pa["process_attach (directly sets current_modref)"] ld[load_dll] id["import_dll (directly uses current_modref)"] bin["build_import_name (directly uses current_modref)"] foe["find_ordinal_export (uses current_modref for relay)"] ffe["find_forwarded_export (directly uses current_modref)"] fne[find_named_export] MI[MODULE_InitDLL] fii --> ld fi --> id pa --> MI -.-> DllMain id --> bin id --> ld id --> foe id --> fne --> foe --> ffe --> foe ffe --> fne ffe --> bin style DllMain color:red; ``` -- v13: ntdll: Remove superflous NULL check for importer. ntdll: Properly track refcount on dynamic imports of export forwarders. ntdll: Explicitly ignore dynamic (GetProcAddress) importers as relay/snoop user module. ntdll: Properly track refcount on static imports of export forwarders. ntdll: Register module dependency for export forwarders regardless of whether the dependency is already loaded. ntdll: Don't re-add a module dependency if it already exists. ntdll: Register module dependency for export forwarders only after successful resolution. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

3 18

[PATCH 0/2] MR7383: oleaut32: Add missing fixup for SLTG typename offset.
by Dmitry Timoshkov (＠dmitry) 20 Feb '25

20 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7383

3 8

[PATCH 0/1] MR7384: winetest: Ignore success and color codes in tests output limit.
by Rémi Bernon 20 Feb '25

20 Feb '25

Succeeding tests are printed out because we use elapsed time for JUnit test reports timings. Color codes are added on Gitlab MR only. Both are currently counting toward the test output threshold and they cause some ws2_32 and ieframe test failures on Gitlab MR when the tests are still under the threshold otherwise, as the nightly tests success can attest. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7384

1 1

[PATCH v2 0/1] MR7300: win32u: WM_MOUSEWHEEL message should be sent to a focus window.
by Dmitry Timoshkov (＠dmitry) 20 Feb '25

20 Feb '25

-- v2: server: Add support for merging WM_MOUSEWHEEL messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/7300

3 10

Re: [PATCH v3 0/5] MR7334: oleaut32: Fix logic for deciding whether type description follows the name.
by Dmitry Timoshkov (＠dmitry) 20 Feb '25

20 Feb '25

On Thu Feb 20 10:50:51 2025 +0000, Rémi Bernon wrote: > 12c79c33a1d9c790201fe3631238c9277424771f broke some vbscript:vbscript > and jscript:jscript tests. Thanks! For some reason CI didn't catch this. Should be fixed by https://gitlab.winehq.org/wine/wine/-/merge_requests/7383 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7334#note_95314

1 0

[PATCH 0/2] MR7382: server: Add support for merging WM_MOUSEWHEEL messages.
by Rémi Bernon 20 Feb '25

20 Feb '25

Superseding https://gitlab.winehq.org/wine/wine/-/merge_requests/7300 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7382

2 3