February 2025 - Wine-gitlab

[PATCH v23 0/27] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 14 Feb '25

14 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v23: dlls/oleaut32: Cleanup IType__Impl_Constructor()s dlls/oleaut32: Bound ITypeLib2_Constructor_SLTG() loop dlls/oleaut32/connpt.c: Make consistent and validate args dlls/oleaut32: Add missing IID case in ITypeLib2::QueryInterface() dlls/oleaut32: Validate TLB_QueryInterface() params dlls/oleaut32: Fix QueryInterface() to meet spec dlls/shell32: Fix IUnknown::QueryInterface() to meet spec dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface dlls/oleaut32: Validate arguments in ITypeComp interface dlls/oleaut32: Consistently use TLB_get_bstr() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Avoid ptr arithmetic in MSFT_DoVars() dlls/oleaut32: Avoid ptr arithmetic in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Shink down ITypeLibComp_fnBind() verbosity some dlls/oleaut32: ptr_size should be a ULONG dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() dlls/oleaut32: Factor out TLB_get_funcdesc_by_name() dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use consistent param identifiers in fnFindName dlls/oleaut32: Mostly mirror fnFindName impl in typelib.c dlls/oleaut32: Use common and correct identifiers in typelib.c dlls/oleaut32: Consistently use lstrcmpiW() while looking for names This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

Re: [PATCH v3 0/2] MR7224: wbemprox: Implement Win32_PnPEntity.Service.
by Shmerl (＠shmerl) 14 Feb '25

14 Feb '25

FYI, this somehow broke Cyberpunk 2077 + CyberEngine Tweaks. I.e. with CET, it hangs on startup after this commit. See: https://bugs.winehq.org/show_bug.cgi?id=57834 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7224#note_94529

1 0

[PATCH 0/10] MR7329: windowscodecs/tests: Add some query tests with the Unknown reader.
by Nikolay Sivov (＠nsivov) 14 Feb '25

14 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7329

3 14

Re: [PATCH v3 0/4] MR7308: windows.storage: Add error handling in IRandomAccessStreamReferenceStatics::CreateFromStream().
by Mohamad Al-Jaf (＠maljaf) 13 Feb '25

13 Feb '25

Sure, updated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7308#note_94513

1 0

Re: [PATCH v13 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 13 Feb '25

13 Feb '25

@epo I've rebased this to keep it up to date, should I ping someone (or assign someone to the MR) to get this merged in? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_94511

1 0

Re: [PATCH v2 0/1] MR7326: advapi32/tests: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 13 Feb '25

13 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7326

1 0

Re: [PATCH v2 0/1] MR7327: sort: Support /+n option. - approved
by Alexandre Julliard (＠julliard) 13 Feb '25

13 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7327

1 0

Re: [PATCH v3 0/2] MR7325: include: Add IWiaDevMgr2 definition in wia_lh.idl. - approved
by Alexandre Julliard (＠julliard) 13 Feb '25

13 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7325

1 0

Re: [PATCH v2 0/2] MR7328: winebuild: Avoid using .idata section for delay-load import libraries. - approved
by Alexandre Julliard (＠julliard) 13 Feb '25

13 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7328

1 0

Re: [PATCH v2 0/4] MR7319: comctl32: Beginning of SysLink IAccessible implementation. - approved
by Alexandre Julliard (＠julliard) 13 Feb '25

13 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7319

1 0