February 2025 - Wine-gitlab

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Brian Wright (＠PennRobotics) 13 Feb '25

13 Feb '25

On Thu Feb 13 12:40:06 2025 +0000, Brian Wright wrote: > I've updated the [bug > report](https://bugs.winehq.org/show_bug.cgi?id=57603) with some debug > logs from 10.1 including `+x11drv,+event,+cursor,+win,+hid` if this helps. @rbernon On the client side, if you wanted to know why the log produces the values it has or had advice on code changes, the relevant file seems to be [yabridge/src/wine-host/editor.cpp](https://github.com/robbert-vdh/yabridge/… and a few routines responsible for coords and mouse handling that might be indirectly showing up in the bug report log include **is_cursor_in_wine_window** (line 1442), **get_current_pointer_position** (line 953), **fix_local_coordinates** (line 785), and `case XCB_CONFIGURE_NOTIFY` (line 552) I can attach to Wine and/or yabridge in a debugger, but I wouldn't have advice on what to change since I don't know how the handle relationships should look in order to find out which routine is producing incorrect coordinate offsets. If you want me to try anyway, I can put it in the queue of all the other stuff I forget to do once the workday is over. Thanks to you and @robbert-vdh for maintaining two phenomenal tools. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_94461

1 0

[PATCH 0/4] MR7319: comctl32: Beginning of SysLink IAccessible implementation.
by Esme Povirk (＠madewokherd) 13 Feb '25

13 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7319

3 10

[PATCH 0/1] MR7320: wbemprox: Increase buffer size one iteration earlier (ASan).
by Bernhard Übelacker 13 Feb '25

13 Feb '25

This was the ASan output before: ``` $ ASAN_OPTIONS="allocator_may_return_null=1:halt_on_error=0:strict_memcmp=0:log_path=\"c:\\asan_$(date +%Y-%m-%d_%H-%M-%S)_\":log_exe_name=1" make dlls/wbemprox/tests/x86_64-windows/query.ok $ cat asan_2025-02-12_23-46-45_.wbemprox_test.exe.296 ================================================================= ==wbemprox_test.exe==296==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f8338af4c80 at pc 0x6ffffdf98e18 bp 0x7ffffe1fec00 sp 0x7ffffe1fec48 WRITE of size 8 at 0x7f8338af4c80 thread T0 #0 0x6ffffdf98e17 in get_pnp_entities ...\wine\dlls\wbemprox\builtin.c:3313 #1 0x6ffffdf8a53c in fill_pnpentity ...\wine\dlls\wbemprox\builtin.c:3365 #2 0x6ffffdfa67f4 in exec_select_view ...\wine\dlls\wbemprox\query.c:708 #3 0x6ffffdfa60ce in execute_view ...\wine\dlls\wbemprox\query.c:746 #4 0x6ffffdfa6eba in exec_query ...\wine\dlls\wbemprox\query.c:795 #5 0x6ffffdfb4aed in create_instance_enum ...\wine\dlls\wbemprox\services.c:495 #6 0x6ffffdfb696b in wbem_services_CreateInstanceEnum ...\wine\dlls\wbemprox\services.c:687 #7 0x0001400126a4 in IWbemServices_CreateInstanceEnum ...\wine-build\build-asan-pe\64\obj\include\wbemcli.h:1396 #8 0x000140009d3a in test_Win32_PnPEntity ...\wine\dlls\wbemprox\tests\query.c:1992 #9 0x0001400014c9 in func_query ...\wine\dlls\wbemprox\tests\query.c:2493 #10 0x000140016eee in run_test+0xae (...\wine-build\build-asan-pe\64\obj\dlls\wbemprox\tests\x86_64-windows\wbemprox_test.exe+0x140016eee) #11 0x000140016a31 in main+0x471 (...\wine-build\build-asan-pe\64\obj\dlls\wbemprox\tests\x86_64-windows\wbemprox_test.exe+0x140016a31) #12 0x0001400183a3 in mainCRTStartup ...\wine\dlls\msvcrt\crt_main.c:58 #13 0x6fffffc4555e in BaseThreadInitThunk ...\wine\dlls\kernel32\thread.c:61 #14 0x6fffffdcb3da (C:\windows\system32\ntdll.dll+0x17004b3da) 0x7f8338af4c80 is located 0 bytes after 768-byte region [0x7f8338af4980,0x7f8338af4c80) allocated by thread T0 here: #0 0x6ffffe5f4711 in malloc+0x81 (C:\windows\system32\libclang_rt.asan_dynamic-x86_64.dll+0x180044711) #1 0x6ffffdf9845e in get_pnp_entities ...\wine\dlls\wbemprox\builtin.c:3295 #2 0x6ffffdf8a53c in fill_pnpentity ...\wine\dlls\wbemprox\builtin.c:3365 #3 0x6ffffdfa67f4 in exec_select_view ...\wine\dlls\wbemprox\query.c:708 #4 0x6ffffdfa60ce in execute_view ...\wine\dlls\wbemprox\query.c:746 #5 0x6ffffdfa6eba in exec_query ...\wine\dlls\wbemprox\query.c:795 #6 0x6ffffdfb4aed in create_instance_enum ...\wine\dlls\wbemprox\services.c:495 #7 0x6ffffdfb696b in wbem_services_CreateInstanceEnum ...\wine\dlls\wbemprox\services.c:687 #8 0x0001400126a4 in IWbemServices_CreateInstanceEnum ...\wine-build\build-asan-pe\64\obj\include\wbemcli.h:1396 #9 0x000140009d3a in test_Win32_PnPEntity ...\wine\dlls\wbemprox\tests\query.c:1992 #10 0x0001400014c9 in func_query ...\wine\dlls\wbemprox\tests\query.c:2493 #11 0x000140016eee in run_test+0xae (...\wine-build\build-asan-pe\64\obj\dlls\wbemprox\tests\x86_64-windows\wbemprox_test.exe+0x140016eee) #12 0x000140016a31 in main+0x471 (...\wine-build\build-asan-pe\64\obj\dlls\wbemprox\tests\x86_64-windows\wbemprox_test.exe+0x140016a31) #13 0x0001400183a3 in mainCRTStartup ...\wine\dlls\msvcrt\crt_main.c:58 #14 0x6fffffc4555e in BaseThreadInitThunk ...\wine\dlls\kernel32\thread.c:61 #15 0x6fffffdcb3da (C:\windows\system32\ntdll.dll+0x17004b3da) SUMMARY: AddressSanitizer: heap-buffer-overflow ...\wine\dlls\wbemprox\builtin.c:3313 in get_pnp_entities Shadow bytes around the buggy address: 0x7f8338af4a00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f8338af4a80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f8338af4b00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f8338af4b80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7f8338af4c00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x7f8338af4c80:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x7f8338af4d00: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f8338af4d80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f8338af4e00: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f8338af4e80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x7f8338af4f00: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==wbemprox_test.exe==296==ABORTING ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7320

2 3

[PATCH 0/2] MR7328: winebuild: Avoid using .idata section for delay-load import libraries.
by Jacek Caban (＠jacek) 13 Feb '25

13 Feb '25

Recent binutils changes merge .idata sections into the read-only .rdata section. This is intended to make the IAT read-only, as with other modern linkers, but as a side effect, it broke delay-load import libraries. Delay-load import libraries should use separate sections regardless. Since these new sections are not recognized by the linker, it won’t apply special handling to maintain proper sorting. In practice, this isn’t an issue as long as the name table and IAT maintain the same order. This may result in negative IAT offsets (if the base symbol ends up in the middle of the IAT), but Windows appears to handle this without issues. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57819 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7328

2 2

[PATCH v2 0/2] MR7325: include: Add IWiaDevMgr2 definition in wia_lh.idl.
by Biswapriyo Nath (＠Biswa96) 13 Feb '25

13 Feb '25

Required for https://github.com/msys2/MINGW-packages/issues/17451 Previous attempt !3025 -- v2: include: Add missing structures for wiadef.h in wia_lh.idl. include: Add IWiaDevMgr2 definition in wia_lh.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/7325

2 2

[PATCH v3 0/3] MR7241: winewayland: Basic input method support.
by Attila Fidan (＠atticf) 13 Feb '25

13 Feb '25

This MR tries to implement the SetIMECompositionRect user driver function and partially the WINE_IME_POST_UPDATE message call. It requires support for zwp_text_input_v3 from the compositor. It supports submitting committed text to the win32 side and notifying the compositor about the area of the text cursor rectangle. This doesn't add support for embedded pre-edit because I couldn't immediately get it to appear. Either I did something incorrect, or it has something to do with Wayland. On X11, the pre-edit appears completely separated to the application window and doesn't move with it, which doesn't seem to be compatible with Wayland. If Windows has the surrounding text feature, it does not seem possible to support it here with the provided interface. The IME is always enabled on the focused surface, like on X11. If Windows has a facility that applications can use to say that it does or does not accept text entry at certain parts of the UI, it does not seem possible to support it here with the provided interface. -- v3: winewayland: Implement SetIMECompositionRect. winewayland: Post IME update for committed text. winewayland: Enable/disable the zwp_text_input_v3 object. https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

3 6

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Brian Wright (＠PennRobotics) 13 Feb '25

13 Feb '25

On Thu Jan 30 21:42:13 2025 +0000, Joe Sorensen wrote: > Hi Rémi and co, is there any movement on this? (an open mr or the like) > Now that wine 10 is done could we consider getting this fix in? I've updated the [bug report](https://bugs.winehq.org/show_bug.cgi?id=57603) with some debug logs from 10.1 including `+x11drv,+event,+cursor,+win,+hid` if this helps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_94448

1 0

[PATCH 0/1] MR7327: sort: Support /+n option.
by Hans Leidekker (＠hans) 13 Feb '25

13 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7327

2 1

[PATCH v2 0/3] MR7241: winewayland: Basic input method support.
by Attila Fidan (＠atticf) 13 Feb '25

13 Feb '25

This MR tries to implement the SetIMECompositionRect user driver function and partially the WINE_IME_POST_UPDATE message call. It requires support for zwp_text_input_v3 from the compositor. It supports submitting committed text to the win32 side and notifying the compositor about the area of the text cursor rectangle. This doesn't add support for embedded pre-edit because I couldn't immediately get it to appear. Either I did something incorrect, or it has something to do with Wayland. On X11, the pre-edit appears completely separated to the application window and doesn't move with it, which doesn't seem to be compatible with Wayland. If Windows has the surrounding text feature, it does not seem possible to support it here with the provided interface. The IME is always enabled on the focused surface, like on X11. If Windows has a facility that applications can use to say that it does or does not accept text entry at certain parts of the UI, it does not seem possible to support it here with the provided interface. -- v2: winewayland: Implement SetIMECompositionRect. https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

4 8

[PATCH v2 0/3] MR7308: windows.storage: Add error handling in IRandomAccessStreamReferenceStatics::CreateFromStream().
by Mohamad Al-Jaf (＠maljaf) 13 Feb '25

13 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56106 I'm not sure why there's a IRandomAccessStreamReferenceStatics interface in WinTypes. Perhaps it was supposed to be queried from one of the classes there? I've seen something similar with other classes. -- v2: windows.storage: Add error handling in IRandomAccessStreamReferenceStatics::CreateFromStream(). windows.storage: Add IRandomAccessStreamReferenceStatics stub interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/7308

3 5