March 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/6] MR7686: winebth.sys part 8: Add support for replying to authentication/pairing requests.
by Vibhav Pant (＠vibhavp) 03 Apr '25

03 Apr '25

Implement `BluetoothSendAuthenticationResponseEx` over the `IOCTL_WINEBTH_RADIO_SEND_AUTH_RESPONSE` command in winebth.sys. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7686

3 7

[PATCH 0/1] MR7701: winemac.drv: Only send key down events to the window's inputContext.
by Tim Clem (＠tclem) 03 Apr '25

03 Apr '25

Sending key events through `-[NSTextInputContext handleEvent:]`, as we do in `macdrv_send_text_input_event`, results in doubled characters for certain macOS input sources. The Romaji source does this reliably, as do certain third-party sources. (The built-in dictation does it as well, but we already blacklist that - !5660 - because it remains "active" even when it's not.) I can't find this spelled out directly, but if you read between the lines, it seems clear that you're only supposed to send key *down* events to `-[NSTextInputContext handleEvent:]`, and not key ups. Supporting evidence: 1. [The old documentation on the text system](https://developer.apple.com/library/archive/documentation/TextFonts… only mentions `handleEvent:` being called in the context of `-keyDown:`. 2. [The guide to implementing a custom text view/NSTextInputClient](https://developer.apple.com/library/archive/documen… only mentions overriding `-keyDown:` and sending those events to `-handleEvent:`. 3. [iTerm only sends key down events to `-handleEvent:`](https://github.com/gnachman/iTerm2/blob/6134ea0a9d9d0fee5e7d7704fc98efec1fc77c24/sources/iTermKeyboardHandler.m#L355). You have to unpack the logic a bit from there, but `-handleKeyDownEvent:...` is the only method that calls `-handleEventWithCocoa:inputContext:`, which is what (usually) calls `-handleEvent:` on the `inputContext`. 4. [The InputMethodKit method on the IMKServerInput protocol to handle NSEvents directly](https://developer.apple.com/documentation/objectivec/nsobject/138… only mentions getting key down events. So presumably input source authors sometimes do not check the type of the NSEvent they're receiving and process all key events equally, be they downs or ups. This change fixes doubled input with Romaji and the problematic third-party method we've encountered. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7701

3 5

[PATCH 0/7] MR7698: PDB rewrite #6.
by eric pouech (＠epo) 03 Apr '25

03 Apr '25

This serie mainly moves line information for top level function (not including the inlined parts) into the new PDB reader. In details: - cleaning up current internal private structure for line information (in order to share it with PDB backend) - introduce methods to get line info from address, move to next/prev location, enumeration of line numbers and source files. Note for source files enumeration: - current implementation still needs some more fixes (no full scoping, but that's unrelated to PDB rewrite) - fixes by module scoping - it still uses the global source hash table (as there isn't one in PDB). No plan to improve that for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7698

3 9

[PATCH v2 0/2] MR7656: wined3d: Two unrelated fixes.
by Elizabeth Figura (＠zfigura) 03 Apr '25

03 Apr '25

-- v2: wined3d: Use VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN if possible. wined3d: Invert gl_FragCoord w. https://gitlab.winehq.org/wine/wine/-/merge_requests/7656

3 3

[PATCH v2 0/6] MR7561: wined3d: Vulkan H.264 decode, part 3/3.
by Elizabeth Figura (＠zfigura) 03 Apr '25

03 Apr '25

-- v2: d3d11/tests: Add tests for H.264 decoding. https://gitlab.winehq.org/wine/wine/-/merge_requests/7561

3 8

[PATCH 0/1] MR4740: ntdll: Don't hardcode pagesize when allocating handles
by Fabian Maurer (＠DarkShadow44) 02 Apr '25

02 Apr '25

Not really needed for 16k pages, but since the comment says "one page" the logic should reflect that. Not 100% sure about that since I don't know why it should use exactly one page, so please double check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4740

2 2

[PATCH v17 0/7] MR3799: kernelbase: Add implementation of PerfSetULongCounterValue and PerfSetULongLongCounterValue
by Lorenzo Ferrillo (＠llde) 02 Apr '25

02 Apr '25

These functions are used by Visual Studio 2019, when opening or converting some projects. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- v17: kernelbase: Check for PERF_SIZE_LARGE in PerfSetULongLongCounterValue and PerfSetULongCounterValue kernelbase : Check for PERF_ATTRIB_BY_REFERENCE attribute in PerfSetCounterRefValue advapi/test: Add Test For PerfSetULongLongCounterValue advapi32/tests: Create Tests for PerfSetULongCounterValue advapi32: Forward PerfSetULongCounterValue and PerfSetULongLongCounterValue to kernelbase kernelbase: Add implementation for PerfSetULongLongCounterValue kernelbase: Add implementation of PerfSetULongCounterValue https://gitlab.winehq.org/wine/wine/-/merge_requests/3799

3 10

[PATCH 0/1] MR7700: gdiplus: Avoid storing NULL in gdip_font_link_section.
by Eric Tian (＠thdaemon) 01 Apr '25

01 Apr '25

In `generate_font_link_info`, because the return value of `GdipCreateFontFromDC` is not checked, section->font might be set to NULL. `GdipMeasureString` calls `gdip_format_string`, which then calls `generate_font_link_info` and `font_link_get_text_extent_point`. In `font_link_get_text_extent_point`, the font from `gdip_font_link_section` is also not checked for NULL, which may cause a crash. Therefore, in `generate_font_link_info`, when `GdipCreateFontFromDC` fails, store `(GpFont *)base_font` (as with `IMLangFontLink_MapFont` failure) to ensure the font in `gdip_font_link_section` is valid. --- This issue was reproduced while using the [QQ Music](https://y.qq.com/download/index.html). Below is the original winedbg log (on Wine 10.4 + wine-staging + DXVK, with some native libraries used. If needed and permitted by WineHQ, I will list them.) (PS: This issue should also be reproduced using generic wine master without third parties) ``` Wine-dbg>frame 1 Wine-dbg>bt Backtrace: 0 0x00000078ed4d58 get_font_hfont+0x30(graphics=<couldn't compute location>, font=<couldn't compute location>, format=<couldn't compute location>, hfont=<couldn't compute location>, lfw_return=<couldn't compute location>, matrix=<couldn't compute location>) [/home/up/wine/build32/../wine/dlls/gdiplus/graphics.c:2476] in gdiplus (0x0000000073f700) =>1 0x00000078ed21bd font_link_get_text_extent_point+0xb9(info=000000000073F774, index=0, length=0xb, max_ext=0x7fffff83, fit=000000000073F7CC, size=000000000073F7B0) [/home/up/wine/build32/../wine/dlls/gdiplus/g raphics.c:5537] in gdiplus (0x0000000073f74c) 2 0x00000078ed340d gdip_format_string+0x2f9(graphics=0000000003665DD0, hdc=0000000034010075, string=L"Q音听我想听的歌???", length=0xb, font=0000000003672700, rect=000000000073F864, format=0000000009FEB508, ignore_empt y_clip=0x1, callback=0000000078EDADC8, user_data=000000000073F878) [/home/up/wine/build32/../wine/dlls/gdiplus/graphics.c:5663] in gdiplus (0x0000000073f81c) 3 0x00000078ea8283 GdipMeasureString+0x3cb(graphics=<couldn't compute location>, string=<couldn't compute location>, length=<couldn't compute location>, font=<couldn't compute location>, rect=<couldn't compute location>, format=<couldn't compute location>, bounds=<couldn't compute location>, codepointsfitted=<couldn't compute location>, linesfilled=<couldn't compute location>) [/home/up/wine/build32/../wine/dlls/gdiplu s/graphics.c:6050] in gdiplus (0x0000000073f8c0) 4 0x00000077d41fd2 in qqmusic (+0x31fd2) (0x0000000073f908) 5 0x00000077d3e1c6 in qqmusic (+0x2e1c6) (0x0000000073f96c) 6 0x00000077d3dd11 in qqmusic (+0x2dd11) (0x0000000073f9f8) 7 0x00000077f29bd4 in qqmusic (+0x219bd4) (0x0000000073fa70) 8 0x00000077f29a63 in qqmusic (+0x219a63) (0x0000000073faa0) 9 0x00000077f28760 in qqmusic (+0x218760) (0x0000000073fb08) 10 0x00000077b059d7 in common (+0x1059d7) (0x0000000073fb94) 11 0x00000077b06c35 in common (+0x106c35) (0x0000000073fbc8) 12 0x0000007a038b48 in user32 (+0x8b48) (0x0000000073fbf8) 13 0x0000007a093e43 call_window_proc+0xa7(hwnd=0000000000060138, msg=0x113, wp=0x400, lp=0, result=000000000073FC68, arg=0000000077B06B90) [/home/up/wine/build32/../wine/dlls/user32/winproc.c:111] in user32 (0x 0000000073fc40) 14 0x0000007a09c066 dispatch_win_proc_params+0xce(params=000000000073FCA0) [/home/up/wine/build32/../wine/dlls/user32/winproc.c:710] in user32 (0x0000000073fc7c) 15 0x0000007a09be4a dispatch_message+0x9e(msg=000000000073FDCC, ansi=0) [/home/up/wine/build32/../wine/dlls/user32/message.c:804] in user32 (0x0000000073fcd8) 16 0x0000007a04f530 DispatchMessageW+0xff(msg=000000000073FDCC) [/home/up/wine/build32/../wine/dlls/user32/message.c:890] in user32 (0x0000000073fd60) 17 0x000000780c001d in qqmusic (+0x3b001d) (0x0000000073fe38) 18 0x000000780c0ce6 in qqmusic (+0x3b0ce6) (0x0000000073fea8) 19 0x00000000403af4 in qqmusic (+0x3af4) (0x0000000073fefc) 20 0x00000000403bd6 in qqmusic (+0x3bd6) (0x0000000073ff50) 21 0x0000007bcdeb10 in kernel32 (+0xeb10) (0x0000000073ff68) 22 0x0000007be0d083 in ntdll (+0xd083) (0x0000000073ff78) 23 0x0000007be435b2 call_thread_func+0x2e(entry=000000000040678E, arg=00000000003F1000) [/home/up/wine/build32/../wine/dlls/ntdll/signal_i386.c:526] in ntdll (0x0000000073ffec) Wine-dbg>info locals 0x00000078ed21bd font_link_get_text_extent_point+0xb9: (0073f74c) struct gdip_format_string_info* info=000000000073F774 (parameter [EBP+8]) INT index=0 (parameter [EBP+12]) int length=0xb (parameter [EBP+16]) int max_ext=0x7fffff83 (parameter [EBP+20]) LPINT fit=000000000073F7CC (parameter [EBP+24]) SIZE* size=000000000073F7B0 (parameter [EBP+28]) DWORD to_measure_length=0x3 (local [EBP-16]) HFONT hfont=000000000D0A00AE (local [EBP-24]) HFONT oldhfont=000000004C0A00B0 (local [EBP-20]) SIZE sizeaux={cx=0x7c, cy=0x13} (local [EBP-32]) int i=0x8 (local [EBP-8]) int fitaux=0x8 (local [EBP-36]) struct gdip_font_link_section* section=00000000037E31A8 (local [EBP-12]) Wine-dbg>p *section Exception c0000005 Wine-dbg>x/10x 0x00000000037E31A8 0x000000037e31a8: 0073f78c 037e3188 00000008 0000000b 0x000000037e31b8: 00000000 00000000 00000004 8146001b 0x000000037e31c8: 78e0c030 78e0c030 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7700

4 5

[PATCH v2 0/4] MR7425: jscript: Obtain the jsdisp for host objects in other contexts.
by Gabriel Ivăncescu 01 Apr '25

01 Apr '25

-- v2: jscript: Get rid of the funcprot argument. mshtml: Release the node if there's no script global when handling events. jscript: Obtain the jsdisp for host objects in other contexts. mshtml: Keep the link from the inner window to the outer window even when https://gitlab.winehq.org/wine/wine/-/merge_requests/7425

2 9

[PATCH v12 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

-- v12: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

3 10