March 2025 - Wine-gitlab - list.winehq.org

[PATCH v11 0/11] MR7422: winebus/dinput: Support arbitrary number of axes in the virtual PID descriptor
by Tomasz Pakuła 23 Mar '25

23 Mar '25

Related Wine issue: https://bugs.winehq.org/show_bug.cgi?id=52714 I'm starting work on updating/extending Linux force feedback API and one of my goals is to expose the number and an array that contains the device's ffb-enabled axes. As I'm mainly working with USB PID driver, I already have a POC of obtaining this data. What prompted this is that currently Wine always creates virtual joysticks with two PID ffb axes. This causes issues with [Richard Burns Rally](https://github.com/ValveSoftware/Proton/issues/6702#issuecomment-267…, as this game incorrectly initializes a `CONSTANT_FORCE` effect with all the FFB axes that contain `DIDOI_FFACTUATOR` flag and then trying to update `cAxes` and `rgdwAxes` values which leads to `DIERR_INVALIDPARAM`. Now, this flag is set by wine while enumerating virtual device's axes and while `(axis index < FFB axes)`, flag is applied. This means, that every device which has FFB functionality and at least two axes, will report FFB on `X`, `Y`. While updated API would mean a lot of steering wheels would correctly report only 1 axis, a lot of USB PID wheels still include `X` and `Y` in their `AXES_ENABLE` and `DIRECTION` usages. This, again, would lead to broken FFB (in affected games). On Windows, there's a possibility of overwriting some joystick capabilities with registry entries, which ends up removing `DIDOI_FFACTUATOR` flag from a selected axis. This doesn't work in Wine. This MR allows Wine to add an arbitrary number (up to `PID_AXES_MAX`) of axes to the PID descriptor, based on the value of Haptic Axes from SDL or from Linux FF api in the future (I'm working on it). Additionally, to work around RBR and other games with similar, wrong FFB handling, I introduced a [hint](https://github.com/libsdl-org/SDL/issues/12341) to SDL that allows a dynamic overwrite of the number of haptic axes. For the Linux API, I'll figure out a nice way to override when the number of axes will be exposed. With these changes, I was able to successfully get force feedback on my Moza Racing R9 with all axes usable. With additional traces in the dinput code, I confirmed that with one axis defined in the PID descriptor, the game created a constant force effect with just one axis and `cAxes = 1`. -- v11: Try fixing some tests https://gitlab.winehq.org/wine/wine/-/merge_requests/7422

1 11

[PATCH v10 0/10] MR7422: winebus/dinput: Support arbitrary number of axes in the virtual PID descriptor
by Tomasz Pakuła 23 Mar '25

23 Mar '25

Related Wine issue: https://bugs.winehq.org/show_bug.cgi?id=52714 I'm starting work on updating/extending Linux force feedback API and one of my goals is to expose the number and an array that contains the device's ffb-enabled axes. As I'm mainly working with USB PID driver, I already have a POC of obtaining this data. What prompted this is that currently Wine always creates virtual joysticks with two PID ffb axes. This causes issues with [Richard Burns Rally](https://github.com/ValveSoftware/Proton/issues/6702#issuecomment-267…, as this game incorrectly initializes a `CONSTANT_FORCE` effect with all the FFB axes that contain `DIDOI_FFACTUATOR` flag and then trying to update `cAxes` and `rgdwAxes` values which leads to `DIERR_INVALIDPARAM`. Now, this flag is set by wine while enumerating virtual device's axes and while `(axis index < FFB axes)`, flag is applied. This means, that every device which has FFB functionality and at least two axes, will report FFB on `X`, `Y`. While updated API would mean a lot of steering wheels would correctly report only 1 axis, a lot of USB PID wheels still include `X` and `Y` in their `AXES_ENABLE` and `DIRECTION` usages. This, again, would lead to broken FFB (in affected games). On Windows, there's a possibility of overwriting some joystick capabilities with registry entries, which ends up removing `DIDOI_FFACTUATOR` flag from a selected axis. This doesn't work in Wine. This MR allows Wine to add an arbitrary number (up to `PID_AXES_MAX`) of axes to the PID descriptor, based on the value of Haptic Axes from SDL or from Linux FF api in the future (I'm working on it). Additionally, to work around RBR and other games with similar, wrong FFB handling, I introduced a [hint](https://github.com/libsdl-org/SDL/issues/12341) to SDL that allows a dynamic overwrite of the number of haptic axes. For the Linux API, I'll figure out a nice way to override when the number of axes will be exposed. With these changes, I was able to successfully get force feedback on my Moza Racing R9 with all axes usable. With additional traces in the dinput code, I confirmed that with one axis defined in the PID descriptor, the game created a constant force effect with just one axis and `cAxes = 1`. -- v10: Update expected reports len https://gitlab.winehq.org/wine/wine/-/merge_requests/7422

1 10

[PATCH v2 0/1] MR7622: comctl32: Avoid segfault in PROPSHEET_DoCommand when psInfo is NULL.
by Yuri Hérouard 23 Mar '25

23 Mar '25

Fixes https://bugs.winehq.org/show_bug.cgi?id=57987. In the case of that issue, it does not crash anymore, and the settings are now correctly saved. -- v2: comctl32: Avoid segfault in PROPSHEET_DoCommand when psInfo is NULL. https://gitlab.winehq.org/wine/wine/-/merge_requests/7622

3 4

[PATCH v10 0/7] MR7111: Draft: support building Wine with LTO
by Konstantin Demin (＠rockdrilla) 23 Mar '25

23 Mar '25

work is still in progress. todo: - ensure that all affected sources (i.e. C sources with any kind of assembly) are listed in either way for all architectures - test Wine built with LTO relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v10: LTO quirks configure: enable building Wine with LTO makedep: support skipping/disabling LTO makedep: support LTO builds winegcc: support LTO builds winebuild: support LTO builds tools: helper functions for LTO builds https://gitlab.winehq.org/wine/wine/-/merge_requests/7111

2 7

[PATCH v2 0/1] MR7640: server: Fall back to epoll_wait if epoll_pwait2 doesn't work
by Alfred Agrell (＠Alcaro) 23 Mar '25

23 Mar '25

Fixes hangs if Wine is built with newer headers than kernel -- v2: server: Fall back to epoll_wait if epoll_pwait2 doesn't work. https://gitlab.winehq.org/wine/wine/-/merge_requests/7640

5 6

[PATCH v13 0/1] MR6199: winewayland.drv: Fix alt-tabbing out opening the alt key menu
by Yuri Hérouard 23 Mar '25

23 Mar '25

Fix the wayland side of https://bugs.winehq.org/show_bug.cgi?id=55336 ### ~~Exit menu key by default:~~ That's the actual behavior, any non-special key will exit the menu key, and be sent to the client. I was also wondering if we should add `menu_sys_key = f10_key = 0;` when receiving a `WM_ACTIVATE` in `win32u/defwnd.c`'s `default_window_proc` but I guess not ? ### ~~Fix repeated key for no reason:~~ For some reason when ALT is pressed, it is spammed and thus spams SYS_COMMAND. This fix that, but I don't know what I am doing here. I don't see any repeating key spamming with winex11 but I could be wrong. However alt/SYS_COMMAND should not be repeated. That wasn't happening with winex11.drv. ### Fix release_all_keys modifier filtering: That was the main reason why alt-tab leads to the menu key, NtUserGetAsyncKeyboardState also uses left and right system keys. -- v13: winewayland: Fix release_all_keys's modifier filtering. https://gitlab.winehq.org/wine/wine/-/merge_requests/6199

1 1

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Nikolay Sivov (＠nsivov) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:56:23 2025 +0000, Robert Lippmann wrote: > Sorry, I'm new to this :disappointed: > What would happen if it was just a stub? > I also figured, while I was there, I might as well implement it... What would happen depends on an application that you run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98772

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 23:08:45 2025 +0000, Robert Lippmann wrote: > Oops. Well, they all actually just return errors. > Which is what I think the problem is. > Should I close this and just submit a patch that implements them? > I'd probably do it simpler with just a hack with a static variable anyway. Or should I keep the registry related code? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98771

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:59:02 2025 +0000, Nikolay Sivov wrote: > All 4 functions you mentioned are already present in current code, in a > form of stubs. So you don't need to update the spec file. Oops. Well, they all actually just return errors. Which is what I think the problem is. Should I close this and just submit a patch that implements them? I'd probably do it simpler with just a hack with a static variable anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98770

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Nikolay Sivov (＠nsivov) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:54:23 2025 +0000, Robert Lippmann wrote: > As for ordinal numbers, I just copied and pasted what winedump gave me. > Should I change them all to @'s? All 4 functions you mentioned are already present in current code, in a form of stubs. So you don't need to update the spec file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98769

1 0