March 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:43:07 2025 +0000, Nikolay Sivov wrote: > Header is another thing, but source files do not have to match how > functions are arranged in the SDK. Sorry, just seemed like a good idea because the existing file is pretty big and full of functions returning not implemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98768

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:43:29 2025 +0000, Nikolay Sivov wrote: > So what does it need exactly, and why stubs are not enough? Sorry, I'm new to this :disappointed: What would happen if it was just a stub? I also figured, while I was there, I might as well implement it... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98767

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:53:43 2025 +0000, Robert Lippmann wrote: > From what I can tell, it uses: > PowerSetActiveScheme > PowerGetActiveScheme > PowerReadFriendlyName > PowerEnumerate > I'm hoping just implementing the first 2 will get it to work. As for ordinal numbers, I just copied and pasted what winedump gave me. Should I change them all to @'s? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98766

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:41:35 2025 +0000, Nikolay Sivov wrote: > I meant ordinal numbers, preceding calling convention marker "stdcall". > Does SteamVR require any of newer functions? >From what I can tell, it uses: PowerSetActiveScheme PowerGetActiveScheme PowerReadFriendlyName PowerEnumerate I'm hoping just implementing the first 2 will get it to work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98765

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Nikolay Sivov (＠nsivov) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:37:26 2025 +0000, Robert Lippmann wrote: > SteamVR's vrmonitor.exe tries to change the power profile and crashes > with an access violation. > Valve has been bugged about this for years, since they really shouldn't > be doing it. So, I figure it will never be fixed by them. So what does it need exactly, and why stubs are not enough? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98764

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Nikolay Sivov (＠nsivov) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:31:59 2025 +0000, Robert Lippmann wrote: > Well, according to the SDK, the header is now powersetting.h, not > powrprof.h, which is why I created the new file. Header is another thing, but source files do not have to match how functions are arranged in the SDK. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98763

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Nikolay Sivov (＠nsivov) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:41:16 2025 +0000, Robert Lippmann wrote: > Oops, I just took the output of winedump and didn't change the numbers > to @'s. I meant ordinal numbers, preceding calling convention marker "stdcall". Does SteamVR require any of newer functions? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98762

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:32:59 2025 +0000, Robert Lippmann wrote: > These are additional power related functions that were defined in > Windows Vista (the current code is like 20 years old). Oops, I just took the output of winedump and didn't change the numbers to @'s. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98761

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:37:26 2025 +0000, Nikolay Sivov wrote: > Do you have an application that depends on those functions returning anything? SteamVR's vrmonitor.exe tries to change the power profile and crashes with an access violation. Valve has been bugged about this for years, since they really shouldn't be doing it. So, I figure it will never be fixed by them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98760

1 0

Re: [PATCH v2 0/8] MR7644: powrprof.dll: Implement PowerGetActiveProfile and PowerSetActiveProfile
by Robert Lippmann (＠rlippmann) 22 Mar '25

22 Mar '25

On Sat Mar 22 22:35:07 2025 +0000, Nikolay Sivov wrote: > Hi, @rlippmann. This needs some basic cleanup first - fixup commits > should be merged with main commits so that MR has a clean list of > wellformed changes. Note that you don't need to create a new MR every > time you want to change something. Just force push to the same branch. I've been trying to. Unfortunately the pipeline build fails every time saying it couldn't get my credentials even though I've set git global username and email address. I've been trying to figure out why that happens, hence the multiple (closed) merge requests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7644#note_98759

1 0