April 2025 - Wine-gitlab - list.winehq.org

[PATCH v3 0/3] MR6885: Draft: cmd: Use the console output codepage to read batch files.
by Akihiro Sagawa (＠sgwaki) 20 Apr '25

20 Apr '25

To prevent performance degradation, we will cache the result of GetConsoleOutputCP() after executing every external command. -- v3: cmd: Use the console output code page to read batch files. programs/cmd: Factor out code_page when searching for a label. cmd/tests: Add updated code page test in batch file. https://gitlab.winehq.org/wine/wine/-/merge_requests/6885

3 3

[PATCH v2 0/2] MR6885: cmd: Use the console output codepage to read batch files.
by Akihiro Sagawa (＠sgwaki) 20 Apr '25

20 Apr '25

To prevent performance degradation, we will cache the result of GetConsoleOutputCP() after executing every external command. -- v2: cmd: Use the console output codepage to read batch files. cmd/tests: Add updated code page test in batch file. https://gitlab.winehq.org/wine/wine/-/merge_requests/6885

3 4

[PATCH v3 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 19 Apr '25

19 Apr '25

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- v3: msi: Properly select first feature. https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

2 4

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 Apr '25

19 Apr '25

On Sat Apr 19 16:23:57 2025 +0000, eric pouech wrote: > forgot to say that executable files must be in considered directory > (eg if a.exe and e.bat exist in current directory, then 'a\<tab\>' shall > circle around both files); PATH is not used My code already does this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101459

1 0

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 Apr '25

19 Apr '25

On Sat Apr 19 16:20:43 2025 +0000, eric pouech wrote: > maybe. i could also be something that cmd implements in > CONSOLE_READCONSOLE_CONTROL (using 0x1B in control mask). That's how I'm handling it in current changes (not yet pushed). But I shouldn't need to, based on ReadConsole behaviour that I see on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101458

1 0

[PATCH 0/2] MR7856: gdiplus: Simplify region code.
by Esme Povirk (＠madewokherd) 19 Apr '25

19 Apr '25

Just some cleanups from the recent changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7856

2 2

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 19 Apr '25

19 Apr '25

On Sat Apr 19 16:23:57 2025 +0000, Joe Souza wrote: > Testing on Windows 11 this morning, I find that Windows does not filter > on .EXE or anything in PATHEXT if tab key is hit for first word on > command line. forgot to say that executable files must be in considered directory (eg if a.exe and e.bat exist in current directory, then 'a\<tab\>' shall circle around both files); PATH is not used -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101456

1 0

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 19 Apr '25

19 Apr '25

On Sat Apr 19 15:01:13 2025 +0000, Joe Souza wrote: > A bug in Wine's ReadConsole implementation that I found while making > these changes is that Wine does not handle ESC key correctly. On > Windows, ESC key clears the text on the screen and clears the buffer. > Wine emits the control character for the ESC key. I'll handle this in > my changes and add a FIXME comment. maybe. i could also be something that cmd implements in CONSOLE_READCONSOLE_CONTROL (using 0x1B in control mask). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101455

1 0

[PATCH v3 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) 19 Apr '25

19 Apr '25

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: combase: Add a stub for SetRestrictedErrorInfo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

3 2

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 Apr '25

19 Apr '25

On Fri Apr 18 16:37:52 2025 +0000, Joe Souza wrote: > OK, using ReadConsole/CONSOLE_READCONSOLE_CONTROL on Windows gives me > the behaviour that I need; i.e. pre-filled text is preserved and can be > further edited. Caller must output the text first, but seems to work as expected. > I'll start making the changes to my code soon, within the coming days. A bug in Wine's ReadConsole implementation that I found while making these changes is that Wine does not handle ESC key correctly. On Windows, ESC key clears the text on the screen and clears the buffer. Wine emits the control character for the ESC key. I'll handle this in my changes and add a FIXME comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101451

1 0