April 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Piotr Caban (＠piotr) 18 Apr '25

18 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7853

2 4

[PATCH v2 0/4] MR7826: ntdll: Fix some more Valgrind warnings.
by Sven Baars (＠sbaars) 18 Apr '25

18 Apr '25

-- v2: ntdll: Avoid evaluating a possibly uninitialized variable in RtlExpandEnvironmentStrings(). (Valgrind). ntdll/tests: Fix some uninitialized variable warnings (Valgrind). ntdll/tests: Don't trace invalid pointers (Valgrind). ntdll/tests: Fix some string leaks (Valgrind). https://gitlab.winehq.org/wine/wine/-/merge_requests/7826

2 5

[PATCH v2 0/8] MR7848: Draft: server: Use events as a sync for several objects.
by Rémi Bernon 18 Apr '25

18 Apr '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v2: server: Use an event as debug event sync. server: Use an event as file lock sync. server: Use an event as process startup info sync. server: Use an event as thread context sync. server: Use an event as thread apc sync. server: Use an event as fd sync. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

1 10

[PATCH 0/2] MR7851: win32u: Fix return value of ScrollWindowEx() for invisible windows.
by Dmitry Timoshkov (＠dmitry) 18 Apr '25

18 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7851

2 2

Re: [PATCH v10 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 18 Apr '25

18 Apr '25

One more improvement suggestion, but otherwise looks good to me! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101384

1 0

Re: [PATCH v10 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 18 Apr '25

18 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > } > else if (!needs_relative && pointer->zwp_relative_pointer_v1) > { > + pointer->accum_x = pointer->accum_y = 0; I was thinking... if we perform the initialization/zeroing just before enabling relative motion in the if clause above, we reduce (although we do not completely eliminate) the window for the data race mentioned in a previous comment (i.e., some handler running concurrently). This also takes care of the lack of explicit initialization of the accum_x/accum_y members during wayland_pointer init. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101383

1 0

[PATCH 0/5] MR7849: PDB rewrite #10.
by eric pouech (＠epo) 18 Apr '25

18 Apr '25

This serie finishes the migration of the remaining types from TPI stream (function signature, struct/class/union, enum) to new PDB backend. And it removes dual allocation of symt_* in old PDB backed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7849

2 5

[PATCH 0/8] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon 18 Apr '25

18 Apr '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

2 10

[PATCH 0/1] MR7028: ntdll: Remove manifest name filtering.
by Dmitry Timoshkov (＠dmitry) 18 Apr '25

18 Apr '25

Componenets installed by winetricks have "deadbeef.manifest" trailer in their manifests, so it's not clear that filtering logic works. On the other hand when manifests for versions 1.2.3.4 and 1.2.3.10 are installed and application exe needs version 1.2.0.0 and later uses LoadLibrary() to load a plugin.dll that needs 1.2.3.7, version 1.2.3.4 gets loaded with an .exe (because manifest for version 1.2.3.10 is ignored) and version 1.2.3.10 gets loaded with a plugin.dll, and this leads to crashes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7028

3 6

[PATCH 0/6] MR7815: server: Split event object to a dedicated sync.
by Rémi Bernon 18 Apr '25

18 Apr '25

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7226 This MR introduces a new wineserver "sync" entity, to be used by objects to implement the signal/wait operations. Later, the server sync implementations will be reduced as much as possible to event/mutex/semaphore/queue[^1]. I think it will then make the integration of ntsync cleaner, with inproc syncs being a separate flavor from the traditional server-side syncs. Unlike how the fd struct have been implemented, I chose not to derive these syncs from the object base, because it seemed inconvenient to have to declare all the unused ops. Still they are refcounted, to allow us to share a sync between multiple objects, which will later benefit the console objects use cases, maybe others. This makes me thing that the fd struct could also benefit from being lightweight entities as well, as it doesn't seem they really use most of the object vtable ops, and arguably we could have a common "light" refcounted/dumpable base for all fds, syncs and objects, but I didn't want to jump into that rabbit hole and it could be implemented later. [^1]: And server-only async/completion waits, which maybe can be changed to use events too, but I'm not familiar enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7815

2 9