July 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/4] MR8656: mshtml: Implement attribute nodes with gecko nodes in IE9+ modes.
by Gabriel Ivăncescu 07 Aug '25

07 Aug '25

For the IE9 attr node implementation (delegating to gecko attr nodes), this uses the existing infrastructure to keep track of the attributes in a collection (and so, associate DISPIDs for them, etc), since it also matches native (same DISPID broken behavior when removing attrs) and we already have the code for it. The current code is split into helpers called from many places already related to it, so instead I just extended the helpers with new code paths for IE9+ attrs. There's also appropriate FIXMEs for things that aren't properly handled by simple delegation to gecko (from my older patchset), so at least if we find something that needs it, it will be way easier to debug. The last patch is a bit big since it had to enable the new attr nodes everywhere in IE9+ modes, else either tests would fail or we wouldn't test anything, as I'm using existing tests (just in IE9 mode). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8656

2 9

[PATCH 0/7] MR6971: mshtml: Implement attribute nodes properly in IE9+ modes and prototype chain.
by Gabriel Ivăncescu 07 Aug '25

07 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6971

2 16

[PATCH v2 0/1] MR8338: gameinput: Add stub dll.
by Oleg Makarenko (＠JacKeTUs) 07 Aug '25

07 Aug '25

Certain games have started using the newest GameInput API and linking to GameInput.dll. Adding a stub library allows these games to launch and enables them to fall back to the DirectInput API if `GameInputCreate` returns an error. Affected games: Le Mans Ultimate -- v2: gameinput: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/8338

5 10

[PATCH v2 0/4] MR3334: Add vccorlib140.dll stub dll.
by Etaash Mathamsetty (＠etaash.mathamsetty) 07 Aug '25

07 Aug '25

When using native xinput in WRC9, vccorlib is needed to make sure xinput doesn't crash. -- v2: wincorlib: Add stub for platform_details_uninit_data. wincorlib: Add stub for platform_details_init_data. vccorlib140: Add stub dll. wincorlib: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3334

4 10

[PATCH 0/11] MR8634: dxcore: Implement GetAdapterByLuid().
by Nikolay Sivov (＠nsivov) 07 Aug '25

07 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8634

4 19

[PATCH 0/1] MR8177: user32/tests: Add tests for DrawTextExW.
by JiangYi Chen (＠meshine) 07 Aug '25

07 Aug '25

@alexhenrie @zhiyi The corresponding Windows test demo is as follows: [test_DrawTextExW.exe](/uploads/ff1eafc9c58ac03b598699a93136484c/test_DrawTextExW.exe) [test_DrawTextExW.c](/uploads/a41719a33c2ee0e057c911933bf55180/test_DrawTextExW.c) Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: I64052ba8aa8161ad83c1811d642aedbe462ef5ea -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8177

2 2

[PATCH 0/1] MR8270: mf: Prevent double submission of session commands.
by Yuxuan Shui (＠yshui) 06 Aug '25

06 Aug '25

This is not the right fix, and I need some help. Let me explain. `session_submit_command` checks that: 1. `session->commands` is empty, and 2. `SESSION_FLAG_PENDING_COMMAND` is NOT set before submitting the `session_op`. The assumption is, if there are queued commands, or if there is a command currently running, that pending command will submit subsequent commands when it completes. However, in this call chain: ``` #0 0x00006fffe1d27ad7 in create_async_result (object=object(a)entry=0x0, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0, out=out(a)entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1229 #1 0x00006fffe1d222d5 in RtwqCreateAsyncResult (object=object(a)entry=0x0, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0, out=out(a)entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1245 #2 0x00006fffd45e2096 in MFPutWorkItem (queue=queue(a)entry=1, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0) at ../dlls/mfplat/queue.c:46 #3 0x00006fffe41244ee in session_command_complete (session=0x7e62489f1be0) at ../dlls/mf/session.c:975 #4 0x00006fffe412d00f in session_reset (session=session(a)entry=0x7e62489f1be0) at ../dlls/mf/session.c:1051 #5 0x00006fffe41299fc in session_handle_source_shutdown (session=session(a)entry=0x7e62489f1be0) at ../dlls/mf/session.c:2957 #6 0x00006fffe4126e90 in session_events_callback_Invoke (iface=0x7e62489f1c20, result=<optimized out>) at ../dlls/mf/session.c:4445 ``` nowhere was the `SESSION_FLAG_PENDING_COMMAND` flag set. In addition to that, `session_events_callback_Invoke` is not a command. So this could happend: ``` Thread 1 | Thread 2 call session_events_callback_Invoke | | call session_submit_command | <critical section> | list_empty(&session->commands) is true, and PENDING_COMMAND not set | MFPutWorkItem(op) | list_add(&session->commands, op) <- (1) | </critical_section> call session_handle_source_shutdown | <critical_section> | call session_reset | call session_command_complete | list_head(&session->commands) | op is returned because of (1) | MFPutWorkItem(op) again | </critical_section> | ``` The result is this op will be executed twice, and also double freed, because `session_commands_callback_Invoke` releases the `op`. * * * There is even another way an `op` can be submitted twice, `session_handle_start_error` calls `session_reset`, which already calls `session_command_complete`, and later it calls `session_command_complete_with_event` again. I think a missing return? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8270

3 7

[PATCH v5 0/1] MR8605: winebus: Do not touch autocenter on device init, device reset and stop all effects
by Tomasz Pakuła 06 Aug '25

06 Aug '25

FFB Autocenter introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/4911 had one major misunderstanding. The USB PID standard doesn't actually define any explicit way to autocenter a device. One could of course use the spring effect with a deadzone of 0 and dead band of 0. This is what I'm actually working on for the Linux PID driver (spring + friction/damper). Some devices implement autocenter in firmware when they receive the DC Disable Actuators command. Very few, if not just one, implement this weird autocenter effect on slot 1. This is, from what I can gather, only implemented on the MS SideWinder joystick(s) and the Windows' USB PID driver is created around these devices. Windows PID driver is a bit out of spec, is quite permissive when it comes to fields missing in the descriptor (basically, only effect types and their effect type blocks are optional). Another thing it does is handling of this out-of-spec autocentering for their joysticks. Funnliy enough, the creator of the Linux PID driver based the initial code on testing with MS Sidewinder so it's autocentering is supported. This is where the autocentering mentioned in the MR comes from. It's not the directinput api that does it but the Windows PID driver. As such, autocentering on reset should be left to the drivers, not handeled by Wine. SDL lacks full reset support and Linux is even more barebones, whre it's not even possible to query the device state, effects etc (something I'm working on slowly). As such, when games send out RESET to prepare the device, the device starts autocentering for no good reason and the effect is not removed once other effect are uploaded and played which would be the case for MS sidewinder. In any case, even Windows in inconsistent and I think the directinput documentation has some errors. directinput ffb api is largely based on USB PID but: ![image](/uploads/6548386550b874d2e5548f35f7fe76b0/image.png) ![image](/uploads/851484a555c744c6791d48b3fd194e91/image.png) Testing with my Moza Racing R9 wheelbase, the DC Reset PID command is sent, but there's no DC Disable Actuators in sight. The games still call reset then enable actuators though. tl;dr Set autocentering to 0 instead of max value when DISFFC_RESET is received to remove the unwanted autocenter behavior. Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny(a)gmail.com> -- v5: winebus: Do not touch autocenter on device init and device reset https://gitlab.winehq.org/wine/wine/-/merge_requests/8605

4 23

[PATCH v7 0/2] MR8671: cryptowinrt: Stub ICryptographicBufferStatics::EncodeToBase64String().
by Mohamad Al-Jaf (＠maljaf) 03 Aug '25

03 Aug '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- v7: cryptowinrt/tests: Add some ICryptographicBufferStatics::EncodeToBase64String() tests. cryptowinrt: Stub ICryptographicBufferStatics::EncodeToBase64String(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8671

3 4

[PATCH v3 0/9] MR8641: wined3d: Fixes for D3DTSS_TEXTURETRANSFORMFLAGS.
by Elizabeth Figura (＠zfigura) 01 Aug '25

01 Aug '25

-- v3: wined3d: Always divide 1.x projected textures by W in the FFP. wined3d: Always divide 1.x projected textures by W for shaders. wined3d: Initialize all remaining FFP texture coordinates to zero. wined3d: Copy the projective divisor in the FFP vertex pipeline. wined3d: Alter the texture matrix even for non-projected textures. wined3d: Pass 3 as the attribute count for generated texcoords. wined3d: Pass the attribute coordinate count to get_texture_matrix(). wined3d: Handle all invalid values in compute_texture_matrix(). d3d9/tests: Add comprehensive D3DTSS_TEXTURETRANSFORMFLAGS tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/8641

3 10