July 2025 - Wine-gitlab - list.winehq.org

[PATCH v7 0/2] MR7032: Add embeddedbrowserwebview aka. WebView2 DLL stub.
by Bernhard Kölbl 28 Aug '25

28 Aug '25

(For after the code freeze.) I think we want to have this DLL living in Wine for easier development, and probably dynamically load our custom Chromium fork from here. (just like MSHTML and wine-Gecko) The code for that fork could then be created in its own repo. -- v7: embeddedbrowserwebview: Create CreateWebViewEnvironmentWithOptionsInternal stub. embeddedbrowserwebview: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/7032

5 8

[PATCH 0/1] MR8298: ole32: Don't get metafile extent if there is no metafile.
by Yuxuan Shui (＠yshui) 27 Aug '25

27 Aug '25

If entry->stgmedium.hEnhMetaFile is NULL, the data_size we get will be 0, we then allocate 0 bytes for data, but expect it to contain at least a METAFILEPICT, resulting in reading out-of-bound. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8298

3 3

[PATCH 0/5] MR8685: wintypes: Implement IMap::{Lookup, HasKey, Insert} for IPropertySet.
by Vibhav Pant (＠vibhavp) 26 Aug '25

26 Aug '25

`IMap` is implemented on top of a `rb_tree` guarded with an `SRWLOCK`. We need the map to be thread safe as: * `PropertySet` is marked as `IAgileObject`. * I plan to use `PropertySet` as the backing store for [`DeviceInformation::Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100). These properties can be updated by apps after receiving an [`Updated`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.devicewatcher.updated?view=winrt-26100#windows-devices-enumeration-devicewatcher-updated) event from the device watcher with [`DeviceInformation::Update`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.update?view=winrt-26100). The current `DeviceWatcher` implementation dispatches the event delegates for `Update` from a separate thread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8685

5 15

[PATCH 0/7] MR7367: winex11: Use _NET_ACTIVE_WINDOW to request/track foreground window.
by Rémi Bernon 26 Aug '25

26 Aug '25

This should at least fix foreground window inconsistencies between Wine and X11, when _NET_ACTIVE_WINDOW is supported by the WM, allowing us to then better implement focus tracking (to avoid changing focus when not desired), as well as SWP_NOACTIVATE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7367

3 11

[PATCH v6 0/41] MR6207: Draft: include: Introduce new COM implementation helper macros.
by Rémi Bernon 25 Aug '25

25 Aug '25

I think it would be very nice to have something like that to reduce the burden of implementing COM interfaces. This shows for instance on the windows.gaming.input module a 30% LoC reduction (from ~6800 to ~4700), even though the module already had a boilerplate helper macros already. The MR introduces macros to automatically implement each IUnknown method, as well as all of them at once. It also includes a helper to implement IInspectable methods at once, as well as macros to forward both interface methods to a base interface or an outer object. Last, it provides higher-level macros to implement a main interface and any number of sub interfaces and generate IUnknown, forwarding and vtables for all of them at once, with IInspectable support when needed. It uses widl to generate additional per-interface macros, for things like inheritance and vtable generation. The rest of the macros are otherwise shared in a Wine-specific header. The implementation is split to show individual macro being used, although they are later replaced by higher-level macros. The individual helpers are still useful in some corner cases where specific behavior needs to be implemented, or for aggregating classes. -- v6: widl: Generate return traces for COM classes. widl: Generate method traces for COM classes. widl: Generate COM class code for IClassFactory. windows.gaming.input: Generate the provider COM class. windows.gaming.input: Generate the vector COM classes. windows.gaming.input: Generate the async COM classes. windows.gaming.input: Generate the manager COM classes. windows.gaming.input: Generate the force feedback COM classes. windows.gaming.input: Generate the ramp effect COM classes. windows.gaming.input: Generate the periodic effect COM classes. windows.gaming.input: Generate the constant effect COM classes. windows.gaming.input: Generate the condition effect COM classes. (broken) windows.gaming.input: Generate the racing wheel COM classes. windows.gaming.input: Generate the gamepad COM classes. windows.gaming.input: rename controller to raw_controller widl: Generate initializers for COM classes. widl: Generate vtables for COM classes. widl: Generate impl unwrappers for COM classes. widl: Generate QueryInterface for COM classes. widl: generate some query interface helpers widl: Generate default IUnknown / IInspectable implementation. widl: Generate IUnkonwn and IInspectable forwarding for COM classes. widl: Generate impl_from helpers for COM classes. windows.gaming.input: Use the generated COM class structs. widl: Generate some structs for COM classes. widl: Parse a widl-specific impl attribute on structs. makedep: Generate some new impl.h headers from the IDLs. widl: Generate some new impl.h headers from the IDLs. windows.gaming.input: Use a separate interface for IAgileObject. widl: Introduce a new append_declspec helper. widl: Inline write_args into write_type_right. widl: Cleanup indentation and variables in write_type_right. widl: Remove now unnecessary write_callconv argument. widl: Introduce a new append_type_left helper. widl: Split write_type_left into a write_type_definition_left helper. widl: Cleanup indentation and variables in write_type_left. widl: Introduce a new write_record_type_definition helper. widl: Move some type name construction out of write_type_left. widl: Remove unnecessary recursion for TYPE_BITFIELD. widl: Introduce a new append_basic_type helper. widl: Wrap strappend parameters in a new struct strbuf. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6207

3 19

[PATCH v2 0/5] MR8486: win32u: Always pass class name atom strings to wineserver.
by Rémi Bernon 22 Aug '25

22 Aug '25

-- v2: win32u: Always pass class name atom strings to wineserver. server: Support integral atom strings. win32u: Introduce helpers to check desktop and message class. user32: Use init_class_name(_ansi) in FindWindowEx(A|W). win32u: Forbid setting GCW_ATOM class info. https://gitlab.winehq.org/wine/wine/-/merge_requests/8486

2 9

[PATCH 0/1] MR1968: Fix a problem caused by the recent official commit "rsaenh: Factor out...
by Jackie Jiang (＠sonyps5201314) 20 Aug '25

20 Aug '25

Fix a problem caused by the recent official commit "rsaenh: Factor out block_encrypt() function." that would cause DES encryption errors -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1968

3 3

[PATCH v4 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) 20 Aug '25

20 Aug '25

Fix out-of-bound access by wcslen. Found by ASan. -- v4: mscoree: Add missing NUL terminator. https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

5 9

[PATCH 0/1] MR8089: include: Add missing extern "C++" to guiddef.h
by Alfred Agrell (＠Alcaro) 20 Aug '25

20 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8089

3 4

[PATCH 0/1] MR7951: Draft: test to see clean output
by Jeff Latimer (＠greyghoster) 20 Aug '25

20 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7951

3 2