August 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v4 0/1] MR8713: widl: Fix crash while replacing type parameters for arrays. - approved
by Alexandre Julliard (＠julliard) 06 Aug '25

06 Aug '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8713

1 0

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects - approved
by Alexandre Julliard (＠julliard) 06 Aug '25

06 Aug '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605

1 0

Re: [PATCH v2 0/4] MR8711: winebus: Force the ordering of some common evdev gamepad buttons. - approved
by Alexandre Julliard (＠julliard) 06 Aug '25

06 Aug '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8711

1 0

Re: [PATCH v3 0/7] MR8715: opengl32: Use generated wow64 thunks for context functions. - approved
by Alexandre Julliard (＠julliard) 06 Aug '25

06 Aug '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8715

1 0

Re: [PATCH v2 0/7] MR8714: mshtml: Add DOM attribute node implementation. - approved
by Alexandre Julliard (＠julliard) 06 Aug '25

06 Aug '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8714

1 0

Re: [PATCH v2 0/1] MR8717: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) 06 Aug '25

06 Aug '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8717

1 0

Re: [PATCH v2 0/1] MR8716: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 06 Aug '25

06 Aug '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8716

1 0

[PATCH 0/5] MR8723: cfgmgr32: device query part 3: Add support for basic filter expressions.
by Vibhav Pant (＠vibhavp) 06 Aug '25

06 Aug '25

Support filter expressions consisting of basic comparison operators in DevGetObjects(Ex). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8723

2 5

[PATCH 0/1] MR8707: Draft: dxgi: Add IDXGIOutput::WaitForVBlank semi-stub
by Mike Kozelkov (＠augenzi) 06 Aug '25

06 Aug '25

Qt 6.9 Gui module on Windows with D3D 11 and 12 uses dedicated vblank watcher thread to update window (https://doc.qt.io/qt-6/whatsnew69.html) This thread calls IDXGIOutput::WaitForVBlank that must halt the thread until the next vblank occurs. This implementation is based on incorrect calculation of vblank occurrence. But it helps to update window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8707

2 2

[PATCH 0/1] MR8270: mf: Prevent double submission of session commands.
by Yuxuan Shui (＠yshui) 06 Aug '25

06 Aug '25

This is not the right fix, and I need some help. Let me explain. `session_submit_command` checks that: 1. `session->commands` is empty, and 2. `SESSION_FLAG_PENDING_COMMAND` is NOT set before submitting the `session_op`. The assumption is, if there are queued commands, or if there is a command currently running, that pending command will submit subsequent commands when it completes. However, in this call chain: ``` #0 0x00006fffe1d27ad7 in create_async_result (object=object(a)entry=0x0, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0, out=out(a)entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1229 #1 0x00006fffe1d222d5 in RtwqCreateAsyncResult (object=object(a)entry=0x0, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0, out=out(a)entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1245 #2 0x00006fffd45e2096 in MFPutWorkItem (queue=queue(a)entry=1, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0) at ../dlls/mfplat/queue.c:46 #3 0x00006fffe41244ee in session_command_complete (session=0x7e62489f1be0) at ../dlls/mf/session.c:975 #4 0x00006fffe412d00f in session_reset (session=session(a)entry=0x7e62489f1be0) at ../dlls/mf/session.c:1051 #5 0x00006fffe41299fc in session_handle_source_shutdown (session=session(a)entry=0x7e62489f1be0) at ../dlls/mf/session.c:2957 #6 0x00006fffe4126e90 in session_events_callback_Invoke (iface=0x7e62489f1c20, result=<optimized out>) at ../dlls/mf/session.c:4445 ``` nowhere was the `SESSION_FLAG_PENDING_COMMAND` flag set. In addition to that, `session_events_callback_Invoke` is not a command. So this could happend: ``` Thread 1 | Thread 2 call session_events_callback_Invoke | | call session_submit_command | <critical section> | list_empty(&session->commands) is true, and PENDING_COMMAND not set | MFPutWorkItem(op) | list_add(&session->commands, op) <- (1) | </critical_section> call session_handle_source_shutdown | <critical_section> | call session_reset | call session_command_complete | list_head(&session->commands) | op is returned because of (1) | MFPutWorkItem(op) again | </critical_section> | ``` The result is this op will be executed twice, and also double freed, because `session_commands_callback_Invoke` releases the `op`. * * * There is even another way an `op` can be submitted twice, `session_handle_start_error` calls `session_reset`, which already calls `session_command_complete`, and later it calls `session_command_complete_with_event` again. I think a missing return? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8270

3 7