September 2025 - Wine-gitlab

[PATCH v2 0/2] MR8970: kernel32/kernelbase: Implemented NUMA functions and improved affinity support
by Danny Waser (＠wasertech) 16 Sep '25

16 Sep '25

This merge request implements several NUMA functions previously stubbed in kernel32 and kernelbase, adds a basic NUMA node discovery/topology layer, and enriches the associated tests. It also improves the traceability of SetThreadGroupAffinity. ## Context / Motivation Some Windows applications (game engines, middleware, runtimes) query the NUMA API to adapt memory allocation or thread distribution. The lack of an implementation returned errors (ERROR_CALL_NOT_IMPLEMENTED) or unhelpful values, which could degrade the internal heuristics of these programs. This first implementation provides: - A logical topology derived from GetLogicalProcessorInformation. - A reasonable approximation of available memory per node. - Consistent processor masks for the present nodes. It prepares for future optimizations (targeted memory allocation, better scheduling strategies) without modifying the existing behavior of generic allocations. ## Main Changes - `kernel32/process.c`: - Implementation of GetNumaNodeProcessorMask, GetNumaAvailableMemoryNode / Ex, GetNumaProcessorNode / Ex, GetNumaProximityNode. - Parameter validation and consistent error propagation (ERROR_INVALID_PARAMETER). - `kernelbase/memory.c`: - New NUMA infrastructure (topology cache, lazy initialization, dedicated critical lock). - Topology reading via GetLogicalProcessorInformation. - Runtime options via environment variables: - WINE_NUMA_FORCE_SINGLE: Force a single logical node. - WINE_NUMA_CONTIG: Remap masks to produce contiguous blocks. - Implementations of GetNumaHighestNodeNumber, GetNumaNodeProcessorMaskEx, GetNumaProximityNodeEx. - Robust fallback: if no NUMA info → single node. - `kernelbase/thread.c`: - Added detailed traces in SetThreadGroupAffinity (removed the redundant DECLSPEC_HOTPATCH here). - Tests (`dlls/kernel32/tests/process.c`): - Added a new test, test_NumaBasic, covering: - GetNumaHighestNodeNumber - GetNumaNodeProcessorMaskEx (nodes 0 and 1) - GetNumaProximityNodeEx - Tolerant behavior: accepts `ERROR_INVALID_FUNCTION` / `ERROR_INVALID_PARAMETER` depending on the platform. - Added the `WINE_DEFAULT_DEBUG_CHANNEL(numa)` debug channel for the subsystem. ## Assumptions / Limitations - Support for a single processor group (Group = 0) for now. - Memory approximation: equal division of available physical memory (improvable later with internal counters per node). - Proximity = node (simplistic direct mapping). - No impact yet on VirtualAlloc / Heap allocation by node. ## Security / Concurrency - Initialization protected by dedicated critical section (numa_cs). - Thread-safe lazy read. - Table bounded to 64 nodes (historical Windows limit). ## Compatibility Impact - Improves compatibility with software probing the NUMA API. - Low risk of regression: previously failed paths now return TRUE with consistent data. - In case of topology collection failure → single-node fallback (conservative behavior). ## Validation / Tests - New test_NumaBasic added and integrated into the process suite. - Traces (numa channel) allow for detection diagnostics. - Invalid parameters tested (NULL, nodes out of range). - Works in environments without real NUMA via fallback. ## Environment Variables (quick documentation) - WINE_NUMA_FORCE_SINGLE=1: Forces a single node (mask covering all CPUs). - WINE_NUMA_CONTIG=1: Reallocates compact bit blocks per node (useful if the topology returns sparse masks). ## Potential Next Steps (not included) - Implement true memory tracking per node (via allocation hooks). - Multi-group support (PROCESSOR_GROUP_INFO). - Improved VirtualAllocExNuma / First-touch implementation. - More accurate proximity-to-node mapping on complex NUMA platforms. - Dedicated tests for environment variables. ## Potential Risks / Regressions - Applications relying on the absence of an API may slightly change their strategy (low). - Masks remapped with WINE_NUMA_CONTIG could surprise a profiling tool (opt-in option). - Memory approximation too coarse for very fine-grained heuristics (no functional regression expected). ## Request for Review - Verify logging conventions and TRACE_(numa) usage. - Verify the relevance of removing DECLSPEC_HOTPATCH on SetThreadGroupAffinity (alignment with local conventions). - Opinion on error granularity (ERROR_INVALID_PARAMETER vs. ERROR_INVALID_FUNCTION) for more accurate mimicry. Once the kernel can handle those functions directly (in a NUMA module i.e.) we could use this implementation as a fallback when the kernel doesn't support NUMA natively (when the module cannot be loaded). -- v2: kernelbase: Improve initialization of NUMA information to handle pathological cases https://gitlab.winehq.org/wine/wine/-/merge_requests/8970

5 22

[PATCH v2 0/6] MR8960: mshtml: Implement XDomainRequest.
by Gabriel Ivăncescu 16 Sep '25

16 Sep '25

-- v2: mshtml: Implement contentType for XDomainRequest. mshtml: Implement timeout for XDomainRequest. mshtml: Implement XDomainRequest.open(). mshtml: Add XDomainRequest factory implementation. mshtml: Factor out XMLHttpRequest constructor init. mshtml: Factor out XMLHttpRequest creation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8960

2 9

[PATCH v2 0/11] MR8961: Draft: dwrite: Create font collections using font set objects.
by Nikolay Sivov (＠nsivov) 16 Sep '25

16 Sep '25

-- v2: dwrite: Reuse font set entries to return set instances for collections. dwrite/tests: Add a small test for EUDC collection. dwrite: Cache set elements for returned system sets. dwrite: Remove nested structures in fontset entries. dwrite: Simplify collection initialization helper. dwrite: Create custom collections using font sets. dwrite: Create both WWS and typographic system collections using system font set. dwrite: Mark system font sets. dwrite: Remove system collection marker. dwrite: Check against local file loader in ConvertFontToLOGFONT(). dwrite/tests: Add some more tests for ConvertFontToLOGFONT(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8961

3 12

[PATCH v2 0/1] MR8906: Draft: dwrite: Cache fontset entries when one is created from a collection.
by Tim Clem (＠tclem) 16 Sep '25

16 Sep '25

Motivation is Ubisoft Connect, which calls IDWriteFontCollection::GetFontSet many times on the system font collection, and then GetMatchingFonts on those sets. Without a change like this, each set created by GetFontSet has a separate cache of `dwrite_fontset_entry`s, so the GetMatchingFonts calls rescan every font on the system (via dwritefontset_GetMatchingFonts -> fontset_entry_is_matching -> fontset_entry_get_property, which does not find cached properties and thus makes a new file stream). Perhaps it makes sense to not have the `owns_entries` flag in all the dwrite_fontset initializers, and just set it as needed in IDWriteFontCollection::GetFontSet? (And perhaps to invert it to `unowned_entries` or something, so the calloc initialization sets the most common value?) -- v2: dwrite: Reuse entries when a font set is created from a collection. https://gitlab.winehq.org/wine/wine/-/merge_requests/8906

3 8

[PATCH 0/4] MR8974: dmsynth: Don't force enable DMUS_EFFECT_REVERB.
by Anton Baskanov (＠baskanov) 16 Sep '25

16 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8974

3 6

[PATCH v13 0/5] MR8890: windows.devices.enumeration: Add support for parsing AQS filter strings.
by Vibhav Pant (＠vibhavp) 16 Sep '25

16 Sep '25

-- v13: maintainers: Add a section for Windows.Devices.Enumeration. windows.devices.enumeration: Support parsing AQS filters in IDeviceInformationStatics::{FindAllAsyncAqsFilter, CreateWatcherAqsFilter}. windows.devices.enumeration/tests: Add tests for IDeviceInformationStatics::{FindAllAsyncAqsFilter, CreateWatcherAqsFilter}. https://gitlab.winehq.org/wine/wine/-/merge_requests/8890

3 9

Re: [PATCH v12 0/9] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy 16 Sep '25

16 Sep '25

On Tue Sep 16 12:48:37 2025 +0000, eric pouech wrote: > Kept translation matches the removed fuzzy entry, not the kept msgid. The fuzzy matches must be deleted for the translation to take effect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8857#note_115962

1 0

Re: [PATCH v12 0/9] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy 16 Sep '25

16 Sep '25

On Tue Sep 16 12:48:37 2025 +0000, Nikolay Sivov wrote: > Here it's fine to remove it, because original text does not have it. The “fuzzy” translations block the translation after the fact. It would be better to delete the fuzzy translations and do a side-by-side translation so that everything is taken into account. For example, in “winecfg,” under “integration with the desktop,” you will see what I mean. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8857#note_115961

1 0

[PATCH v11 0/9] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy 16 Sep '25

16 Sep '25

-- v11: Update modify fr.po https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 9

[PATCH v10 0/8] MR8857: Update fr.po/Resource "Open with" association file programs shell32/New : winemenumgr
by Allan Rémy 16 Sep '25

16 Sep '25

-- v10: Remove .gitkeep https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 12